[dragonplayer] [Bug 376961] Can't hide menu bar

2018-10-09 Thread Harald Sitter 
https://bugs.kde.org/show_bug.cgi?id=376961

Harald Sitter  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dra
   ||gon/96c7f9314c4ef181c8a55f3
   ||e0aad0cfefb608e18
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Harald Sitter  ---
Git commit 96c7f9314c4ef181c8a55f3e0aad0cfefb608e18 by Harald Sitter, on behalf
of Arthur Pichlkostner.
Committed on 09/10/2018 at 11:38.
Pushed by sitter into branch 'Applications/18.08'.

Fix: user settings for gui not saved after program is closed

Summary:
When the player switches to full screen mode the settings for the visibility of
menubar, toolbar and statusbar are set to fixed values and the user settings
are saved in backup variables.
These backup values are restored when the player is closed. If the player is
not in full screen mode, the backup variable have default values and the user
settings are overwritten.

Solution: Restore settings only when the window is in fullscreen mode.

Reviewers: sitter

Reviewed By: sitter

Differential Revision: https://phabricator.kde.org/D15594

M  +6-4src/app/mainWindow.cpp

https://commits.kde.org/dragon/96c7f9314c4ef181c8a55f3e0aad0cfefb608e18

-- 
You are receiving this mail because:
You are watching all bug changes.

[dragonplayer] [Bug 376961] Can't hide menu bar

2017-08-21 Thread Burkhard Lueck 
https://bugs.kde.org/show_bug.cgi?id=376961

--- Comment #3 from Burkhard Lueck  ---
*** Bug 375064 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dragonplayer] [Bug 376961] Can't hide menu bar

2017-03-14 Thread Harald Sitter 
https://bugs.kde.org/show_bug.cgi?id=376961

--- Comment #2 from Harald Sitter  ---
(In reply to Hrishikesh Barman from comment #1)
> I have been looking into the code, can anyone help me with where should I
> start. I've tried understanding the top down approach from the main.cpp to
> partToolbar.cpp and the fullScreenToolBarHandler.cpp. It will be helpful if
> someone can point me where the code for keyboard shortcut ctrl+m exists.

In MainWindow::setupActions. That probably won't help because none of the logic
lives there though, only the shortcut setup. The code actually managing the
menubar show/hide is in the framework kxmlgui in the file kmainwindow.cpp.

FWIW, since this is entirely controlled by the that framework I'd first have a
look if other applications with this feature work as expected. If not, the
chances are high that the bug is in fact in the framework and not how dragon
uses it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dragonplayer] [Bug 376961] Can't hide menu bar

2017-03-13 Thread Hrishikesh Barman 
https://bugs.kde.org/show_bug.cgi?id=376961

--- Comment #1 from Hrishikesh Barman  ---
I have been looking into the code, can anyone help me with where should I
start. I've tried understanding the top down approach from the main.cpp to
partToolbar.cpp and the fullScreenToolBarHandler.cpp. It will be helpful if
someone can point me where the code for keyboard shortcut ctrl+m exists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dragonplayer] [Bug 376961] Can't hide menu bar

2017-03-13 Thread Hrishikesh Barman 
https://bugs.kde.org/show_bug.cgi?id=376961

Hrishikesh Barman  changed:

   What|Removed |Added

 CC||hrishikeshb...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dragonplayer] [Bug 376961] Can't hide menu bar

2017-02-28 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=376961

Christoph Feck  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.