[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 Matthieu Gallien changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://commits.kde.org/eli ||sa/79054e47bb532eec4b3fbc87 ||2a7a1c5e32910456 Resolution|--- |FIXED --- Comment #6 from Matthieu Gallien --- Git commit 79054e47bb532eec4b3fbc872a7a1c5e32910456 by Matthieu Gallien. Committed on 25/03/2019 at 20:40. Pushed by mgallien into branch 'master'. Simplify and improve music indexers management Summary: start baloo first and if it is not available, start local file indexer remove management of track discovery sources simplify management of tracks by removing management of which source has discovered a track should allow users to easily switch from Baloo to local file system as tracks source improve management of tracks sources such that only baloo or local file system scanning is enabled no longer emit a signal when Elisa cannot watch a file for changes refactor the way we check for Baloo availability filter tracks by the configured paths when getting all tracks from Baloo use the same list of paths than plain file system scanning remove double checking for baloo configuration: not needed Baloo configuration is now checked before going into LocalBalooFileListing: no need to do it a second time add support for qt logging category and use it for file indexers improve management of indexers state and user reporting convert LocalBalooFileListing to only use categorized debug logs hopefully fix the display of busy indexers notifications when configuration change, display proper busy notification to the user indexing is no longer finished until tracks have been fully removed Test Plan: Only one indexer is active (baloo or plain old file indexer). Traces should help diagnose what happen Reviewers: ngraham Tags: #elisa Differential Revision: https://phabricator.kde.org/D19650 M +10 -10 autotests/alltracksproxymodeltest.cpp M +73 -266 autotests/databaseinterfacetest.cpp M +31 -31 autotests/datamodeltest.cpp M +15 -125 autotests/localfilelistingtest.cpp M +3-3autotests/manageheaderbartest.cpp M +3-3autotests/managemediaplayercontroltest.cpp M +47 -47 autotests/mediaplaylisttest.cpp M +6-6autotests/trackslistenertest.cpp M +36 -0src/CMakeLists.txt M +10 -3src/abstractfile/abstractfilelistener.cpp M +3-1src/abstractfile/abstractfilelistener.h M +57 -27 src/abstractfile/abstractfilelisting.cpp M +19 -10 src/abstractfile/abstractfilelisting.h M +21 -19 src/audiowrapper_libvlc.cpp A +117 -0src/baloo/baloodetector.cpp [License: LGPL (v3+)] A +67 -0src/baloo/baloodetector.h [License: LGPL (v3+)] M +69 -82 src/baloo/localbaloofilelisting.cpp M +0-6src/baloo/localbaloofilelisting.h M +1008 -616 src/databaseinterface.cpp M +39 -10 src/databaseinterface.h M +0-11 src/elisa_core.kcfg M +1-1src/elisaimport.cpp M +0-12 src/file/filelistener.cpp M +0-15 src/file/filelistener.h M +10 -22 src/file/localfilelisting.cpp M +0-15 src/file/localfilelisting.h M +1-1src/localFileConfiguration/localfileconfiguration.cpp M +48 -8src/musicaudiotrack.cpp M +10 -0src/musicaudiotrack.h M +173 -104 src/musiclistenersmanager.cpp M +48 -8src/musiclistenersmanager.h M +11 -15 src/qml/ElisaMainWindow.qml M +28 -11 src/qml/TrackImportNotification.qml https://commits.kde.org/elisa/79054e47bb532eec4b3fbc872a7a1c5e32910456 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 Matthieu Gallien changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Matthieu Gallien --- I have implemented proper filtering in the Baloo indexer such that settings apply whether baloo or plain old files indexers are used. https://phabricator.kde.org/D19650 Could you please test and report ? -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 Matthieu Gallien changed: What|Removed |Added CC||eliassicher...@gmail.com --- Comment #4 from Matthieu Gallien --- *** Bug 399624 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 --- Comment #3 from Matthieu Gallien --- I have created the following task https://phabricator.kde.org/T9082 . It is a good way to start contributing to the c++ part of Elisa. It is currently flagged as a junior job. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 --- Comment #2 from John --- I want do add a folder for example /home/xxx/music and in elisa should only show up the m4a, aac, mp3 ... files from this folder and not from the whole system. And I also would be very happy if it would be possible to list for Track, Album and Album-Artist. If there is no Album-Artist use as fallback the Artist Tag. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 Matthieu Gallien changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Matthieu Gallien --- Thanks for your report. The configuration dialog is only for the Elisa music indexer. There is not yet a way to configure the Baloo integration. If I understand your need, you would like to use Baloo support but only for some paths ? -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 393106] When I specify a path, it still uses baloo and looks everywhere for files
https://bugs.kde.org/show_bug.cgi?id=393106 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
