[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #16 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/76 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #15 from Nate Graham --- It can't hurt to try. :) You can solicit comments from experienced developers in the merge request. They are *much* more likely to do so there than to notice this bug report. https://community.kde.org/Infrastructure/GitLab#Submitting_a_Merge_Request -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #14 from crc --- (In reply to Nate Graham from comment #13) > Good catch. Since you've already done some investigation, would you be > interested in submitting a merge request to fix it? Many thanks for your appreciate! But unfortunately I'm not a professional developer, so I don't know how to correctly submit a merge request. Besides, the original code solving the problem seems primal, even a bit ugly now. So I suggest the current code changing may have its own reason, and simply restore the old one,which is the only workaround I found, may not be a good choice for a long term solution. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED --- Comment #13 from Nate Graham --- Good catch. Since you've already done some investigation, would you be interested in submitting a merge request to fix it? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #12 from crc --- Hi there! I reopened this bug report because the very same problem reappeared since version 5.98. I've noticed that the code in Kglobalaccel's dBus components handler to transform all non-ascii characters in a path to ''_" has been changed to use "replace" function in C++, probably brought the bug back. For example, in my system a desktop file named "网易云音乐.desktop" (the file has long been deleted and I don't know why the path remains there) was wrongly transformed to "网___乐_desktop", causing "invalid path" error report in dbus, and made it impossible to access kglobalaccel via systemsettings5 anymore. I tried to restore the old script that once saved the problem (see comment 9) in kglobalaccel's source code and recompile it, then the bug was all gone. So I think the current code of kglobalaccel may need rechecking. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #11 from crc --- Hi there! I reopend this bug report -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 crc changed: What|Removed |Added Status|RESOLVED|REOPENED Version|5.70.0 |5.99.0 Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||5.71 Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/kglobalaccel/commit/ ||f784038a7aa9be63927cef0d526 ||b708bd6d21af0 --- Comment #10 from Nate Graham --- Git commit f784038a7aa9be63927cef0d526b708bd6d21af0 by Nate Graham, on behalf of José Renan Silva Luciano. Committed on 26/05/2020 at 21:39. Pushed by ngraham into branch 'master'. Fix bug with components containing special characters FIXED-IN: 5.71 M +2-1src/runtime/component.cpp https://invent.kde.org/frameworks/kglobalaccel/commit/f784038a7aa9be63927cef0d526b708bd6d21af0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139
--- Comment #9 from crc ---
(In reply to José Renan from comment #8)
> (In reply to crc from comment #7)
> > (In reply to crc from comment #6)
> > > (In reply to Christoph Feck from comment #4)
> > > > "é" is a Latin-1 character, but not ASCII. It needs an additional
> > > > ch.unicode() < 0x7F check.
> > >
> > > Having just the same problem in Kglobalaccel after adding a shortcut to a
> > > desktop file with chinese characters. Adding this additional check may
> > > solve
> > > it,but how can this be done?
> >
> > I finally solved the problem by adding the additonal check to the soucecode
> > of Kglobalaccel cloning from https://anongit.kde.org/kglobalaccel.git and
> > compiling it in my system, then created a soft link from the compiled
> > Kglobalaccel5 file to /usr/bin, it just worked fine. So this is certainly
> > proved to be at least a temporary solution for the problem, many thanks!!!
>
> Could you send a snippet with what exactly you added?
Sorry for replying late. I just modified Kglobalaccel source code in
src/runtime/component.cpp following your and Michael Pyne's suggestions. The
modification of component.cpp:203 is as follows:
QDBusObjectPath Component::dbusPath() const
{
QString dbusPath = _uniqueName;
const int len = dbusPath.length();
for ( int i = 0; i < len; ++i )
{
if ( !dbusPath[i].isLetterOrNumber()
|| dbusPath[i].unicode() >= 0x7F)
dbusPath[i] = QLatin1Char('_');
}
return QDBusObjectPath( _registry->dbusPath().path() + "component/" +
dbusPath);
}
I just add "dbusPath[i].unicode() >= 0x7F" check after the original
".isLetterOrNumber()" check, which will translate all international characters
to "_". I have to admit that I'm no program developer and only learned some
basic c++ during college time, so I'm not quit sure whether this adding is all
correct. But after this modification the compile progress went smoothly and the
complied Kglobalaccel5 run all fine on my Manjaro system, the bug never
appeared again, so I think this can prove that the check adding just works.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #8 from José Renan --- (In reply to crc from comment #7) > (In reply to crc from comment #6) > > (In reply to Christoph Feck from comment #4) > > > "é" is a Latin-1 character, but not ASCII. It needs an additional > > > ch.unicode() < 0x7F check. > > > > Having just the same problem in Kglobalaccel after adding a shortcut to a > > desktop file with chinese characters. Adding this additional check may solve > > it,but how can this be done? > > I finally solved the problem by adding the additonal check to the soucecode > of Kglobalaccel cloning from https://anongit.kde.org/kglobalaccel.git and > compiling it in my system, then created a soft link from the compiled > Kglobalaccel5 file to /usr/bin, it just worked fine. So this is certainly > proved to be at least a temporary solution for the problem, many thanks!!! Could you send a snippet with what exactly you added? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 --- Comment #7 from crc --- (In reply to crc from comment #6) > (In reply to Christoph Feck from comment #4) > > "é" is a Latin-1 character, but not ASCII. It needs an additional > > ch.unicode() < 0x7F check. > > Having just the same problem in Kglobalaccel after adding a shortcut to a > desktop file with chinese characters. Adding this additional check may solve > it,but how can this be done? I finally solved the problem by adding the additonal check to the soucecode of Kglobalaccel cloning from https://anongit.kde.org/kglobalaccel.git and compiling it in my system, then created a soft link from the compiled Kglobalaccel5 file to /usr/bin, it just worked fine. So this is certainly proved to be at least a temporary solution for the problem, many thanks!!! -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 crc changed: What|Removed |Added CC||crc2...@126.com Version|5.57.0 |5.70.0 Status|REOPENED|CONFIRMED Platform|Other |Manjaro --- Comment #6 from crc --- (In reply to Christoph Feck from comment #4) > "é" is a Latin-1 character, but not ASCII. It needs an additional > ch.unicode() < 0x7F check. Having just the same problem in Kglobalaccel after adding a shortcut to a desktop file with chinese characters. Adding this additional check may solve it,but how can this be done? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 José Renan changed: What|Removed |Added CC||joserenans...@gmail.com --- Comment #5 from José Renan --- > As a result, I can't access the global shortcuts panel in systemsettings5. > How can I remove this offending entry? I've tried to edit > ~/.config/kglobalaccelrc but the offending group "vlc-bébé.desktop" reappears > on next login. Where is this data stored? I'm having this same problem, do you have a solution or workaround to solve this?? I created a shortcut with an entry named "Selecionar área do print.desktop" and now I'm getting: `DBusObjectPath: invalid path "/component/Selecionar_área_do_print_desktop"` -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs --- Comment #4 from Christoph Feck --- "é" is a Latin-1 character, but not ASCII. It needs an additional ch.unicode() < 0x7F check. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139
Michael Pyne changed:
What|Removed |Added
CC||mp...@kde.org
--- Comment #3 from Michael Pyne ---
Oddly, KGlobalAccel does appear to have some code in its DBus component handler
to try to clean up paths to conform to DBus requirements. See
src/runtime/component.cpp:203:
QDBusObjectPath Component::dbusPath() const
{
QString dbusPath = _uniqueName;
// Clean up for dbus usage: any non-alphanumeric char should be turned into
'_'
const int len = dbusPath.length();
for ( int i = 0; i < len; ++i )
{
if ( !dbusPath[i].isLetterOrNumber() )
dbusPath[i] = QLatin1Char('_');
}
// QDBusObjectPath could be a little bit easier to handle :-)
return QDBusObjectPath( _registry->dbusPath().path() + "component/" +
dbusPath);
}
The problem seems to be the ".isLetterOrNumber" check, which doesn't actually
strip non-ASCII characters. Since every character in "bébé" is a Unicode
letter, no translation happens here. Added a check that the QChar returned by
dbusPath[i] is actually a latin-1 characters (e.g. with QChar::toLatin1) would
seem to be necessary.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 nicolas.s-...@laposte.net changed: What|Removed |Added Resolution|NOT A BUG |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #2 from nicolas.s-...@laposte.net --- Thanks for your feedback. I'm reopening because : 1. It's not possible to access kglobalaccel via systemsettings5 anymore and I've found no way to recover from this issue. 2. Trying to reset to the defaults makes systemsettings5 to crash. 3. There should be a warning or error at creation time when adding the desktop app file. Once the destop app file is added via systemsettings5 it's too late. The kde configuration system is bugging and crashing after the destop app was added. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kglobalaccel] [Bug 407139] kglobalaccel fails with QDBusObjectPath: invalid path "/component/vlc_bébé_desktop"
https://bugs.kde.org/show_bug.cgi?id=407139 Christoph Feck changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |NOT A BUG --- Comment #1 from Christoph Feck --- Desktop filenames cannot contain international characters. They are transmitted via D-Bus and need to be ASCII. Of course the Name= field can contain any characters. -- You are receiving this mail because: You are watching all bug changes.
