[frameworks-kuserfeedback] [Bug 391523] Code improvement: reduce unnecessary switch

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=391523

Volker Krause  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kuserfeedback] [Bug 391523] Code improvement: reduce unnecessary switch

[Aleksey Kontsevich]

https://bugs.kde.org/show_bug.cgi?id=391523

--- Comment #3 from Aleksey Kontsevich  ---
I see :) Did not thought about tr(). Ok. Just wanted to improve the code :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kuserfeedback] [Bug 391523] Code improvement: reduce unnecessary switch

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=391523

--- Comment #2 from Volker Krause  ---
Code-wise I agree with your suggestion, but human languages don't work like
this unfortunately ;)

In English this is fine, in German however the translation of "this" varies
based on the context it's used in. I suspect there are more languages this is
translated to with similar grammatical issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kuserfeedback] [Bug 391523] Code improvement: reduce unnecessary switch

[Aleksey Kontsevich]

https://bugs.kde.org/show_bug.cgi?id=391523

--- Comment #1 from Aleksey Kontsevich  ---
Copy paste missplell - need to change to:

const auto name = (d->appName().isEmpty()) ? "this application" : d->appName();

-- 
You are receiving this mail because:
You are watching all bug changes.