[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Jean-Baptiste Mardelle changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/kdenlive/commit/d7a8 |imedia/kdenlive/commit/9648 |c463f60e9b5fe757c9af4acf9eb |cb12294da4295654d4e7abc03e1 |be672c530 |d7b0b2903 --- Comment #13 from Jean-Baptiste Mardelle --- Git commit 9648cb12294da4295654d4e7abc03e1d7b0b2903 by Jean-Baptiste Mardelle, on behalf of Eric Jiang. Committed on 27/07/2022 at 11:47. Pushed by mardelle into branch 'release/22.08'. Fix filtering TreeItem lists by non-ASCII strings AssetFilter tries to normalize the TreeItem's text by removing any punctuation and symbols, but it was done using a simple [^a-zA-Z0-9\s] character class which removed any non-ASCII characters, breaking the search for many non-English languages. Replacing this with [^\w\s] didn't work, but iterating through the string and using isLetterOrNumber() does work. M +16 -4src/assets/assetlist/model/assetfilter.cpp M +8-0src/assets/assetlist/model/assetfilter.hpp M +16 -2tests/treetest.cpp https://invent.kde.org/multimedia/kdenlive/commit/9648cb12294da4295654d4e7abc03e1d7b0b2903 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Julius Künzel changed: What|Removed |Added CC||jk.kde...@smartlab.uber.spa ||ce Flags|Brainstorm+ | -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #12 from Tyson Tan --- Thank you Eric! :D -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Eric Jiang changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/mult ||imedia/kdenlive/commit/d7a8 ||c463f60e9b5fe757c9af4acf9eb ||be672c530 Status|ASSIGNED|RESOLVED --- Comment #11 from Eric Jiang --- Git commit d7a8c463f60e9b5fe757c9af4acf9ebbe672c530 by Eric Jiang. Committed on 27/07/2022 at 05:29. Pushed by mardelle into branch 'master'. Fix filtering TreeItem lists by non-ASCII strings AssetFilter tries to normalize the TreeItem's text by removing any punctuation and symbols, but it was done using a simple [^a-zA-Z0-9\s] character class which removed any non-ASCII characters, breaking the search for many non-English languages. Replacing this with [^\w\s] didn't work, but iterating through the string and using isLetterOrNumber() does work. M +16 -4src/assets/assetlist/model/assetfilter.cpp M +8-0src/assets/assetlist/model/assetfilter.hpp M +16 -2tests/treetest.cpp https://invent.kde.org/multimedia/kdenlive/commit/d7a8c463f60e9b5fe757c9af4acf9ebbe672c530 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Eric Jiang changed: What|Removed |Added Assignee|vpi...@kde.org |erji...@alumni.iu.edu Status|CONFIRMED |ASSIGNED --- Comment #10 from Eric Jiang --- Looks like the code tries to normalize the text (for better searchability) by removing all alphanum and space characters, but it specifies "[^a-zA-Z0-9\\s]" and doesn't account for non-English names. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Shinjo Park changed: What|Removed |Added CC||k...@peremen.name --- Comment #9 from Shinjo Park --- Can confirm also in Korean language too. Some effect names are translated as of 21.12.3, but searching using translation does not work. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Jean-Baptiste Mardelle changed: What|Removed |Added CC||j...@kdenlive.org --- Comment #8 from Jean-Baptiste Mardelle --- So to start Kdenlive in another language, you must first ensure that the translations are correctly installed, which can be painful. If you compile Kdenlive yourself, you need to install "ruby" and "svn" (subversion), then call cmake with the following param: cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DKDE_L10N_SYNC_TRANSLATIONS=ON (the important part being "-DKDE_L10N_SYNC_TRANSLATIONS=ON") Then make and make install. After this, in Kdenlive, go to Settings > Configure Language and click "Default", then close the app. After this, from a terminal: LANG=fr_FR.UTF-8 kdenlive will start as french (replace fr_FR with whatever language code you want). -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #7 from Tyson Tan --- Created attachment 148682 --> https://bugs.kde.org/attachment.cgi?id=148682=edit kdenlive effect name translations incomplete -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #6 from Tyson Tan --- The Windows version has a package issue causing translation to be missing for all dialogues, for years now. On my Arch Linux, the official appimage shows SOME translations for the effects. There are some effects that don't seem to have been properly i18n. Like Pan, Fade-in, Fade-out, etc. I swear to god I have translated 100% of the thing, and I have translated these names, but they just won't show up. Other effect names like Normalization, Gain, etc shows proper translations. This is definitely not an issue that can be solved by merely an environment variable... -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #5 from Eric Jiang --- (In reply to emohr from comment #4) > @Eric Jiang: Do you are on Windows? No, I'm using Kdenlive on Linux. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #4 from emohr --- @Eric Jiang: Do you are on Windows? -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 Eric Jiang changed: What|Removed |Added CC||erji...@alumni.iu.edu --- Comment #3 from Eric Jiang --- Is there a way to run Kdenlive in a specific language, maybe with an environment variable? I tried using LANGUAGE=zh which seemed to make some strings Chinese but most of the UI, including the effects list, was still in English. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 --- Comment #2 from Tyson Tan --- Krita 4.4.x haven't yet support unicode for its resource items. The upcoming Krita 5.0.0 was said to have unicode support, but the lastest nightly version still haven't implemented the feature. digiKam have a working implementation of CJK-enabled text filter. I've just tested it on digiKam 7.2.0 RC. I can assign a CJK tag, then filter the result using the text filter. But I'm not sure the differences between a user-assigned tag and resource names. I'm not a programmer, so I might not be of much help here. Last time something similar happened on https://docs.krita.org/ , which was built using Sphinx. It can't tell a keyword without space, or it can't search letter by letter (which is how CJK search behaves) which might be a common cause of this kind of bugs. The bug report can be found here: https://bugs.kde.org/show_bug.cgi?id=419321 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 432699] Effects list's filter field does not work for CJK characters
https://bugs.kde.org/show_bug.cgi?id=432699 emohr changed: What|Removed |Added CC||fritzib...@gmx.net Flags||Brainstorm+ Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from emohr --- As far as I know we never tested Kdenlive with CJK characters. Do you know if KRITA work with CJK characters? If so can you give a hint how to solve this in Kdenlive? -- You are receiving this mail because: You are watching all bug changes.
