[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=368340

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/network/kopete/-/merge_requests/10

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Bernhard Schmidt]

https://bugs.kde.org/show_bug.cgi?id=368340

Bernhard Schmidt  changed:

   What|Removed |Added

 CC||be...@birkenwald.de

--- Comment #10 from Bernhard Schmidt  ---
Felix has created a patch that builds fine both against old and new
mediastreamer2 libraries and submitted it to https://phabricator.kde.org/D15956

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Felix Lechner]

https://bugs.kde.org/show_bug.cgi?id=368340

Felix Lechner  changed:

   What|Removed |Added

 CC||felix.lech...@lease-up.com

--- Comment #9 from Felix Lechner  ---
Created attachment 114432
  --> https://bugs.kde.org/attachment.cgi?id=114432=edit
Non-working skeleton patch against Debian version 4:17.08.3-1

Hi, I am part of the Linphone team at Debian and tried to patch kopete. This
bug is keeping us from upgrading Linphone. Unfortunately, I have unrelated
build problems with kopete, and cannot get the build process to stop at an
error. The patch is against Debian version 4:17.08.3-1.

I am posting my untested, non-working skeleton patch for now. I am happy to
cooperate if upstream has additional pointers. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #8 from Pali Rohár  ---
(In reply to David Geiger from comment #7)
> We have now the same issue on Mageia6.

Problem is because external mediastreamer library changed its API.

I have not find any information about it yet, nor how to port old applications.

Proposed patch pass NULL pointer to some functions, but again I did not find
anything about it, that this is really correct solution.

Passing NULL on "random" place without understood 'WHY?' is wrong solution.

I would suggest to report bug to mediastreamer project, that they broke API and
existing application... And without providing any information what to do...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[David Geiger]

https://bugs.kde.org/show_bug.cgi?id=368340

David Geiger  changed:

   What|Removed |Added

 CC||geiger.david68...@gmail.com

--- Comment #7 from David Geiger  ---
Hi,

We have now the same issue on Mageia6.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #6 from Fabian Vogt  ---
Ok, I made a review request on https://git.reviewboard.kde.org/r/129325/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #5 from Pali Rohár  ---
Those are probably only compile errors... I can review changes.

Real testing will be harder as I have older libphone version which do not
produce compile errors and it is working fine (testing kopete vs kopete). Also
my automated builds of kopete on all supported and future ubuntu versions
passe, see:
https://launchpad.net/~pali/+archive/ubuntu/kopete/+packages

So verification if compilation is really fixed must be done by somebody already
affected by this bug. But I have no problem of merging this patch to kopete
master as this I believe will be straightforward.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #4 from Fabian Vogt  ---
(In reply to Pali Rohár from comment #3)
> Hi Fabian Vogt! Can you cleanup your patch and post it to
> git.reviewboard.kde.org to kopete group?

I can do that, but I never tried to use it with linphone. If anyone can confirm
that it still works, I'll submit it for review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

Pali Rohár  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368340

Pali Rohár  changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #3 from Pali Rohár  ---
Hi Fabian Vogt! Can you cleanup your patch and post it to
git.reviewboard.kde.org to kopete group?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Fabian Vogt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368340

Fabian Vogt  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #2 from Fabian Vogt  ---
Created attachment 101315
  --> https://bugs.kde.org/attachment.cgi?id=101315=edit
Improved patch

The attached patch works also for building with old versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Antonio Rojas via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #1 from Antonio Rojas  ---
Created attachment 100980
  --> https://bugs.kde.org/attachment.cgi?id=100980=edit
patch

This patch fixes the build for me. I can't test that it works though, as I
don't have a jabber account supporting jingle.

-- 
You are receiving this mail because:
You are watching all bug changes.