[krita] [Bug 345601] On deleting a layer, the layer under the deleted layer should be selected, not the one above

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=345601

--- Comment #4 from Dmitry Kazakov  ---
Git commit 8fd316da11d6ec5c8a129bc88dd042fb0bcdc659 by Dmitry Kazakov.
Committed on 19/08/2020 at 22:08.
Pushed by dkazakov into branch 'krita/4.3'.

Fix temporary wrongly selected layer when merging down huge layers

The problem happened because of our workaround for Qt's removed
item avoidance algorithm. On element removal, Qt selects an item above
that, but we need a reverse, below it.

The previous implementation just tried to fix Qt's behavior after the
removal, but that didn't seem to work correctly in case of merge down.
Therefore, this patch implements a special signal that is fired *before*
beginRemoveRows(), that fixes the selection before Qt can lay its hands
on it.
Related: bug 418922

M  +15   -0libs/ui/kis_node_filter_proxy_model.cpp
M  +4-0libs/ui/kis_node_filter_proxy_model.h
M  +1-0libs/ui/kis_node_model.cpp
M  +1-0libs/ui/kis_node_model.h
M  +9-9plugins/dockers/layerdocker/LayerBox.cpp
M  +1-1plugins/dockers/layerdocker/LayerBox.h

https://invent.kde.org/graphics/krita/commit/8fd316da11d6ec5c8a129bc88dd042fb0bcdc659

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 345601] On deleting a layer, the layer under the deleted layer should be selected, not the one above

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=345601

--- Comment #5 from Dmitry Kazakov  ---
Git commit 87d27964b5893f67c95deb03d73198a8acb6849a by Dmitry Kazakov.
Committed on 19/08/2020 at 22:09.
Pushed by dkazakov into branch 'master'.

Fix temporary wrongly selected layer when merging down huge layers

The problem happened because of our workaround for Qt's removed
item avoidance algorithm. On element removal, Qt selects an item above
that, but we need a reverse, below it.

The previous implementation just tried to fix Qt's behavior after the
removal, but that didn't seem to work correctly in case of merge down.
Therefore, this patch implements a special signal that is fired *before*
beginRemoveRows(), that fixes the selection before Qt can lay its hands
on it.
Related: bug 418922

M  +15   -0libs/ui/kis_node_filter_proxy_model.cpp
M  +4-0libs/ui/kis_node_filter_proxy_model.h
M  +1-0libs/ui/kis_node_model.cpp
M  +1-0libs/ui/kis_node_model.h
M  +9-9plugins/dockers/layerdocker/LayerBox.cpp
M  +1-1plugins/dockers/layerdocker/LayerBox.h

https://invent.kde.org/graphics/krita/commit/87d27964b5893f67c95deb03d73198a8acb6849a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 345601] On deleting a layer, the layer under the deleted layer should be selected, not the one above

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345601

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krit
   ||a/e1da917aac6211d744ace01fe
   ||206314f30f89288
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Dmitry Kazakov  ---
Git commit e1da917aac6211d744ace01fe206314f30f89288 by Dmitry Kazakov.
Committed on 24/03/2016 at 09:35.
Pushed by dkazakov into branch 'master'.

Fix layer selection after removing a node

See a comment in KisLayerBox::slotAboutToRemoveRows()

Fixes T1871

M  +38   -0plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp
M  +1-0plugins/extensions/dockers/defaultdockers/kis_layer_box.h

http://commits.kde.org/krita/e1da917aac6211d744ace01fe206314f30f89288

-- 
You are receiving this mail because:
You are watching all bug changes.