[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[Andrey]

https://bugs.kde.org/show_bug.cgi?id=354376

Andrey  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/d183945d306b12b6dbb3ea2d |ta/3bf0a4f511249b784bb4f8d6
   |d94fb12b88532e24|de0a0bb6acce970d

--- Comment #6 from Andrey  ---
Git commit 3bf0a4f511249b784bb4f8d6de0a0bb6acce970d by Andrey Kamakin, on
behalf of Dmitry Kazakov.
Committed on 26/06/2018 at 14:18.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

Fix painting layer styles in Inherit Alpha mode

The layer style projections (KisMultipleProjection) should be painted
into the final stack using the blending mode selected by the user.

M  +2-0libs/image/kis_cached_paint_device.h
M  +32   -25   libs/image/kis_fill_painter.cc
M  +3-7libs/image/kis_fill_painter.h
M  +1-1   
libs/image/layerstyles/kis_layer_style_filter_projection_plane.cpp
M  +13   -14   libs/image/layerstyles/kis_ls_bevel_emboss_filter.cpp
M  +17   -27   libs/image/layerstyles/kis_ls_overlay_filter.cpp
M  +2-0libs/image/layerstyles/kis_ls_overlay_filter.h
M  +6-8libs/image/layerstyles/kis_ls_stroke_filter.cpp
M  +4-17   libs/image/layerstyles/kis_ls_utils.cpp
M  +16   -2libs/image/layerstyles/kis_multiple_projection.cpp
M  +3-2libs/image/layerstyles/kis_multiple_projection.h
A  +---   
libs/image/tests/data/fill_painter/patterns_fill__custom_origin.png
A  +---   
libs/image/tests/data/fill_painter/patterns_fill__null_origin.png
M  +55   -0libs/image/tests/kis_fill_painter_test.cpp
M  +2-0libs/image/tests/kis_fill_painter_test.h
M  +1-1libs/image/tests/kis_layer_styles_test.cpp

https://commits.kde.org/krita/3bf0a4f511249b784bb4f8d6de0a0bb6acce970d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[brusheco]

https://bugs.kde.org/show_bug.cgi?id=354376

--- Comment #5 from brusheco  ---
Thia was not included in the latest bug fix release 4.0.4. Mistake?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=354376

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kri
   ||ta/d183945d306b12b6dbb3ea2d
   ||d94fb12b88532e24
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit d183945d306b12b6dbb3ea2dd94fb12b88532e24 by Dmitry Kazakov.
Committed on 08/06/2018 at 08:48.
Pushed by dkazakov into branch 'master'.

Fix painting layer styles in Inherit Alpha mode

The layer style projections (KisMultipleProjection) should be painted
into the final stack using the blending mode selected by the user.

M  +2-0libs/image/kis_cached_paint_device.h
M  +32   -25   libs/image/kis_fill_painter.cc
M  +3-7libs/image/kis_fill_painter.h
M  +1-1   
libs/image/layerstyles/kis_layer_style_filter_projection_plane.cpp
M  +13   -14   libs/image/layerstyles/kis_ls_bevel_emboss_filter.cpp
M  +17   -27   libs/image/layerstyles/kis_ls_overlay_filter.cpp
M  +2-0libs/image/layerstyles/kis_ls_overlay_filter.h
M  +6-8libs/image/layerstyles/kis_ls_stroke_filter.cpp
M  +4-17   libs/image/layerstyles/kis_ls_utils.cpp
M  +16   -2libs/image/layerstyles/kis_multiple_projection.cpp
M  +3-2libs/image/layerstyles/kis_multiple_projection.h
A  +---   
libs/image/tests/data/fill_painter/patterns_fill__custom_origin.png
A  +---   
libs/image/tests/data/fill_painter/patterns_fill__null_origin.png
M  +55   -0libs/image/tests/kis_fill_painter_test.cpp
M  +2-0libs/image/tests/kis_fill_painter_test.h
M  +1-1libs/image/tests/kis_layer_styles_test.cpp

https://commits.kde.org/krita/d183945d306b12b6dbb3ea2dd94fb12b88532e24

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=354376

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||ngmstu...@yahoo.co.uk

--- Comment #3 from Boudewijn Rempt  ---
*** Bug 393757 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=354376

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 Status|CONFIRMED   |ASSIGNED
   Keywords||regression

--- Comment #2 from Boudewijn Rempt  ---
Add regression keyword and assign.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 354376] Layer styles are not visible on layers with inherit alpha enabled

[Boudewijn Rempt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354376

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Boudewijn Rempt  ---
commit d3383be07fe3745a1462ff29c8c61bbf87e68eed
Author: Dmitry Kazakov 
Date:   Tue Sep 29 13:55:02 2015 +0300

Implemented projections for layer styles

Now every layer style has it's own projection (or multiple projections),
each with its own blending mode. The projections are free'd when the
layer style filter is disabled.

Fixes T217

Conflicts:
krita/image/layerstyles/kis_ls_drop_shadow_filter.cpp
krita/image/layerstyles/kis_ls_utils.h

-- 
You are receiving this mail because:
You are watching all bug changes.