[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-17 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=437029

--- Comment #4 from Eoin O'Neill  ---
Git commit 329f429e864f1572d72d684e44800118c6ae9255 by Eoin O'Neill.
Committed on 17/05/2021 at 21:46.
Pushed by eoinoneill into branch 'master'.

KisAnimTimelineView: Fixed edge-case where scrollTo still wasn't working as
intended for unpinned layers.

M  +2-0plugins/dockers/animation/KisAnimTimelineFramesModel.cpp

https://invent.kde.org/graphics/krita/commit/329f429e864f1572d72d684e44800118c6ae9255

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-13 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=437029

Emmet O'Neill  changed:

   What|Removed |Added

 CC||emmetoneill@gmail.com
  Latest Commit|https://invent.kde.org/grap |
   |hics/krita/commit/95e096dd3 |
   |46ad05ac3a43c64035ea0f0fb3a |
   |c246|

--- Comment #3 from Emmet O'Neill  ---
I've added a workaround that will hopefully fix this bug.

Basically there is a short period of time when adding an unpinned layer where
the internal numbering of the layers is incorrect. There doesn't seem to be a
great way to solve this that I can think of yet, so what we've done is add a
1/60 sec delay in the scrolling to give Qt time to get the numbering right.
It's a pretty tiny delay (about 1 frame of a 60 fps video game) so it shouldn't
feel noticeably worse.

Admittedly, this is a bit of a hacky fix, so there may be situations where this
bug still occurs. Though, it seems to work pretty solidly for me right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-13 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=437029

Emmet O'Neill  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/95e096dd3
   ||46ad05ac3a43c64035ea0f0fb3a
   ||c246
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Emmet O'Neill  ---
Git commit 95e096dd346ad05ac3a43c64035ea0f0fb3ac246 by Emmet O'Neill.
Committed on 14/05/2021 at 02:27.
Pushed by emmetoneill into branch 'master'.

KisAnimTimeline: Fixed inconsistent scrollTo behavior.

When switching active layer there is a brief window of time where
two unpinned layers simultaneously exist on the timeline, causing
indexing issues that result in improper scrollTo behavior for the
last layer.

This commit adds a workaround by delaying the scrollTo for 1/60
of a second to give the timeline model enough time to have correct
indexing.

M  +8-1plugins/dockers/animation/KisAnimTimelineFramesView.cpp

https://invent.kde.org/graphics/krita/commit/95e096dd346ad05ac3a43c64035ea0f0fb3ac246

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-13 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=437029

Eoin O'Neill  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-13 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=437029

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Eoin O'Neill  ---
Yeah, this should always scroll all the way up when selecting non-pinned
layers.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 437029] timeline scroll issues with "show in timeline"

2021-05-13 Thread Bollebib
https://bugs.kde.org/show_bug.cgi?id=437029

Bollebib  changed:

   What|Removed |Added

 OS|Other   |Microsoft Windows
   Platform|Other   |Microsoft Windows

-- 
You are receiving this mail because:
You are watching all bug changes.