[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=390732

Toni Asensi Esteve  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Toni Asensi Esteve  ---
Thanks, this bug was solved in Krusader (and Jakkubu and Nate Graham appear in
the credits :-) ):
https://phabricator.kde.org/R167:0e0f4ae6dd349a14d48e6ae1b80d03dfc8ec72ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[Toni Asensi Esteve]

https://bugs.kde.org/show_bug.cgi?id=390732

Toni Asensi Esteve  changed:

   What|Removed |Added

 CC||toni.ase...@kdemail.net

--- Comment #6 from Toni Asensi Esteve  ---
> You wouldn't loose your bet, but I don't want to dig in Phabricator patch
> making, creating another account etc. If it would be on github - no problem. I
> really don't have time to get more involved in kde development.

Now you do not have to worry about that :-) , jakkubu: 
https://phabricator.kde.org/D10746

Thank you, if you attach a patch (or attach the new files) in a bug report,
other people can perform the rest of the operations for you :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[jakkubu]

https://bugs.kde.org/show_bug.cgi?id=390732

--- Comment #5 from jakkubu  ---
You wouldn't loose your bet, but I don't want to dig in Phabricator patch
making, creating another account etc. If it would be on github - no problem. I
really don't have time to get more involved in kde development.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390732

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DOWNSTREAM  |---
 Ever confirmed|0   |1

--- Comment #4 from Nate Graham  ---
Thanks for that. Adding that line to the desktop file is a pretty simple
change. Would you like to tackle it? I bet you can do it!

Documentation is here: https://community.kde.org/Get_Involved/development

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[jakkubu]

https://bugs.kde.org/show_bug.cgi?id=390732

--- Comment #3 from jakkubu  ---
forget about gnome issue link:
https://bugzilla.gnome.org/show_bug.cgi?id=738672

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[jakkubu]

https://bugs.kde.org/show_bug.cgi?id=390732

--- Comment #2 from jakkubu  ---
Reported to GNOME. Their answer

> It's not that the desktop file cannot be called 'org.kde.krusader.desktop', 
> it's that we need a way to associate a window with the file.

> Considering that it is strongly recommended that .desktop files follow the
>reverse-DNS patter (that is, 'org.kde.krusader.desktop' is *better* than
>'krusader.desktop'), these are better alternatives:

> - set the window's WM_CLASS to 'org.kde.krusader'
> - add 'StartupWMClass=krusader' to the .desktop file

> Or if the KDE developers give us some other way to match windows to .desktop 
>files, we can consider adding it. But as it is, the ball is in their court ...

I can confirm that setting StartupWMClass=krusader in org.kde.krusader.desktop
solves this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390732] Cannot add Krusader to favorites in Gnome Dock

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390732

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||n...@kde.org
 Resolution|--- |DOWNSTREAM

--- Comment #1 from Nate Graham  ---
That is not an appropriate change. The desktop file *should* match the
AppStream ID. The AppStream ID is org.kde.krusader.desktop
(https://cgit.kde.org/krusader.git/tree/krusader/org.kde.krusader.appdata.xml#n3),
so the Desktop file needs the same filename. If GNOME or the Dock extension
you're using can't handle the binary bding named something different from the
AppStream ID, that's a problem there (though I doubt it, since GNOME programs
tend to be good citizens and all use the same naming conventions that we do,
e.g. Nautilus is org.gnome.nautilus).

Please report this to GNOME.

-- 
You are receiving this mail because:
You are watching all bug changes.