[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
   |lar/f3f077e1a632c6eed77564f |lar/84c9910da9533b9b08fc5a4
   |f92117a11f7855f2a   |0f693d6763152b331

--- Comment #11 from Antonio Rojas  ---
Git commit 84c9910da9533b9b08fc5a40f693d6763152b331 by Antonio Rojas.
Committed on 08/01/2017 at 18:48.
Pushed by arojas into branch 'master'.

Avoid duplicates in the available backends list

If a generator can open multiple mime types that match the same file, avoid
showing a backend chooser dialog with multiple instances of the same
backend

REVIEW: 129791

M  +2-2core/document.cpp

https://commits.kde.org/okular/84c9910da9533b9b08fc5a40f693d6763152b331

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/oku
   ||lar/f3f077e1a632c6eed77564f
   ||f92117a11f7855f2a

--- Comment #10 from Antonio Rojas  ---
Git commit f3f077e1a632c6eed77564ff92117a11f7855f2a by Antonio Rojas.
Committed on 08/01/2017 at 18:38.
Pushed by arojas into branch 'Applications/16.12'.

Avoid duplicates in the available backends list

If a generator can open multiple mime types that match the same file, avoid
showing a backend chooser dialog with multiple instances of the same
backend

REVIEW: 129791

M  +2-2core/document.cpp

https://commits.kde.org/okular/f3f077e1a632c6eed77564ff92117a11f7855f2a

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #9 from Oliver Sander  ---
I confirm that the patch avoids the duplicate 'poppler' entry for me.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

 CC||aro...@archlinux.org

--- Comment #8 from Antonio Rojas  ---
https://git.reviewboard.kde.org/r/129791/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Patrick]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #7 from Patrick  ---
As far as I can see the problem isn't a duplicate generator but a problem with
mimetypes. Freedesktop defines "application/x-pdf" as an alias of
"application/pdf". The poppler backend supports both mimetypes, but in the
mimetype lookup (QMimeType mimeType = mimeDatabase.mimeTypeForName(supported)
in DocumentPrivate::generatorForMimeType) the result is the same mimetype
"application/pdf".

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #6 from Oliver Sander  ---
Sure, here it is:

[/home/sander/okular-{test|save}] are two additional source trees that I happen
to have in my home directory.]

~> locate okularGenerator_poppler
/home/sander/okular/build/generators/poppler/okularGenerator_poppler.so
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.cpp
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/CXX.includecache
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/DependInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/annots.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/cmake_clean.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.internal
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/flags.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/formfields.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/link.txt
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/okularGenerator_poppler_automoc.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/pdfsettings.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/progress.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/AutogenInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/AutomocOldMocDefinitions.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/DependInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/build.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/cmake_clean.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/depend.internal
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/depend.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/progress.make
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.dir/moc_generator_pdf_24QWUT7JV56U7I.cpp
/home/sander/okular/generators/poppler/libokularGenerator_poppler.json
/home/sander/okular-inst/lib/x86_64-linux-gnu/plugins/okular/generators/okularGenerator_poppler.so
/home/sander/okular-save/build/generators/poppler/okularGenerator_poppler.so
/home/sander/okular-save/build/generators/poppler/okularGenerator_poppler_automoc.cpp
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/CXX.includecache
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/DependInfo.cmake
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/annots.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/cmake_clean.cmake
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.internal
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/flags.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/formfields.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/link.txt
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/okularGenerator_poppler_automoc.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/pdfsettings.cpp.o

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Yuri Chornoivan]

https://bugs.kde.org/show_bug.cgi?id=374650

Yuri Chornoivan  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #5 from Yuri Chornoivan  ---
(In reply to Oliver Sander from comment #3)
> I don't know.  How can I make sure?  

Can you run

locate okularGenerator_poppler

locate libpoppler

from console? Thanks in advance.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #4 from Oliver Sander  ---
I purged the okular Debian package from my system, along with an old poppler
package I still had, leaving only 0.48.  Then I rebuilt okular from scratch
from the git master.  The problem persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #3 from Oliver Sander  ---
I don't know.  How can I make sure?  

In any case, my okular installation 0.26.1 from the Debian package does not
have the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=374650

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
Are you totally totally sure that you don't have two okular installations
messing with eachother?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
Confirmed with current git master on Debian Testing.

-- 
You are receiving this mail because:
You are watching all bug changes.