[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 David Hurka changed: What|Removed |Added CC||frank.st...@gmx.net --- Comment #16 from David Hurka --- *** Bug 425376 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Nate Graham changed: What|Removed |Added Version Fixed In|1.11.2 |1.11.3 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Nate Graham changed: What|Removed |Added CC||n...@kde.org Version Fixed In||1.11.2 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 David Hurka changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/okular/commit/17c26699 ||3deda05713171f824669cb4e09a ||6ee65 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #15 from David Hurka --- Git commit 17c266993deda05713171f824669cb4e09a6ee65 by David Hurka. Committed on 12/10/2020 at 11:16. Pushed by ngraham into branch 'release/20.08'. Fix scrolling with scrollbar when the slider is not clicked This fixes scrolling with the scrollbar, so it is not reset when scrolling on the viewport afterwards. PageView’s QSroller was not correctly updated by update_scroller, because it was connected to QAbstractSlider::sliderMoved and sliderReleased, which are only emitted while the “slider is down”, i. e. not when the user scrolls the scrollbar other than dragging the slider. Now update_scroller is connected to actionTriggered(), which is emitted for all user interactions. Note that scrolling using the scrollbar calls QAbstractScrollArea::scrollContentsBy(), and so bypasses smooth scrolling of the QScroller. This could be considered a feature, otherwise it is more a bug in Qt than in Okular, because we can not ignore scrollContentsBy(). Steps to reproduce: 1. Open a long document 2. Click on the vertical scrollbar below the slider 3. Okular scrolls one page down 4. Scroll in the viewport 5. Okular starts scrolling from the position from step 1. Test plan: * Scroll using scrollbar + Click on the vertical scrollbar below the slider + Middle-click on the vertical scrollbar below the slider + Click on the little arrow of the vertical scrollbar + Scroll using a scrolling device (e. g. `xdotool click 4`) on the vertical scrollbar + Drag the slider of the scrollbar * “cross-product” verify QScroller state + Scroll using a scrolling device on the viewport + Scroll using Browse tool dragging + Scroll the viewport by clicking a point in the thumbnails view + Scroll the viewport using arrow keys and Page Up/Down keys M +7-4ui/pageview.cpp https://invent.kde.org/graphics/okular/commit/17c266993deda05713171f824669cb4e09a6ee65 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #14 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/292 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Antonio Rojas changed: What|Removed |Added CC||aro...@archlinux.org -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Junfeng Qiao changed: What|Removed |Added CC||qiao0junf...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #13 from popov895 --- This behavior also occurs when scrolling a document while the mouse cursor is over the scrollbar (both horizontal and vertical). Tested on pdf files, text files and images. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 popov895 changed: What|Removed |Added CC||popov...@ukr.net -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #12 from Oliver Sander --- Thank you! There is a now a test at https://invent.kde.org/graphics/okular/merge_requests/188 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159
--- Comment #11 from Albert Astals Cid ---
This makes the pageview scroll
void PartTest::testWheelInPageView()
{
QVariantList dummyArgs;
Okular::Part part(nullptr, nullptr, dummyArgs);
QVERIFY(openDocument(&part, QStringLiteral(KDESRCDIR "data/file2.pdf")));
part.widget()->resize(600, 400);
part.widget()->show();
QVERIFY(QTest::qWaitForWindowExposed(part.widget()));
QTest::qWait(3000);
auto we = new QWheelEvent({}, {}, {}, {0, -150}, Qt::NoButton,
Qt::NoModifier, Qt::NoScrollPhase, false);
QCoreApplication::postEvent(part.m_pageView->viewport(), we);
QTest::qWait(3000);
}
The QWheelEvent definition is a bit "bogus" in which it doesn't define pos nor
globalPos, just abuses the knowledge that PageView::wheelEvent just uses the
angleDelta().y()
--
You are receiving this mail because:
You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #10 from Oliver Sander --- Thanks, I hadn't heard of of xdotool. But I need something that works from within the QTest framework. And yes, gitlab does run the autotests. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #9 from David Hurka --- (In reply to Oliver Sander from comment #8) > but I failed to find a way to send wheel events to the PageView object. xdotool should work. But that would depend on the test environment. If only the GitLab CI can run this test, would that be enough? (Does GitLab run the autotests?) -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #8 from Oliver Sander --- I tried to write a unit test for this, but I failed to find a way to send wheel events to the PageView object. This seems to be a known problem: https://stackoverflow.com/questions/50996997/how-to-simulate-mouse-wheel-events-using-qtestlib-qt5 I see TabletEvents being sent in parttest.cpp by calls to qApp->notify( qApp, &enterProximityEvent ); but that doesn't seem to work for wheel events. Is there a secret trick to it, or do we have to live without a test? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Albert Astals Cid changed: What|Removed |Added CC||keziolio...@gmail.com, ||oliver.san...@tu-dresden.de --- Comment #7 from Albert Astals Cid --- Another regression caused by the QScroller patches. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Albert Astals Cid changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #6 from Albert Astals Cid --- Ok, now i understood: * Start in page 1 * Left click on the scrollbar below the slider it self until some pages change and say you're now in page 10 * use the wheel in the viewport (not the scrollbar), you're back to page 1 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Christoph Feck changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |REPORTED --- Comment #5 from Christoph Feck --- New information was added with comment 4; changing status for inspection. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #4 from msession...@gmail.com --- Seconds 0-5, scrolling with scroll wheel works normally. Seconds 5-12, clicking the scroll bar to scroll works as expected until trying to scroll with the scroll wheel. Meaning that scrolling with the scroll wheel after having clicked the scroll bar causes the reader (Okular) to jump back to the position in the document before I clicked on the scroll bar. After that in the video is a repeat of Seconds 0-12, but I clicked the scroll bar to scroll down. and then up a bit, and ends by scrolling the scroll wheel which still causes the document position to jump to where it was before. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #3 from Albert Astals Cid --- I still can figure out what is wrong with the video, could you describe second by second what you are doing and what you're expecting it would happen? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 --- Comment #2 from msession...@gmail.com --- Here's a GIF recording of the bug https://imgur.com/xou5cdA SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.70.0 Qt Version: 5.14.2 Kernel Version: 5.4.41-1-lts OS Type: 64-bit Processors: 8 × Intel® Core™ i7-3770 CPU @ 3.40GHz Memory: 31.3 GiB of RAM okular 1.10.1 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 421159] Scrolling by clicking the scroll bar is reset by scrolling with scroll wheel
https://bugs.kde.org/show_bug.cgi?id=421159 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO CC||aa...@kde.org --- Comment #1 from Albert Astals Cid --- I don't understand the problem, do you think you could record the screen a video/gif and maybe that would help me understand what you mean? -- You are receiving this mail because: You are watching all bug changes.
