[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Filip Fila]

https://bugs.kde.org/show_bug.cgi?id=364953

Filip Fila  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/3245c6bc9b7719c
   ||5fdad17ac70c49c12a102d75a
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Filip Fila  ---
Git commit 3245c6bc9b7719c5fdad17ac70c49c12a102d75a by Filip Fila.
Committed on 15/12/2019 at 21:12.
Pushed by filipf into branch 'master'.

[Plasma Style KCM] Add a color-wheel sign denoting the theme supports the
system color scheme

Summary:
The discoverability of the system color scheme awareness feature of some Plasma
themes right now is very poor.

In addition to that the previews for Breeze and Breeze Light look identical
when using the default color scheme.

To fix this we add a little color wheel icon in the top right corner of the
theme preview that only shows up if the theme supports this.

Credits go to @broulik for most of the code, I just positioned the icon.

Test Plan:
Depends on: D25999

{F7818015}

Doesn't get messed up with scaling either.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25785

M  +4-0kcms/desktoptheme/kcm.cpp
M  +1-0kcms/desktoptheme/kcm.h
M  +11   -5kcms/desktoptheme/package/contents/ui/ThemePreview.qml
M  +1-0kcms/desktoptheme/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/3245c6bc9b7719c5fdad17ac70c49c12a102d75a

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=364953

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||n...@kde.org
 Ever confirmed|0   |1
   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Postix]

https://bugs.kde.org/show_bug.cgi?id=364953

Postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Jens Reuterberg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364953

--- Comment #4 from Jens Reuterberg  ---
Created attachment 99798
  --> https://bugs.kde.org/attachment.cgi?id=99798=edit
example for new Breeze multicolour image

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Jens Reuterberg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364953

Jens Reuterberg  changed:

   What|Removed |Added

 CC||ohy...@gmail.com

--- Comment #3 from Jens Reuterberg  ---
"Breeze Light", "Breeze Dark" and "Breeze" should be the naming. As for image
to represent each differently I think it wont be that difficult - we could add
the 5.4 wallpaper or something in the background instead of just light grey
colour to represent "any colour you like"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364953

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
  Flags||Usability?

--- Comment #2 from Kai Uwe Broulik  ---
Breeze follows your system color scheme, Breeze Light does not and is always
tinted blue. Not sure how we could communicate that in the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364953

Christoph Feck  changed:

   What|Removed |Added

  Component|kcm_desktopthemedetails |general
Product|systemsettings  |Breeze
   Assignee|jamboar...@gmail.com|plasma-de...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.