[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-06-11 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=431921

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=436473

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-06-11 Thread Neros
https://bugs.kde.org/show_bug.cgi?id=431921

Neros  changed:

   What|Removed |Added

   See Also|https://bugs.kde.org/show_b |
   |ug.cgi?id=436473|

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-05-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431921

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=436473

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-05-06 Thread Colin J Thomson
https://bugs.kde.org/show_bug.cgi?id=431921

Colin J Thomson  changed:

   What|Removed |Added

 CC|colin.thom...@g6avk.co.uk   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431921

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Version Fixed In||5.18.8

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=431921

Fabian Vogt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/breeze/commit/cc613558ba |ma/breeze/commit/6c3a46e0f1
   |e7c809e36951da89db3c7cc1a5a |abb697fb0900f21196cafcbd8ee
   |58e |37c

--- Comment #14 from Fabian Vogt  ---
Git commit 6c3a46e0f1abb697fb0900f21196cafcbd8ee37c by Fabian Vogt.
Committed on 09/04/2021 at 11:16.
Pushed by fvogt into branch 'Plasma/5.21'.

Fix SplitterProxy not clearing when above another QSplitterHandle

When two SplitterHandles are next to each other, like at the intersection of a
horizontal and vertical splitter (|-), then it's possible that hiding the proxy
of one of those handles causes the other handle to gain focus immediately,
which activates the SplitterProxy again. Before this patch, it would then
continue clearing after reenabling itself, leading to an inconsistent state.
(cherry picked from commit d201a1f187243da677f8fa6e94325c41c3b9007c)

M  +6-6kstyle/breezesplitterproxy.cpp

https://invent.kde.org/plasma/breeze/commit/6c3a46e0f1abb697fb0900f21196cafcbd8ee37c

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=431921

Fabian Vogt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/breeze/commit/d201a1f187 |ma/breeze/commit/cc613558ba
   |243da677f8fa6e94325c41c3b90 |e7c809e36951da89db3c7cc1a5a
   |07c |58e

--- Comment #13 from Fabian Vogt  ---
Git commit cc613558bae7c809e36951da89db3c7cc1a5a58e by Fabian Vogt.
Committed on 09/04/2021 at 11:16.
Pushed by fvogt into branch 'Plasma/5.18'.

Fix SplitterProxy not clearing when above another QSplitterHandle

When two SplitterHandles are next to each other, like at the intersection of a
horizontal and vertical splitter (|-), then it's possible that hiding the proxy
of one of those handles causes the other handle to gain focus immediately,
which activates the SplitterProxy again. Before this patch, it would then
continue clearing after reenabling itself, leading to an inconsistent state.
(cherry picked from commit d201a1f187243da677f8fa6e94325c41c3b9007c)

M  +6-6kstyle/breezesplitterproxy.cpp

https://invent.kde.org/plasma/breeze/commit/cc613558bae7c809e36951da89db3c7cc1a5a58e

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=431921

Fabian Vogt  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/breeze/commit/d201a1f187
   ||243da677f8fa6e94325c41c3b90
   ||07c
 Resolution|--- |FIXED

--- Comment #12 from Fabian Vogt  ---
Git commit d201a1f187243da677f8fa6e94325c41c3b9007c by Fabian Vogt.
Committed on 09/04/2021 at 09:33.
Pushed by fvogt into branch 'master'.

Fix SplitterProxy not clearing when above another QSplitterHandle

When two SplitterHandles are next to each other, like at the intersection of a
horizontal and vertical splitter (|-), then it's possible that hiding the proxy
of one of those handles causes the other handle to gain focus immediately,
which activates the SplitterProxy again. Before this patch, it would then
continue clearing after reenabling itself, leading to an inconsistent state.

M  +6-6kstyle/breezesplitterproxy.cpp

https://invent.kde.org/plasma/breeze/commit/d201a1f187243da677f8fa6e94325c41c3b9007c

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=431921

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/breeze/-/merge_requests/95

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-09 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=431921

--- Comment #10 from Fabian Vogt  ---
I found a way to reproduce it:
1. Start dragging on the vertical (|) splitter below the intersection (|-)
2. Drag upwards until the cursor is on the intersection, then drag a bit to the
right
3. Release the mouse button to spawn a square

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-07 Thread Colin J Thomson
https://bugs.kde.org/show_bug.cgi?id=431921

Colin J Thomson  changed:

   What|Removed |Added

 CC||colin.thom...@g6avk.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 431921] Black square appears sometimes in KMail

2021-04-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=431921

Fabian Vogt  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
   Assignee|kdepim-b...@kde.org |plasma-b...@kde.org
 Ever confirmed|0   |1
Product|kmail2  |Breeze
Version|5.15.3  |unspecified
  Component|general |QStyle
 Status|NEEDSINFO   |CONFIRMED
 CC||fab...@ritter-vogt.de,
   ||noaha...@gmail.com

--- Comment #9 from Fabian Vogt  ---
Inspecting with GammaRay shows that this is the Breeze SplitterProxy. It has
visible=true, which means that it for some reason didn't hide properly.

Using gdb, it shows that _splitter is null, so the underlying handle was
deleted before the SplitterProxy was cleared. clearSplitter() has "if(
!_splitter ) return;", so once it's in that state it never hides itself again.

I'm wondering which handle it is which got deleted, but this should be
relatively simple to fix in any case by also clearing if _splitter is null. It
might need a new variable to track whether the proxy is currently active, but
isVisible() might suffice.

I can make a MR, but to be able to test it I'd have to know what SplitterProxy
is actually for, it's not obvious... The issue is also not easy to reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.