[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390349

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=390349

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dis
   ||cover/078dd8e1096b307f44639
   ||e5c95d1dae7f1ca5039
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Aleix Pol  ---
Git commit 078dd8e1096b307f44639e5c95d1dae7f1ca5039 by Aleix Pol.
Committed on 08/11/2018 at 17:18.
Pushed by apol into branch 'master'.

Move settings contextual menu into the drawer, under "Help"

M  +17   -0discover/qml/DiscoverDrawer.qml
M  +0-5discover/qml/SourcesPage.qml

https://commits.kde.org/discover/078dd8e1096b307f44639e5c95d1dae7f1ca5039

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Thomas Pfeiffer]

https://bugs.kde.org/show_bug.cgi?id=390349

Thomas Pfeiffer  changed:

   What|Removed |Added

 CC||thomas.pfeif...@kde.org

--- Comment #4 from Thomas Pfeiffer  ---
Putting it in the global drawer makes perfect sense. As Nate said, it's not
specific to any page, which is exactly what the global drawer is for.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #3 from Aleix Pol  ---
After all the work we've done to save the work the banner used, I'm not wasting
50px of vertical space only to add a menu bar with just the one menu with 2
items.

They may be global, but they don't need to be accessible at all times.
Remember we are talking about "About Discover" and "Report a bug".

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #2 from Nate Graham  ---
Honestly I'd add a real menu bar with a full "Help" menu. The issue is that
this isn't really page-specific at all; it's global. No matter where we put it,
if it's not globally-available, it's not really the right location.

As a next-best option, we could put it on the globalDrawer, which is our only
other mostly-globally-visible UI element.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #1 from Aleix Pol  ---
Where would you put this, in master?

Would it make sense to move this menu as a context action in the featured page?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=390349

Aleix Pol  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390349

Nate Graham  changed:

   What|Removed |Added

 Blocks||389717


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=389717
[Bug 389717] Settings page: rename to be "Sources" and put the page title in
the header
-- 
You are receiving this mail because:
You are watching all bug changes.