[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2019-01-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=401176

--- Comment #8 from Nate Graham  ---
Yikes, nice find! That seems like a subpar behavior that messes up clients like
Discover, which is otherwise capable of displaying an adequate page with no
screenshots.

Should we move this bug to attica or kns?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2019-01-23 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=401176

--- Comment #7 from Dan Jensen  ---
Hm, right, so the problem that's being seen here is that when an item on
opendesktop.org doesn't have any screenshots, a default one will be assigned to
the first item. As such, we get returned this link[1] as the first (and only)
screenshot. In other words: Discover is doing what it's supposed to. I feel
like it would probably not be entirely reasonable to handle this in the client,
but rather we need the store to return something more usable through the api...

[1] https://cn.opendesktop.org/cache/100x100-0/img/default.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2019-01-23 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=401176

--- Comment #6 from Dan Jensen  ---
The very large empty area is the screenshots section, which because there are
no screenshots is not showing anything useful... i'll try and see what's going
on there, and why we're still seeing that, even if all the screenshot options
are empty. But yes, basically confirmed that it is there. (the issue has
nothing at all to do with the video, rather that there's just no usable
screenshots for this ocs entry, which isn't being catered for somewhere...)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2019-01-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=401176

Nate Graham  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #5 from Nate Graham  ---
Well, it's half-fixed.

The link is indeed clickable now. However the link doesn't actually point to a
valid video. So there's a big clickable empty area in Discover that loads...
nothing. That part isn't fixed yet.

On the webpage (https://store.kde.org/p/1110512) there's also no image or
thumbnail there because the youtube video link isn't valid, but the emptiness
doesn't take up so much space. Could be that the KNS backend isn't properly
signaling that there's no content here so Discover reserves space for something
empty. Just guessing.

Dan, any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2019-01-22 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=401176

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #4 from Patrick Silva  ---
This bug persists in discover 5.15 beta.
Can we reopen it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2018-11-21 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=401176

--- Comment #3 from Dan Jensen  ---
(In reply to Nate Graham from comment #2)
> Fixed with https://phabricator.kde.org/D17050.
> 
> Not sure why the bug didn't get updated automatically.

This is a Very Annoying Problem, and apparently the sysadmins have no idea why
it happens - at least the couple of times it's been brought up they've kind of
shrugged (which, i'm fine, i know they're snowed under). My account,
specifically, is not being mapped between commits and bug reports, and
consequently the bugs.kde.org entries don't get updated. It works fine for the
Phabricator keywords, so i can only imagine something's wonky with the hook for
bko, but yeah, no idea apart from that :P

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2018-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=401176

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
  Latest Commit||https://cgit.kde.org/discov
   ||er.git/commit/?id=8bea95730
   ||eabb439b0528da01fb1e0cc6fe1
   ||79b7
 Resolution|--- |FIXED
   Version Fixed In||5.15.0
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Nate Graham  ---
Fixed with https://phabricator.kde.org/D17050.

Not sure why the bug didn't get updated automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2018-11-19 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=401176

Dan Jensen  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||ad...@leinir.dk

--- Comment #1 from Dan Jensen  ---
Absolutely agreed, it would be more than a bit handy to have the youtube link
(and indeed any clear-text links in the description) clickable, perhaps even
with a useful context menu to let people either open the link or copy it...
Whether or not the youtube link is, in fact, a functioning video is less
important, the fact that it is there at all as a URL ought to yield something
clickable, or at least copyable. Current state does seem less than amazingly
useful. Thank you for pointing it out :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 401176] No embedded videos in software description, just blank space and nonclickable links

2018-11-19 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=401176

Aleix Pol  changed:

   What|Removed |Added

URL||kns://kwineffect.knsrc/api.
   ||kde-look.org/1110512

-- 
You are receiving this mail because:
You are watching all bug changes.