[Falkon] [Bug 393544] Integrate with KRunner

[Alexander Lohnau]

https://bugs.kde.org/show_bug.cgi?id=393544

Alexander Lohnau  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED

--- Comment #16 from Alexander Lohnau  ---
It is done for the Bookmarks, but not for the Browser Tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=393544

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|ASSIGNED|NEEDSINFO

--- Comment #15 from Justin Zobel  ---
(In reply to Alexander Lohnau from comment #13)
> Git commit bbed524a2cec1508522ee5a903cab504b9c0d5a6 by Alexander Lohnau.
> Committed on 15/07/2020 at 16:49.
> Pushed by alex into branch 'master'.
> 
> Add bookmarksrunner integration for Falkon
> 
> M  +1-0runners/bookmarks/CMakeLists.txt
> M  +1-1runners/bookmarks/bookmarksrunner.cpp
> M  +4-1runners/bookmarks/browserfactory.cpp
> R  +37   -0runners/bookmarks/browsers/browser.h [from:
> runners/bookmarks/browser.h - 060% similarity]
> M  +4-30   runners/bookmarks/browsers/chrome.cpp
> A  +67   -0runners/bookmarks/browsers/falkon.cpp [License: LGPL
> (v2+)]
> A  +45   -0runners/bookmarks/browsers/falkon.h [License: LGPL (v2+)]
> M  +7-0runners/bookmarks/faviconfromblob.cpp
> M  +1-0runners/bookmarks/faviconfromblob.h
> 
> https://invent.kde.org/plasma/plasma-workspace/commit/
> bbed524a2cec1508522ee5a903cab504b9c0d5a6

Can this now be resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #14 from Nate Graham  ---
Nice work Alexander!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Alexander Lohnau]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #13 from Alexander Lohnau  ---
Git commit bbed524a2cec1508522ee5a903cab504b9c0d5a6 by Alexander Lohnau.
Committed on 15/07/2020 at 16:49.
Pushed by alex into branch 'master'.

Add bookmarksrunner integration for Falkon

M  +1-0runners/bookmarks/CMakeLists.txt
M  +1-1runners/bookmarks/bookmarksrunner.cpp
M  +4-1runners/bookmarks/browserfactory.cpp
R  +37   -0runners/bookmarks/browsers/browser.h [from:
runners/bookmarks/browser.h - 060% similarity]
M  +4-30   runners/bookmarks/browsers/chrome.cpp
A  +67   -0runners/bookmarks/browsers/falkon.cpp [License: LGPL (v2+)]
A  +45   -0runners/bookmarks/browsers/falkon.h [License: LGPL (v2+)]
M  +7-0runners/bookmarks/faviconfromblob.cpp
M  +1-0runners/bookmarks/faviconfromblob.h

https://invent.kde.org/plasma/plasma-workspace/commit/bbed524a2cec1508522ee5a903cab504b9c0d5a6

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=393544

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=393544

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #12 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/94

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Alex]

https://bugs.kde.org/show_bug.cgi?id=393544

Alex  changed:

   What|Removed |Added

 CC||kishor...@gmail.com

--- Comment #11 from Alex  ---
*** Bug 387427 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Alex]

https://bugs.kde.org/show_bug.cgi?id=393544

Alex  changed:

   What|Removed |Added

 CC||alexander.loh...@gmx.de

--- Comment #10 from Alex  ---
The bookmarks are independent of the browser integration.
If you plan on adding an integration for it
https://invent.kde.org/plasma/plasma-workspace/-/tree/master/runners/bookmarks
is the place.

Considering that it is just a JSON file the implementation should be relatively
easy.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[puneethchanda]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #9 from puneethchanda  ---
I have been trying to figure out how to make krunner search for bookmarks and
found out that the bookmarks in falkon are being saved in a JSON file in
'.config/falkon/profile/default' now what I should do is, make krunner search
for the content in this file. Is this correct?

Also, I came across
https://techbase.kde.org/Development/Tutorials/D-Bus/Introduction, can someone
please confirm if this is what I have to work on.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Juraj]

https://bugs.kde.org/show_bug.cgi?id=393544

Juraj  changed:

   What|Removed |Added

 CC||sgd.or...@gmail.com

--- Comment #8 from Juraj  ---
No news for almost 2 years, which I guess you are free to work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[puneethchanda]

https://bugs.kde.org/show_bug.cgi?id=393544

puneethchanda  changed:

   What|Removed |Added

 CC||puneethchanda2...@gmail.com

--- Comment #7 from puneethchanda  ---
@David is this done. If not, I would like to work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #6 from David Edmundson  ---
Sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Anthony Fieroni]

https://bugs.kde.org/show_bug.cgi?id=393544

Anthony Fieroni  changed:

   What|Removed |Added

 CC||bvb...@abv.bg

--- Comment #5 from Anthony Fieroni  ---
@David,you plan to do it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #4 from David Edmundson  ---
FWIW, I meant: D10078 KDBusRunner::AbstractRunner   which should be a 10 line
patch. I can do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=393544

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk,
   ||k...@privat.broulik.de

--- Comment #3 from Kai Uwe Broulik  ---
I think we should port the tab runner in p-b-i to use the new fancy
KF5::DBusRunner and unify the namespaces, so we have
org.kde.runners.browsertabs.1234 and have both p-b-i and Falkon use it, so we
only need one installed tabs runner that magically works with all of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[David Rosca]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #2 from David Rosca  ---
> See KAbstractRunner says d_ed

What about implementing org.kde.plasma.browser_integration.TabsRunner instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Falkon] [Bug 393544] Integrate with KRunner

[Jonathan Riddell]

https://bugs.kde.org/show_bug.cgi?id=393544

--- Comment #1 from Jonathan Riddell  ---
See KAbstractRunner says d_ed

-- 
You are receiving this mail because:
You are watching all bug changes.