[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Nicolas Fella changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Nicolas Fella changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Nicolas Fella --- Merge request: https://invent.kde.org/network/kaccounts-integration/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Nicolas Fella changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/netw ||ork/kaccounts-integration/c ||ommit/839bce4ba5399fd5924f7 ||316f8df402a86cb4262 --- Comment #3 from Nicolas Fella --- Git commit 839bce4ba5399fd5924f7316f8df402a86cb4262 by Nicolas Fella. Committed on 28/06/2020 at 19:00. Pushed by nicolasfella into branch 'sobump'. Bump libkaccounts so version 27487ab9276ca3a9b6ef4e8145b2279b5e38cd25 broke ABI, increase the so version to reflect that M +1-1CMakeLists.txt https://invent.kde.org/network/kaccounts-integration/commit/839bce4ba5399fd5924f7316f8df402a86cb4262 -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Pino Toscano changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Pino Toscano --- @Nicolas: ping? -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Pino Toscano changed: What|Removed |Added Summary|[ABI break] 20.04 and |[ABI break] |20.04.1 have renamed|KAccountsDPlugin changes |symbols and needs and ABI |its API without bumping the |bump|libkaccount SONAME CC||nicolas.fe...@gmx.de, ||p...@kde.org --- Comment #1 from Pino Toscano --- Note that the actual ABI change is not what Nicholas mention, but rather this: diff --git a/src/lib/kaccountsdplugin.h b/src/lib/kaccountsdplugin.h index 1f1f82f..178a3d3 100644 --- a/src/lib/kaccountsdplugin.h +++ b/src/lib/kaccountsdplugin.h @@ -54,7 +54,7 @@ class KACCOUNTS_EXPORT KAccountsDPlugin : public QObject Q_OBJECT public: -KAccountsDPlugin(QObject *parent = nullptr); +KAccountsDPlugin(QObject *parent, const QVariantList& args); virtual ~KAccountsDPlugin(); public Q_SLOTS: @@ -90,6 +90,4 @@ public Q_SLOTS: virtual void onServiceDisabled(const Accounts::AccountId accountId, const Accounts::Service ) = 0; }; -Q_DECLARE_INTERFACE(KAccountsDPlugin, "org.kde.kaccounts.DPlugin") - #endif // KACCOUNTSDPLUGIN_H Ie done as part of https://phabricator.kde.org/D27633, commit: https://invent.kde.org/network/kaccounts-integration/-/commit/27487ab9276ca3a9b6ef4e8145b2279b5e38cd25 -- You are receiving this mail because: You are watching all bug changes.
