[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

--- Comment #10 from Jarosław Staniek  ---
Git commit d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f by Jaroslaw Staniek.
Committed on 06/01/2019 at 21:16.
Pushed by staniek into branch '3.2'.

Fix handling ORDER BY part of queries

Summary:
- new APIs
- maintain relations between connections, queries and column infos
- fix cloning queries with ORDER BY
- update and add autotests

FIXED-IN:3.2
Related: bug 392753

Test Plan:
Required: KEXI & KDb 3.2 (current master)

Test 1: Open report and query from
https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views.
Expected: works, no crashes

Test 2: Try these on a standard Persons and Cars test:
select id from cars order by owner;
select id from cars order by owner, model, id;
select id, model from cars order by 2, 1;

Expected: works, no crash

Reviewers: piggz

Reviewed By: piggz

Subscribers: Kexi-Devel-list

Tags: #kdb

Differential Revision: https://phabricator.kde.org/D12873

M  +3-0autotests/CMakeLists.txt
A  +212  -0autotests/OrderByColumnTest.cpp [License: LGPL (v2+)]
A  +46   -0autotests/OrderByColumnTest.h [License: LGPL (v2+)]
M  +2-2src/KDbNativeStatementBuilder.cpp
M  +87   -28   src/KDbOrderByColumn.cpp
M  +40   -13   src/KDbOrderByColumn.h
M  +17   -28   src/KDbQueryColumnInfo.cpp
M  +25   -1src/KDbQueryColumnInfo.h
M  +18   -4src/KDbQuerySchema.cpp
M  +29   -1src/KDbQuerySchema_p.h

https://commits.kde.org/kdb/d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

Jarosław Staniek  changed:

   What|Removed |Added

 CC||albrecht.w...@online.de

--- Comment #9 from Jarosław Staniek  ---
*** Bug 402716 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

Jarosław Staniek  changed:

   What|Removed |Added

   Target Milestone|3.1.1   |3.2
   Version Fixed In||3.2
  Latest Commit||https://cgit.kde.org/kdb.gi
   ||t/commit/?id=3414fbddffa433
   ||b23d43376b44fef5421b734250
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
 CC||mrobertmdevelo...@gmail.com
 Status|RESOLVED|CLOSED

--- Comment #7 from Jarosław Staniek  ---
Feel free to test the git version.

--- Comment #8 from Jarosław Staniek  ---
*** Bug 395268 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

--- Comment #6 from Jarosław Staniek  ---
Git commit 3414fbddffa433b23d43376b44fef5421b734250 by Jaroslaw Staniek.
Committed on 16/05/2018 at 08:15.
Pushed by staniek into branch 'master'.

Fix handling ORDER BY part of queries

Summary:
- new APIs
- maintain relations between connections, queries and column infos
- fix cloning queries with ORDER BY
- update and add autotests

FIXED-IN:3.2
Related: bug 392753

Test Plan:
Required: KEXI & KDb 3.2 (current master)

Test 1: Open report and query from
https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views.
Expected: works, no crashes

Test 2: Try these on a standard Persons and Cars test:
select id from cars order by owner;
select id from cars order by owner, model, id;
select id, model from cars order by 2, 1;

Expected: works, no crash

Reviewers: piggz

Reviewed By: piggz

Subscribers: Kexi-Devel-list

Tags: #kdb

Differential Revision: https://phabricator.kde.org/D12873

M  +1-1CMakeLists.txt
M  +3-0autotests/CMakeLists.txt
A  +212  -0autotests/OrderByColumnTest.cpp [License: LGPL (v2+)]
A  +46   -0autotests/OrderByColumnTest.h [License: LGPL (v2+)]
M  +2-2src/KDbNativeStatementBuilder.cpp
M  +87   -28   src/KDbOrderByColumn.cpp
M  +40   -13   src/KDbOrderByColumn.h
M  +17   -28   src/KDbQueryColumnInfo.cpp
M  +25   -1src/KDbQueryColumnInfo.h
M  +18   -4src/KDbQuerySchema.cpp
M  +29   -1src/KDbQuerySchema_p.h

https://commits.kde.org/kdb/3414fbddffa433b23d43376b44fef5421b734250

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

Jarosław Staniek  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

Jarosław Staniek  changed:

   What|Removed |Added

   Assignee|kexi-b...@kde.org   |stan...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[KEXI] [Bug 393705] Exporting query with ORDER BY crashes KEXI

[Jarosław Staniek]

https://bugs.kde.org/show_bug.cgi?id=393705

Jarosław Staniek  changed:

   What|Removed |Added

Summary|export query crashes KEXI   |Exporting query with ORDER
   ||BY crashes KEXI

-- 
You are receiving this mail because:
You are watching all bug changes.