[Powerdevil] [Bug 484663] Switching from low battery mode to AC power should restore previous screen brightness

2024-04-17 Thread Gleb Popov
https://bugs.kde.org/show_bug.cgi?id=484663

Gleb Popov <6year...@gmail.com> changed:

   What|Removed |Added

 CC||6year...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 484663] Switching from low battery mode to AC power should restore previous screen brightness

2024-04-03 Thread Jakob Petsovits
https://bugs.kde.org/show_bug.cgi?id=484663

Jakob Petsovits  changed:

   What|Removed |Added

 CC||jpe...@petsovits.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #4 from Jakob Petsovits  ---
(In reply to devillelethibault from comment #2)
> (In reply to Natalie Clarius from comment #1)
> > Or would you like to not configure a default screen brightness for on AC but
> > have it switch back to wherever it was last time before you unplugged?
> 
> Yes, this is exactly the feature I would like !

Thank you. This has been bugging me forever and was perhaps my main motivation
for reworking the Power Management settings page in Plasma 6.0. It's still
unsolved at this point and I appreciate others speaking up on the same issue.

> The factor logic you described in the details sounds intresting but imo it is 
> too restrictive to enforce a capped maximum brightness whenever on low 
> battery; I might prefer to decide for myself that I'd like to keep running on 
> max brightness as long it still has some juice left and plug in when I have 
> to.

Agreed. Alternative suggestion: PowerDevil in brightnesscontrol.cpp already has
logic to prevent a profile transition to "lower power" from increasing
brightness. We could easily add the opposite and prevent it from reducing
brightness when AC is plugged in again.

> Another checkbox to restore previous brightness instead of a fixed one would 
> be a possibility but further complicated the already lengthy power settings.

How about we view it as an opportunity to reduce the settings that a user gets
to see by default? If there is *only* a checkbox to manually set brightness
across profiles, and the three sliders are hidden away on a separate sub-page
(you know the one:
https://invent.kde.org/plasma/powerdevil/-/issues/10#note_775764) then we don't
need an extra line and it can be cleaner both in terms of looks as well as less
confusing default behavior.

But what I also really like about this setup is that there is *always* a
configured brightness value. No more "switching to Battery has a brightness
change configured, but switching back to AC is a no-op". The current state can
always be reconstructed from configuration. That will be a major win.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 484663] Switching from low battery mode to AC power should restore previous screen brightness

2024-03-28 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=484663

Natalie Clarius  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #3 from Natalie Clarius  ---
The factor logic you described in the details sounds intresting but imo it is
too restrictive to enforce a capped maximum brightness whenever on low battery;
I might prefer to decide for myself that I'd like to keep running on max
brightness as long it still has some juice left and plug in when I have to.

Another checkbox to restore previous brightness instead of a fixed one would be
a possibility but further complicated the already lengthy power settings. I'll
keep it open as a wishlist item.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 484663] Switching from low battery mode to AC power should restore previous screen brightness

2024-03-28 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=484663

--- Comment #2 from devillelethiba...@gmail.com ---
(In reply to Natalie Clarius from comment #1)
> Or would you like to not configure a default screen brightness for on AC but
> have it switch back to wherever it was last time before you unplugged?

Yes, this is exactly the feature I would like !

I've given my two cents on some specifics for this feature in the additional
info section, but it was clear in my mind that this should of course be
activated with a user setting. Maybe if the user did not set a predefined
brightness level for the plan they're switching to, or using an explicit
checkbox ? Either way, this would add one more property to switch in and out of
"low battery" mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 484663] Switching from low battery mode to AC power should restore previous screen brightness

2024-03-28 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=484663

Natalie Clarius  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Natalie Clarius  ---
Powerdevil should already automatically switch to the configured screen
brightness for the AC profile if one is set.

Does it not do this? - Then this is a bug.

Or would you like to not configure a default screen brightness for on AC but
have it switch back to wherever it was last time before you unplugged?

We could think about this, but imo it is good to have a way of opting out of
brightness being automatically changed when plugging/unplugging, and this is
what having the "change screen brightness" slider being optional provides.

-- 
You are receiving this mail because:
You are watching all bug changes.