[Spectacle] [Bug 389614] Make "Save As..." the default save option in the Save split button

2018-01-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=389614

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/spe
   ||ctacle/9930b493e14da807974c
   ||7607f463ecc5e0eb9e31
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Git commit 9930b493e14da807974c7607f463ecc5e0eb9e31 by Nathaniel Graham.
Committed on 31/01/2018 at 14:00.
Pushed by ngraham into branch 'master'.

Make "Save As" the default save mode

Summary:

Yet more anecdotal evidence from bug triaging suggests that many would prefer
"Save As" to be the default save mode in Spectacle. This patch accomplishes
that.

I am planning a larger rewrite of the buttons sometime in the coming weeks that
should hopefully end squabbles over button settings, but until then, I believe
this will be a welcome improvement.

Test Plan:
Tested in KDE Neon
- Removed ~/.config/spectaclerc; "Save As" is now the default save mode
- Clicked "Save As" button: correct save operation is performed; button stays
in "Save As" mode
- Changed the button to other save modes; same thing
- Quit Spectacle and re-opened when the button was in each save mode; it opened
in the correct mode

{F5684691}

Reviewers: #spectacle, rkflx, rkron

Reviewed By: rkron

Differential Revision: https://phabricator.kde.org/D10198

M  +8-8src/Gui/KSMainWindow.cpp

https://commits.kde.org/spectacle/9930b493e14da807974c7607f463ecc5e0eb9e31

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389614] Make "Save As..." the default save option in the Save split button

2018-01-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=389614

--- Comment #2 from Nate Graham  ---
I've submitted a patch for this: https://phabricator.kde.org/D10198

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389614] Make "Save As..." the default save option in the Save split button

2018-01-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=389614

Christoph Feck  changed:

   What|Removed |Added

 CC||aotto1...@t-online.de

--- Comment #1 from Christoph Feck  ---
*** Bug 389074 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 389614] Make "Save As..." the default save option in the Save split button

2018-01-29 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=389614

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.