[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Database-Scan   |Database-Setup

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.5.0
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/dig
   ||ikam/e9bc2261c28fd55cf9f128
   ||5f51dbee93f4a3e3c3

--- Comment #60 from caulier.gil...@gmail.com ---
Git commit e9bc2261c28fd55cf9f1285f51dbee93f4a3e3c3 by Gilles Caulier.
Committed on 21/02/2017 at 18:53.
Pushed by cgilles into branch 'master'.

Apply patch #104043 from Jan Wolter to ignore some kind of directories at
collections
scan and to prevent to bloat database with unwanted/unecessary entries.
FIXED-IN: 5.5.0

M  +3-1NEWS
M  +69   -157  libs/database/collection/collectionscanner.cpp
M  +12   -8libs/database/collection/collectionscanner.h
M  +154  -83   libs/database/coredb/coredb.cpp
M  +12   -4libs/database/coredb/coredb.h
M  +14   -3libs/database/coredb/coredbschemaupdater.cpp
M  +5-3libs/database/coredb/coredbschemaupdater.h
M  +93   -11   libs/database/utils/dbsettingswidget.cpp
M  +6-2libs/database/utils/dbsettingswidget.h
M  +6-2utilities/setup/setupdatabase.cpp
M  +2-2utilities/setup/setupdatabase.h

https://commits.kde.org/digikam/e9bc2261c28fd55cf9f1285f51dbee93f4a3e3c3

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #59 from caulier.gil...@gmail.com ---
Excelent. Thanks a lot Jan.

I will have plenty of time while this week end to review this patch for next
5.5.0 release.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

Jan Wolter  changed:

   What|Removed |Added

 Attachment #103660|0   |1
is obsolete||

--- Comment #58 from Jan Wolter  ---
Created attachment 104043
  --> https://bugs.kde.org/attachment.cgi?id=104043=edit
Reworked patch

Hi Gilles,
attached is the reworked patch, which behaves exactly as the mime config now.
The settings are directly stored in SQLite DB. The @eaDir is now ignored by
default, but users are able to include it by prefixing it with a minus (the
same behaviour as in mime config).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #57 from caulier.gil...@gmail.com ---
digikam --help
Usage: digikam [options]
Manage your photographs like a professional, with the power of open source

Options:
  -v, --version   Displays version information.
  -h, --help  Displays this help.
  --authorShow author information.
  --license   Show license information.
  --desktopfileThe base file name of the desktop entry for this
  application.
  --download-from   Open camera dialog at 
  --download-from-udiOpen camera dialog for the device with Solid UDI
  
  --detect-camera Automatically detect and open a connected gphoto2
  camera
  --database-directory   Start digikam with the SQLite database file found
  in the directory 

^^^ The last argument permit to change the collection database (DB) on the
command line interface (CLI)

Typically, it's the same than to change the database config from digiKam/Setup
dialog...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #56 from Jan Wolter  ---
Yes, I agree that this is the most consistent way.

But what do you mean that "DB file to use with digiKam session can be passed on
CLI."?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #55 from caulier.gil...@gmail.com ---
I vote for 2/, for these reasons :

1/ to be homogeneous with other settings.
2/ each collection database file can be customized. The settings is not common
and is portable. Remember that DB file to use with digiKam session can be
passed on CLI.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #54 from Jan Wolter  ---
Hi Gilles,
ok, I will support default settings. I looked a bit deeper in the code defining
the default settings for mime types. They are all directly stored in the SQLite
DB in the settings table, supported by function setSettings in DbCore class.
Up to now, I store the ignored directories settings in DbEngineParameters.

What do you suppose:
1) Should I leave the ignored directories settings there and add just default
ignore directories?
2) Or should I move the settings to the database as its done for mime types.

Regarding the directories starting with a dot: They are ignored anyway and are
not touched by my patch. I think that should remain so in the future. Do you
agree?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #53 from caulier.gil...@gmail.com ---
Well the info dialog is perfect. Just add a default ignore settings user will
expected to have in core digiKam, as it's done with mime type settings. We need
to be homogeneous here.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #52 from Jan Wolter  ---
Hello Gilles,

I suppose, we have a misunderstanding here. My patch does not introduce new
directories that get ignored by default. Even the @eaDir directory gets ignored
only, when a user adds it to the new configuration dialog (the directories are
saved as part of DbEngineParameters). My approach was that digikam behaves with
my patch but without configuring directories in the new dialog in the same way
as in the current version without my patch.

Concerning your comment with the info dialog, I thought you want a list
including all directories from which we know that they will be ignored. And
that’s just all directories starting with a dot. Since, my patch does not
introduce additional ignored directories by default, such info dialog with
exemplary ignored directories could be skipped.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #51 from caulier.gil...@gmail.com ---
Jan,

I stil to not understand how this patch can work in background level to ignore
some kind of subdirectories at scan.

You said :

"For example, when you store your Synology NAS (Network Attached Storage), the
system creates in every directory a subdirectory @eaDir to store thumbnails."

and i can see this list populated in help widget :

QLatin1String(".DS_Store") << QLatin1String(".directory") <<
QLatin1String(".Trash-_userid")

... but there is no real code to handle this directory naming scheme.
Where is defined the DEFAULT ignore dir settings in core database
implementation with "@eaDir", ".DS_Store", ".directory", ".Trash-_userid" ? As
i said in comment #47, the core DB as already a set of type-mime values
pre-configured. End users will expect to have the same default rules for
directories to ignore at scan time.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #50 from caulier.gil...@gmail.com ---
MTP camera is relevant of Import tool, not database scanning process.

By scanning, we talk about the process which scan collections to register items
to database.

removal camera are driven by Import tool, which have already some dedicated
rules to ignore contents.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[C Doe]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #49 from C Doe  ---
I have to admit I have not followed the entire discussion here, but I wanted to
throw in my 2 cents...  The fix for this bug/feature request should allow users
to exclude MTP mounted smartphone directories, which are very, very, very slow
to process.  For example:
"/run/user/1910/gvfs/mtp:host=%5Busb%3A002%2C029%5D/SD card/"
which includes some strange syntax.
Also udisk mounts under /media, which can also be very, very slow to process. 
Also FUSE filesystem mounts, which can also have some strange syntax, like the
MTP example.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #48 from Jan Wolter  ---
Created attachment 103660
  --> https://bugs.kde.org/attachment.cgi?id=103660=edit
Newest version of patch

Hello Gilles,
I added an info pop-up as in the mime config including the explanation that all
directories starting with a dot will be ignored and a small list of explicit
directory names you mentioned (this list could be extended of course).
I would be glad if you check-in the patch in the repository :)

Best regards,
Jan

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

   Platform|unspecified |Compiled Sources

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #47 from caulier.gil...@gmail.com ---
yes exactly.

The new option in setup database must permit to define new combinaison of
ignored directory schemes. By default we must already set in database interface
some problematic schemes that we know already. 

For type mime default scheme, database set these values CoreDbSchemaUpdater
class.

https://cgit.kde.org/digikam.git/tree/libs/database/coredb/coredbschemaupdater.cpp#n460

On SetupMime class, we use this widgets to configure extra mime filters:

https://cgit.kde.org/digikam.git/tree/utilities/setup/album/setupmime.cpp#n108

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #46 from Jan Wolter  ---
Hello Gilles,

thanks for your help and your feedback. With your hint it generally works,
thats great!

Now to your point regarding a default ignore list: 
The examples you mentioned all begin with a dot and has been ignored by default
anyway. Do I understand you correctly, that you wish to establish a list (as in
View/Mime-Type) with ignored directories (e.g. all that begin with a dot) *just
to inform the user* about this default feature?
If that is your intension, I will add such a list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #45 from caulier.gil...@gmail.com ---
Jan,

I'm not fully satisfied by this patch.

1/ we must set a default ignore list of files/directories already know as
problematic while scanning collections

For example :

- under MacOS, .DS_Store hidden files are created everywhere by Desktop search
engines. This bloat disk of course but there is no way that i know to disable
this feature.

- Under Linux/Plasma, Dolphin files manager permit to customize icon view order
by directory. This generate .directory hidden files.

- Under Linux/Plasma, the trash tool create an hidden directory .Trash-_userid_
with a content of deleted files. This one must be ignored by digiKam.

And i forget certainly some hidden files/directories under other desktops as
Gnome or Windows.

I propose to set a list that we know already to ignore. This list must be
visible by end user from config panel, like it's already done in View/Mime-Type
section for each setting.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #101955|0   |1
is obsolete||
 Attachment #102158|0   |1
is obsolete||
 Attachment #102709|0   |1
is obsolete||
 Attachment #102753|0   |1
is obsolete||

--- Comment #44 from caulier.gil...@gmail.com ---
Created attachment 103602
  --> https://bugs.kde.org/attachment.cgi?id=103602=edit
new patch version ready for testing

Screenshot of Database config pannel with this patch:

https://www.flickr.com/photos/digikam/32441766536/in/dateposted-public/

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #43 from caulier.gil...@gmail.com ---
Jan to your question from #40.

In SetupDatabase, when you change ignored directories settings, If think you
just need to to call AlbumManager::instance()->changeDatabase(params) to update
global DB settings before to call ScanContoller.

I will update and polish the patch for testing.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #42 from caulier.gil...@gmail.com ---
I'm on holidays this week end for 2 weeks. I will have plenty of time to
respond. For the moment, until Saturday evening, i'm very busy in my office...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #41 from Jan Wolter  ---
Hello Gilles,
do you have any hint for me to update CoreDbAccess after updating
dbEngineParameters?
It would be great if you could help me to fix this last problem to get it work
before dk 5.4 deadline.

Best regards,
Jan

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #40 from Jan Wolter  ---
Created attachment 102753
  --> https://bugs.kde.org/attachment.cgi?id=102753=edit
Patch

Hi Gilles,
I have attached a version without the crash caused by the wrong call of
CoreDbAccess::setParameters.
The remaining problem is still that after updating the settings, the
CollectionScanner refers to CoreDbAccess().parameters() which do NOT contain
the newly inserted ignoredDirectories.

It would be nice to take a look on that and tell me how to update CoreDbAccess
after adding new settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #39 from Jan Wolter  ---
Created attachment 102709
  --> https://bugs.kde.org/attachment.cgi?id=102709=edit
New version of Patch

Hi Gilles,
see attached the patch. To update the paramters in CoreDbAccess according to
the dbEngineParameters, I call setupdatebase.cpp:
CoreDbAccess::setParameters(params);

See the complete snippet here:
if (d->databaseWidget->getDbEngineParameters().ignoredDirectories !=
d->databaseWidget->orgDatabasePrm().ignoredDirectories)
{
qCDebug(DIGIKAM_GENERAL_LOG) << "Ignored directories settings changes.
Update...";
DbEngineParameters params = d->databaseWidget->getDbEngineParameters();
settings->setDbEngineParameters(params);
settings->saveSettings();
CoreDbAccess::setParameters(params);
ScanController::instance()->completeCollectionScanInBackground(false);
}

But unfortunately, this crashed the hole application:
*** Error in `/opt/kf5/bin/digikam': double free or corruption (fasttop):
0x7fffc00dcbe0 ***
Program received signal SIGABRT, Aborted.

Do you know a way to update the parameters in CoreDbAccess correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #38 from caulier.gil...@gmail.com ---
Please share the new patch to review the code. It will be more easy.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #37 from Jan Wolter  ---
Hi Gilles,
when changes in the new ignoredDirectories settings text field are made I
trigger now a album rescan to ignore the directories. At this moment the
dbEngineParameters contain the newly inserted ignoredDirectories. But the
CollectionScanner refers to CoreDbAccess().parameters() which do NOT contain
the newly inserted ignoredDirectories.
Could you give me a hint how to update CoreDbAccess().parameters() after
performing changes at dbEngineParameters?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #36 from caulier.gil...@gmail.com ---
5.4.0 is planed before Christmas. Don't forget that i need at least one week
before release date to check implmentation, and to lets time to translators to
update i18n with new strings introduced with your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #35 from Jan Wolter  ---
Hi Gilles,
since my last update there is no further progress, but I hope to find time to
complete the last 20% till next release.
For what date in December is version 5.4 planned?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #34 from caulier.gil...@gmail.com ---
Jan,

Any progress to complete the patch before 5.4.0 release planed in December ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #33 from caulier.gil...@gmail.com ---
Arnaud,

Yes, it's planed to include it for next 5.4.0 if Jan complete it in time, which
will be the case as 80% of the patch is already done...

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Arnaud]

https://bugs.kde.org/show_bug.cgi?id=123097

Arnaud  changed:

   What|Removed |Added

 CC||arn...@croes.be

--- Comment #32 from Arnaud  ---
Are there plans to implement this patch in the official release? I am using
Philip's PPA repository to stay up-to-date with my digikam5 version. It would
be cool to have it included there, and avoid manual patching work. I am also
having an extremely slow Digikam experience because of @eadir folders on the
nfs mounted Synology. Some time ago I just deleted all those system generated
folders, but recently had them rebuild. I would much rather have an exclude
filter on the collection discovery. Thanks, Arnaud

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #31 from Jan Wolter  ---
Created attachment 102158
  --> https://bugs.kde.org/attachment.cgi?id=102158=edit
Update Patch IgnoreDirectories

Hello Gilles,

yes there are progress.
The attached patch supports the requested feature: You are able to add
directories (separated by whitespaces in the text field) that you want to
ignore from your collection. The settings are stored in DbEngineParameters. All
directories that exactly match the configured directory name, will be ignored
from the photo collection.

But unfortunately, the configured directories gets ignored only after
restarting digikam.
When a user clicks the OK-Button of settings dialog, the DbEngineParameters are
updated correctly. But in the CollectionScanner CoreDbAccess().parameters()
delivers instead of the actual parameters, the parameters that were valid at
digikam startup.
Do you have, any hints to solve this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #30 from caulier.gil...@gmail.com ---
Jan,

Any progress here to be able to include your patch in next 5.4.0 release ?

Thanks in advance 

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[François Tissandier]

https://bugs.kde.org/show_bug.cgi?id=123097

François Tissandier  changed:

   What|Removed |Added

 CC||francois.tissandier@gmail.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #29 from caulier.gil...@gmail.com ---
ok,

Also, i see in Setup dialog databse page that some TODO are not yet
implemented, especially for the GUI.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #28 from Jan Wolter  ---
Hello Gilles,
thanks for your help. I will show your code the next days and complete the fix
for this issue.

@Note 1: Ok, I will replace tabs by blanks.

@Note 2: You are right, "@eaDir" is still hard-coded, but with adjusted patch I
should be able to use the new settings from DbEngineParameters.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #101805|0   |1
is obsolete||

--- Comment #27 from caulier.gil...@gmail.com ---
Created attachment 101955
  --> https://bugs.kde.org/attachment.cgi?id=101955=edit
updated patch to link fine.

[  9%] Linking CXX shared library libdigikamcore.so
[  9%] Built target digikamcore
[  9%] Linking CXX shared library libdigikamdatabase.so
CMakeFiles/digikamdatabase_src.dir/collection/collectionscanner.cpp.o: In
function `Digikam::CollectionScanner::CollectionScanner()':
/home/gilles/Devel/5.x/core/libs/database/collection/collectionscanner.cpp:363:
undefined reference to `Digikam::ApplicationSettings::instance()'
/home/gilles/Devel/5.x/core/libs/database/collection/collectionscanner.cpp:363:
undefined reference to `Digikam::ApplicationSettings::getDbEngineParameters()
const'
collect2: error: ld returned 1 exit status

You try to use symbols defined in libdigiKam into libdigikamdatabase. Symbols
are separated due to use libdigikam with showfoto which is database free.

In fact you just want to print as debug statement the DB engine parameters from
ApplicationSettings in CollectionScanner. This is not permit at linking time to
prevent cycling symbols linking.

To get DbEngineParameters in CollectionScanner, just use
DbCoreAcess.parameters() as well.

Note : never use Tabs in source code. This break the coding style.

Note2 : In CollectionScanner, i suppose that all is not yet implemented. The
new settings from DbEngineParameters about directories to ignore while scanning
collections is just not used. All checks about "@eaDir" still hard-coded as
well. Right ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Attachment #89319|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Attachment #95010|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=123097

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #101781|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #26 from Jan Wolter  ---
Created attachment 101805
  --> https://bugs.kde.org/attachment.cgi?id=101805=edit
Patch on current repository status

The same problem on current status.
The problem seem to be somewhere under the hood. Would be nice, if someone with
deeper understanding of dk code could check that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #25 from Jan Wolter  ---
Created attachment 101781
  --> https://bugs.kde.org/attachment.cgi?id=101781=edit
IgnoreDirectories-Patch dk 5

Hello Gilles,

I found some time to port my fix to new dk version 5. The attached code depends
on tag v5.2.0.

It depends on the initial patch from Amilcar Lucas to ignore all @eaDir
directories (hard-coded in class collectionscanner.cpp). My part was to
configure what directories should be ignored. Therefore I added a text field to
the database settings menu. The entries a user make there will be stored in
digikamrc.

The last part to complete the task is to replace the hard-coded ignoration of
@eaDir by the entries made by users. Therefore, I need access to the database
parameters in collectionscanner class:
const DbEngineParameters prm =
ApplicationSettings::instance()->getDbEngineParameters();

Unfortunately, I get the same error as in dk 4 version:
CMakeFiles/digikamdatabase_src.dir/collection/collectionscanner.cpp.o: In
function `Digikam::CollectionScanner::CollectionScanner()':
/home/jan/Downloads/digikamGIT/core/libs/database/collection/collectionscanner.cpp:363:
undefined reference to `Digikam::ApplicationSettings::instance()'
/home/jan/Downloads/digikamGIT/core/libs/database/collection/collectionscanner.cpp:363:
undefined reference to `Digikam::ApplicationSettings::getDbEngineParameters()
const'
collect2: error: ld returned 1 exit status
make[2]: *** [core/libs/database/libdigikamdatabase.so.5.2.0] Error 1
make[1]: *** [core/libs/database/CMakeFiles/digikamdatabase.dir/all] Error 2
make: *** [all] Error 2

You guessed last year it is a linking problem. Could you please check that?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[Jan Wolter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #24 from Jan Wolter  ---
Hi Gilles, at the moment I didn't tested it. But I hope I will find some time
to test it with dg 5 during the next 2-3 weeks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=123097

--- Comment #23 from caulier.gil...@gmail.com ---
Jan,

Do you have a revised version of your patch working with current implmeentation
from git/master based on Qt5 ?

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 123097] SCAN : ignore some directories in digiKam [patch]

[C Doe via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=123097

C Doe  changed:

   What|Removed |Added

 CC||cfd...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.