[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374591

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Database|Database-Trash

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

Mario Frank  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dig
   ||ikam/a1f67531b3269941df5ff5
   ||31baa3e487cf58f1fc
 Resolution|--- |FIXED
   Version Fixed In||5.5.0
 Status|UNCONFIRMED |RESOLVED

--- Comment #17 from Mario Frank  ---
Git commit a1f67531b3269941df5ff531baa3e487cf58f1fc by Mario Frank.
Committed on 08/02/2017 at 14:09.
Pushed by mfrank into branch 'master'.

Merged the garbage collection into master. The garbage collector is a
maintenance stage that runs before the rebuild of thumbnails and must be
triggered explicitely.
It removes stale image entries in core db and if enabled also stale thumbnails
and face identities from thumbnails and recognition DB.
If configured so, the core DB part of the garbage collector removes stale image
entries in core db during the start of digiKam.
Note that cleaning the databases does not necessarily make them smaller as no
auto-vacuum is done on the databases. The vacuuming proces differs highly
between the three
supported database variants (SQLite, internal MySQL and external MySQL). Thus,
currently there is no automatism.
Related: bug 323718
FIXED-IN: 5.5.0

M  +3-1NEWS

https://commits.kde.org/digikam/a1f67531b3269941df5ff531baa3e487cf58f1fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #16 from Mario Frank  ---
Merge is done. I will close this file now

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #15 from Mario Frank  ---
(In reply to caulier.gilles from comment #14)
> Hi Mario,
> 
> Well, merge back will be done when you decide. If more time is necessary to
> hack, we can postbone release date for 5.5.0.
> 
> In other word, we don't have any restriction here (:=)))...
> 
> Gilles

Hey Gilles,
the stale data (in ImageTags) seems to be the result of some queries I made in
the DB with my DB browser.
I did not find more stale data in core DB that can be cleaned.
I just resolved the last thing I disliked. Before 5.5, items were marked as
Removed (now Trashed) and deleted after a retention period. So users may have
items with that status. But the garbage collection only removes Obsolete items. 
I adopted the CollectionsScanner to marke trashed items as obsolete after a
retention period. This way, users will also get rid of old trashed items.

Also, there are no more tables in thumbs and recognition db that are not
handled by the garbage collection.

To conclude: in functionality, we are finished for now. I am in fact working
with the garbage collection since we have the branch and did not encounter
problems. I would merge the branch into the master today. Then, more people can
test.

No need to postpone 5.5 - except users raid us with bug requests.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #14 from caulier.gil...@gmail.com ---
Hi Mario,

Well, merge back will be done when you decide. If more time is necessary to
hack, we can postbone release date for 5.5.0.

In other word, we don't have any restriction here (:=)))...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #13 from Mario Frank  ---
What about the garbage collection branch. When will we merge it to master?
I identified some potential stale data, i.e. table entries that reference a
non-existent image id, in core DB that can also be collected.
I will implement that when I have the time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #12 from Mario Frank  ---
(In reply to Kusi from comment #9)
> do you have by any chance a branch on a git repo to check out from? I use an
> external mysql server and could test it with that configuration
> 
> When you delete a tagged photo and restart digikam, the tags are gone
> forever, right? It wouldn't be possible to restore the photo including tags
> from the trash. What about a retention period (e.g 30 days), or if the
> deletion date is not saved, just clean up once every month instead of every
> launch of digikam(just as an idea)

Kusi,
I never would automatically delete items from trash. I think this is bad
usability. I only delete the items that were either removed directly (not moved
to trash) or removed from trash. So, as long as you do not delete the items
from trash, I will not do this either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #11 from caulier.gil...@gmail.com ---
AppImage is done.
Upploading to GDrive under progress. It will be online in few minutes at usual
place :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

New database Garbage Collector options are there :

https://www.flickr.com/photos/digikam/32549923912/in/dateposted-public/
https://www.flickr.com/photos/digikam/32549923632/in/dateposted-public/

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #10 from caulier.gil...@gmail.com ---
Kusi,

The branch is already created :

https://cgit.kde.org/digikam.git/log/?h=development/garbagecollection

Anyway, if you wait a little bit, i currently re-build the AppImage bundle with
this branch.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Kusi]

https://bugs.kde.org/show_bug.cgi?id=374591

Kusi  changed:

   What|Removed |Added

 CC||k...@forum.titlis.org

--- Comment #9 from Kusi  ---
do you have by any chance a branch on a git repo to check out from? I use an
external mysql server and could test it with that configuration

When you delete a tagged photo and restart digikam, the tags are gone forever,
right? It wouldn't be possible to restore the photo including tags from the
trash. What about a retention period (e.g 30 days), or if the deletion date is
not saved, just clean up once every month instead of every launch of
digikam(just as an idea)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374591

--- Comment #8 from Mario Frank  ---
Created attachment 103773
  --> https://bugs.kde.org/attachment.cgi?id=103773=edit
Patch including new files.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 374591] Deleting image only removes the file and sets the status to hidden but does not delete the image from DB [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374591

caulier.gil...@gmail.com changed:

   What|Removed |Added

Summary|Deleting image only removes |Deleting image only removes
   |the file and sets the   |the file and sets the
   |status to hidden but does   |status to hidden but does
   |not delete the image from   |not delete the image from
   |DB  |DB [patch]

-- 
You are receiving this mail because:
You are watching all bug changes.