[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=334533

Méven Car  changed:

   What|Removed |Added

   Version Fixed In||21.08
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/commit/5a0da4a9c
   ||8d10dc1921077d84bdabf05d201
   ||50b0
 Resolution|WORKSFORME  |FIXED

--- Comment #16 from Méven Car  ---
Git commit 5a0da4a9c8d10dc1921077d84bdabf05d20150b0 by Méven Car.
Committed on 19/04/2021 at 05:10.
Pushed by meven into branch 'master'.

When renaming files, move to next file using tab key or up/down

To rename previous file:
 Up or Shift-Tab

To rename next file:
 Down or Tab

Credit goes to msciubidlo
Related: bug 403931, bug 269987
FIXED-IN: 21.08

M  +5-0src/kitemviews/kitemlistcontainer.cpp
M  +5-2src/kitemviews/kitemlistview.cpp
M  +6-0src/kitemviews/kitemlistview.h
M  +1-0src/kitemviews/kstandarditemlistwidget.cpp
M  +24   -2src/kitemviews/private/kitemlistroleeditor.cpp
M  +18   -2src/kitemviews/private/kitemlistroleeditor.h
M  +3-0src/kitemviews/private/kitemlistsmoothscroller.cpp
M  +5-0src/kitemviews/private/kitemlistsmoothscroller.h
M  +28   -9src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/commit/5a0da4a9c8d10dc1921077d84bdabf05d20150b0

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=334533

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #15 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=334533

--- Comment #14 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Justin]

https://bugs.kde.org/show_bug.cgi?id=334533

Justin  changed:

   What|Removed |Added

 Status|REOPENED|NEEDSINFO
 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #13 from Justin  ---
I can't seem to reproduce this.

I've got files 1-5 in my folder. I set a terminal to sleep 5 && rm 3. I start
renaming 4 and it works perfectly while the file 3 is deleted and disappears
from Dolphin.

Am I misreading how this is working? Is it still an issue in the latest Dolphin
versions for others?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=334533

--- Comment #12 from Wolfgang Bauer  ---
(In reply to Christoph Feck from comment #11)
> Anything left for this ticket? There were related fixes today.

No, there haven't been any fixes related to *this* problem, that a wrong file
can be renamed if the list changes.

Only bug#398375 has been fixed, i.e. dragging a file should no longer trigger
inline rename at all (which might have renamed a different file to the name of
the dragged file because of this bug here).

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=334533

--- Comment #11 from Christoph Feck  ---
Anything left for this ticket? There were related fixes today.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=334533

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #10 from Wolfgang Bauer  ---
The last 2 comments actually describe a completely different problem IMHO:
Dragging a file shouldn't trigger inline rename in the first place, but it
apparently does under certain circumstances.

There's also bug#398375 about that particular issue though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=334533

mwc85.2...@gmail.com changed:

   What|Removed |Added

 CC||mwc85.2...@gmail.com

--- Comment #9 from mwc85.2...@gmail.com ---
I'm experiencing this problem with Dolphin 17.12.2 on Fedora 28:

KDE Frameworks 5.46.0
Qt 5.10.1 (built against 5.10.1)
The xcb windowing system

This is a VERY SERIOUS bug -- If you drag and drop a file with Dolphin into the
trash, the VERY next file in the list is renamed to the name of the deleted
file. If you don't know dolphin is doing this, you could think it failed to
delete the file you wanted, and if you try again, you can accidentally delete
more files than you wanted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[David Tonhofer]

https://bugs.kde.org/show_bug.cgi?id=334533

David Tonhofer  changed:

   What|Removed |Added

 CC||bugh...@gluino.name

--- Comment #8 from David Tonhofer  ---
In the original report:

"I frequently run into this bug when renaming in a folder with several,
continuously updated files and using the sorting by date. While those are bad
results this bug is likely not triggered that often for average users."

Actually, if this is the same bug, I often trigger it by just sorting files
from the main window into the sidebar where target directories are listed (I
tried to find a way to reproduce this in #389892). For some reason, rename
often becomes active when I do that. I probably nuked a few files doing so. Now
I have to be super attentive, this is like a self-driving car.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 334533] if a file position in a list changes while it is renamed a wrong file is renamed instead

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=334533

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net
 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #7 from Henrik Fehlauer  ---
Reopening because the former duplicate has been solved, while this one is still
a problem in current git master.

In detail:
- In Bug 378786, scrolling triggers the problem. The fix in
https://phabricator.kde.org/D8822 hides the issue by accepting the rename as
soon as scrolling starts, so the bug can never occur.
- In Bug 331236, the problem is triggered by moving around with the keyboard
before sorting happens. This is fixed (probably by accident) in
https://phabricator.kde.org/D6312, after which starting a rename is blocked
until the renamed file has been sorted and given focus again.
- However, for changes to files not coming from Dolphin (i.e. as described
above, which translates to all sorts of valid scenarios in reality) the problem
persists.

>From a high-level view, it seems that inline renaming operates on the list
position pointing to a (randomly changing) file, instead of a stable handle to
the actual file (not necessarily an inode, as KIO is network transparent).

Note that when disabling inline renaming, the bug does not occur. It would be
worth checking where this difference in behaviour comes from.

See also this comment: https://phabricator.kde.org/D8822#168476

-- 
You are receiving this mail because:
You are watching all bug changes.