[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||juicy.black@gmail.com

--- Comment #13 from Elvis Angelaccio  ---
*** Bug 394507 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

--- Comment #12 from Elvis Angelaccio  ---
*** Bug 393128 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||noavan.purn...@gmail.com

--- Comment #11 from Elvis Angelaccio  ---
*** Bug 393136 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||yst...@posteo.net

--- Comment #8 from Elvis Angelaccio  ---
*** Bug 393652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||balthasar.b...@gmx.de

--- Comment #10 from Elvis Angelaccio  ---
*** Bug 393784 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||clone1...@outlook.com

--- Comment #9 from Elvis Angelaccio  ---
*** Bug 393500 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=393528

Antonio Rojas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/0c05b992c0dbfb2b065134
   ||4413310d0b860c2fa7
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Antonio Rojas  ---
Git commit 0c05b992c0dbfb2b0651344413310d0b860c2fa7 by Antonio Rojas.
Committed on 29/04/2018 at 17:39.
Pushed by arojas into branch 'Applications/18.04'.

Don't filter out duplicated entries from places panel

This can lead to crashes and is inconsistent with the KIO file picker dialog,
which shows duplicated entries.

Differential Revision: https://phabricator.kde.org/D12558

M  +1-4src/panels/places/placesitemmodel.cpp

https://commits.kde.org/dolphin/0c05b992c0dbfb2b0651344413310d0b860c2fa7

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=393528

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||abake...@gmail.com

--- Comment #6 from Elvis Angelaccio  ---
*** Bug 393435 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Julian Schraner]

https://bugs.kde.org/show_bug.cgi?id=393528

Julian Schraner  changed:

   What|Removed |Added

 CC||juliquad...@gmail.com
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

--- Comment #5 from Julian Schraner  ---
Confirmed & Antonio is working on a fix. (See the Phabricator link from comment
4)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=393528

--- Comment #4 from Antonio Rojas  ---
https://phabricator.kde.org/D12558

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=393528

--- Comment #3 from Antonio Rojas  ---
Hmm the first backtrace seems to be unrelated, this is the good one

(gdb) bt
#0  0x000a0002 in ?? ()
#1  0x719feada in QObjectPrivate::connectImpl
(sender=sender@entry=0x55eaadb0, signal_index=, 
receiver=receiver@entry=0x55e0d930, slot=slot@entry=0x7fffda20,
slotObj=slotObj@entry=0x55be4270, 
type=, types=, senderMetaObject=) at kernel/qobject.cpp:4848
#2  0x719fecbc in QObject::connectImpl
(sender=sender@entry=0x55eaadb0, signal=signal@entry=0x7fffda10, 
receiver=receiver@entry=0x55e0d930, slot=slot@entry=0x7fffda20,
slotObj=0x55be4270, 
type=Qt::AutoConnection, types=0x0, senderMetaObject=0x77dd3860
)
at kernel/qobject.cpp:4785
#3  0x77b6d583 in QObject::connect (type=Qt::AutoConnection, slot=
(void (PlacesItemModel::*)(PlacesItemModel * const, const QString &))
0x77b8fa80 , receiver=0x55e0d930, signal=
(void (PlacesItemSignalHandler::*)(PlacesItemSignalHandler * const, const
QString &)) 0x77b8fae0
,
sender=0x55eaadb0) at /usr/include/qt/QtCore/qobject.h:260
#4  PlacesItemModel::addItemFromSourceModel (this=this@entry=0x55e0d930,
index=...)
at
/build/dolphin/src/dolphin-18.04.0/src/panels/places/placesitemmodel.cpp:408
#5  0x77b6d792 in PlacesItemModel::onSourceModelRowsInserted
(this=0x55e0d930, parent=..., 
first=, last=8) at
/build/dolphin/src/dolphin-18.04.0/src/panels/places/placesitemmodel.cpp:525
#6  0x719fa7af in QtPrivate::QSlotObjectBase::call (a=0x7fffdbd0,
r=0x55e0d930, this=0x55e23e40)
at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:378
#7  QMetaObject::activate (sender=sender@entry=0x55c53bc0,
signalOffset=, 
local_signal_index=local_signal_index@entry=10,
argv=argv@entry=0x7fffdbd0) at kernel/qobject.cpp:3750
#8  0x719fad89 in QMetaObject::activate
(sender=sender@entry=0x55c53bc0, 
m=m@entry=0x71e2bda0 ,
local_signal_index=local_signal_index@entry=10, 
argv=argv@entry=0x7fffdbd0) at kernel/qobject.cpp:3629
#9  0x71962eef in QAbstractItemModel::rowsInserted
(this=this@entry=0x55c53bc0, _t1=..., _t2=, 
_t3=, _t4=...) at .moc/moc_qabstractitemmodel.cpp:602
#10 0x7196a73d in QAbstractItemModel::endInsertRows
(this=0x55c53bc0) at itemmodels/qabstractitemmodel.cpp:2709
#11 0x76f9927d in KFilePlacesModel::Private::_k_reloadBookmarks
(this=this@entry=0x55c13890)
at /build/kio/src/kio-5.45.0/src/filewidgets/kfileplacesmodel.cpp:632
#12 0x76f998a0 in KFilePlacesModel::Private::_k_initDeviceList
(this=0x55c13890)
at /build/kio/src/kio-5.45.0/src/filewidgets/kfileplacesmodel.cpp:537
#13 0x76f9af89 in KFilePlacesModel::qt_static_metacall (_o=, _id=, 
_a=, _c=)
at
/build/kio/src/build/src/filewidgets/KF5KIOFileWidgets_autogen/include/moc_kfileplacesmodel.cpp:118
#14 0x719fb0d2 in QObject::event (this=0x55c53bc0, e=) at kernel/qobject.cpp:1247
#15 0x729d807c in QApplicationPrivate::notify_helper
(this=this@entry=0x55771650, 
---Type  to continue, or q  to quit---
receiver=receiver@entry=0x55c53bc0, e=e@entry=0x55c93210) at
kernel/qapplication.cpp:3732
#16 0x729dfa56 in QApplication::notify (this=0x7fffe440,
receiver=0x55c53bc0, e=0x55c93210)
at kernel/qapplication.cpp:3491
#17 0x719c9d60 in QCoreApplication::notifyInternal2
(receiver=0x55c53bc0, event=event@entry=0x55c93210)
at kernel/qcoreapplication.cpp:1050
#18 0x719cc9c6 in QCoreApplication::sendEvent (event=0x55c93210,
receiver=)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:234
#19 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0,
event_type=event_type@entry=0, 
data=0x5576f190) at kernel/qcoreapplication.cpp:1740
#20 0x719ccf5a in QCoreApplication::sendPostedEvents
(receiver=receiver@entry=0x0, event_type=event_type@entry=0)
at kernel/qcoreapplication.cpp:1594
#21 0x71a26cc4 in postEventSourceDispatch (s=0x557d8f50) at
kernel/qeventdispatcher_glib.cpp:276
#22 0x7fffe8423368 in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#23 0x7fffe84235b1 in ?? () from /usr/lib/libglib-2.0.so.0
#24 0x7fffe842363e in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#25 0x71a262b1 in QEventDispatcherGlib::processEvents
(this=0x557ebe70, flags=...)
at kernel/qeventdispatcher_glib.cpp:423
#26 0x7fffe3365c62 in QPAEventDispatcherGlib::processEvents
(this=0x557ebe70, flags=...)
at qeventdispatcher_glib.cpp:69
#27 0x719c839b in QEventLoop::exec (this=this@entry=0x7fffe340,
flags=..., 

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=393528

--- Comment #2 from Antonio Rojas  ---
Created attachment 112248
  --> https://bugs.kde.org/attachment.cgi?id=112248=edit
Minimal user-places.xbel test case that makes dolphin crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 393528] crash if user-places.xbel contains a duplicated entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=393528

--- Comment #1 from Antonio Rojas  ---
*** Bug 393529 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.