[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867
--- Comment #6 from Elvis Angelaccio ---
Git commit e9d8bab20bdc6aa43beefdd038483a4c02d8 by Elvis Angelaccio, on
behalf of Andrey Yashkin.
Committed on 28/07/2019 at 20:14.
Pushed by elvisangelaccio into branch 'master'.
Fix name grouping feature for cyrillic names
Summary:
All files and folders with cyrillic names are placed in latin 'A' group. This
patch fixes this issue.
Test Plan:
Make grouping by name in the dir with cyrillic files or dirs in it.
See screenshots below.
Before {F6985465}
After {F6985459}
Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: hein, cfeck, ngraham, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22303
M +24 -17 src/kitemviews/kfileitemmodel.cpp
https://commits.kde.org/dolphin/e9d8bab20bdc6aa43beefdd038483a4c02d8
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867
--- Comment #6 from Elvis Angelaccio ---
Git commit e9d8bab20bdc6aa43beefdd038483a4c02d8 by Elvis Angelaccio, on
behalf of Andrey Yashkin.
Committed on 28/07/2019 at 20:14.
Pushed by elvisangelaccio into branch 'master'.
Fix name grouping feature for cyrillic names
Summary:
All files and folders with cyrillic names are placed in latin 'A' group. This
patch fixes this issue.
Test Plan:
Make grouping by name in the dir with cyrillic files or dirs in it.
See screenshots below.
Before {F6985465}
After {F6985459}
Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: hein, cfeck, ngraham, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22303
M +24 -17 src/kitemviews/kfileitemmodel.cpp
https://commits.kde.org/dolphin/e9d8bab20bdc6aa43beefdd038483a4c02d8
--- Comment #7 from Elvis Angelaccio ---
Git commit b8849f74aab2e22cc1b891c7dcf4f759fb523ea9 by Elvis Angelaccio.
Committed on 28/07/2019 at 20:14.
Pushed by elvisangelaccio into branch 'master'.
Revert "Fix name grouping feature for cyrillic names"
This reverts commit dc586ada63d1822fbbe38a0dd3449c73b03928e0.
D22303 had a wrong diff.
M +24 -2src/kitemviews/kfileitemmodel.cpp
https://commits.kde.org/dolphin/b8849f74aab2e22cc1b891c7dcf4f759fb523ea9
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 Elvis Angelaccio changed: What|Removed |Added Component|general |view-engine: general -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867
Elvis Angelaccio changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In||19.11.80
Latest Commit||https://commits.kde.org/dol
||phin/dc586ada63d1822fbbe38a
||0dd3449c73b03928e0
Status|CONFIRMED |RESOLVED
--- Comment #5 from Elvis Angelaccio ---
Git commit dc586ada63d1822fbbe38a0dd3449c73b03928e0 by Elvis Angelaccio, on
behalf of Andrey Yashkin.
Committed on 28/07/2019 at 15:07.
Pushed by elvisangelaccio into branch 'master'.
Fix name grouping feature for cyrillic names
Summary:
All files and folders with cyrillic names are placed in latin 'A' group. This
patch fixes this issue.
FIXED-IN: 19.11.80
Test Plan:
Make grouping by name in the dir with cyrillic files or dirs in it.
See screenshots below.
Before {F6985465}
After {F6985459}
Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: hein, cfeck, ngraham, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22303
M +2-24 src/kitemviews/kfileitemmodel.cpp
https://commits.kde.org/dolphin/dc586ada63d1822fbbe38a0dd3449c73b03928e0
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 Andrey Yashkin changed: What|Removed |Added CC||andreyyash...@gmail.com --- Comment #4 from Andrey Yashkin --- For some reason QCollator thinks that cyrillic(or at least russian) symbols are less than latin characters, while the code seems to be written with the assumption than they are bigger. I made a patch to consider such case. https://phabricator.kde.org/D22303 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 --- Comment #3 from Andrey Kozlovskiy --- It turned out that the problem depends on the language. For example, grouping works fine with English (GB and US) and German, but not with Russian (ru_RU.UTF-8). Run dolphin with LANGUAGE variable to test: > LANGUAGE="en_US.UTF-8" dolphin -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 --- Comment #2 from Andrey Kozlovskiy --- Created attachment 120098 --> https://bugs.kde.org/attachment.cgi?id=120098&action=edit Grouping works fine with some non-latin chars Sorry, forgot to mention that not all non-latin symbols maps to latin A..Z. That's why I only wrote about cyrillic names. Greek symbols works fine for me, also chinese and japanese, for example. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 406867] Dolphin name grouping feature doesn't work with cyrillic names
https://bugs.kde.org/show_bug.cgi?id=406867 Christoph Feck changed: What|Removed |Added Status|REPORTED|CONFIRMED Keywords||junior-jobs Ever confirmed|0 |1 --- Comment #1 from Christoph Feck --- Indeed the latin letter range 'A'...'Z' is hardcoded, see https://cgit.kde.org/dolphin.git/tree/src/kitemviews/kfileitemmodel.cpp#n1899 We could add (at least) greek and cyrillic letter ranges. -- You are receiving this mail because: You are watching all bug changes.
