[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 Akseli Lahtinen changed: What|Removed |Added CC||mothli...@fastmail.fm --- Comment #10 from Akseli Lahtinen --- *** Bug 479240 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 Akseli Lahtinen changed: What|Removed |Added Latest Commit||https://invent.kde.org/syst ||em/dolphin/-/commit/b1f9c2e ||5c90548f391477fa17889ff8d1a ||bf8f53 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Akseli Lahtinen --- Git commit b1f9c2e5c90548f391477fa17889ff8d1abf8f53 by Akseli Lahtinen. Committed on 08/12/2023 at 11:59. Pushed by akselmo into branch 'master'. Do not reset expandability when loading previews Fixes a weird bug with the treeview if one has ``` [PreviewSettings] Plugins=audiothumbnail ``` in their `dolphinrc`. It can be any PreviewSettings plugin, as long as there it at least one. Check the bug report for more, but in short, the bug is reproducible like this: ``` create folder tree inside a test folder with mkdir -p 1/A/B/C/D/E/F/G/H/I mkdir -p 2/A/B/C/D/E/F/G/H/I mkdir -p 3/A/B/C/D/E/F/G/H/I make sure you see the test folder, and expand it expand folder 1, no need to expand all sub folders expand folder 2 collapse and expand test folder 3 loses its expansion arrow if all folders are expanded, only 3 keeps its order if 1 and all its subfolders are expanded, then test is toggled, folder 2 also loses its expansion arrow ``` Video of the bug:  The path to the bug is: `KFileItemModelRolesUpdater::slotPreviewFailed` -> `KFileItemModelRolesUpdater::applyResolvedRoles` -> `KFileItemModelRolesUpdater::rolesData` -> `KFileItemModelRolesUpdater::startDirectorySizeCounting`. This causes Dolphin with preview plugins enabled trying to count the directories again, and the data gets reset even if there is something there. This then resets the `isExpandable` flag and that breaks the treeview, causing all kinds of issues, like being able to expand non-directories and makes things out of sync. M +0-2src/kitemviews/kfileitemmodelrolesupdater.cpp https://invent.kde.org/system/dolphin/-/commit/b1f9c2e5c90548f391477fa17889ff8d1abf8f53 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/672 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #7 from Akseli Lahtinen --- This bug happens only if your dolphinrc has anything in [PreviewSettings] For example: [PreviewSettings] Plugins=audiothumbnail -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #6 from Akseli Lahtinen --- I can still reproduce the issue, but it happens very randomly. Same steps as above should work though. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #5 from Nate Graham --- Hmm, I'm not able to see as issue with those steps. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #4 from Akseli Lahtinen --- Created attachment 163560 --> https://bugs.kde.org/attachment.cgi?id=163560=edit After rebuild After rebuilding it now closes the 1 and 2 folders when base folder is toggled, but keeps 3 expanded. Only thing that changed was translation files. This is better behavior, at least. Optimally all folders would expand like previously. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #3 from Akseli Lahtinen --- Seems the index for the folders gets reset and they get opened in wrong order. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #2 from Akseli Lahtinen --- Dolphin version: dolphin 24.01.80 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 Bug Janitor Service changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 477607] Folder tree view breaks if multiple nested subfolders are closed and opened
https://bugs.kde.org/show_bug.cgi?id=477607 --- Comment #1 from Akseli Lahtinen --- If one toggles base folder again, it shrinks even more. -- You are receiving this mail because: You are watching all bug changes.
