[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #20 from Christoph Feck --- Regarding Dolphin, it uses custom pixmaps to colorize the icons for the selection effect. Using scaling factors affects such code. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #19 from Vladimír Vondruš --- Yes, thanks a lot for the last commit! It looked related to the last remaining issues I described above and so I and tried to apply it right away on the stable kiconthemes 5.56. Both Dolphin and Elisa are now working perfectly with it (and, conversely, are reproducibly broken with vanilla 5.56). I'm not sure if this points to some other issue (why would only Dolphin and Elisa be affected like that, are they using some icons in an unsupported way?), but nevertheless it's fixed now with this commit. Thanks a lot again. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In|5.52|5.57 Status|REOPENED|RESOLVED --- Comment #18 from Nate Graham --- This is now fully fixed for me as of that commit (which will be in KDE Frameworks 5.57). Can folks who can test from source code verify? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #17 from Kai Uwe Broulik --- Git commit 89344923c00b7bc502f5c24be50027b457d82177 by Kai Uwe Broulik. Committed on 13/03/2019 at 11:20. Pushed by broulik into branch 'master'. Fix padding icon that doesn't exactly match the requested size The size we get already takes into account scaling, so we end up creating a pixmap whose size was scaled twice and then had the view scale it down again. Reviewed-By: Marco Martin Related: bug 397106 M +1-1src/kiconengine.cpp https://commits.kde.org/kiconthemes/89344923c00b7bc502f5c24be50027b457d82177 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #16 from Nate Graham --- (In reply to Vladimír Vondruš from comment #15) > I did `rm ~/.cache/icon-cache.kcache` as suggested on > https://www.reddit.com/r/kde/comments/9wsnk4/how_to_delete_the_icons_cache/, > then restarted Dolphin and that *seemingly* fixed it. That's Bug 403229. > Finally I rebooted the system and removed the icon cache even before logging > in to KDE, thinking that some background process was still responsible for > overwriting the cache with broken versions. After login both Dolphin and > Elisa were back to the old broken state. Now, no matter how much I `rm` the > cache, nothing changes. > > I have no idea about what's all involved in this, but my suspicion is that > there's some background process caching unscaled icons (without taking the > 1.7x scaling into account), and then the apps pick them up from the cache > without realizing they're not the correct scale. Is there something I can do > to debug this further? Probably, but I'm afraid you've reached the limit of my knowledge here. Hopefully another developer will chime in with more information. > (Probably unrelated to this, but context menus on my Plasma desktop are not > respecting the system-wide scaling, having proper text size but the icons > and padding like on a 1x scaling. I was not able to convince it to follow > system-wide scaling. Could Plasma be responsible for putting these unscaled > icons into cache?) That's a separate issue: Bug 356446. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #15 from Vladimír Vondruš --- I did `rm ~/.cache/icon-cache.kcache` as suggested on https://www.reddit.com/r/kde/comments/9wsnk4/how_to_delete_the_icons_cache/, then restarted Dolphin and that *seemingly* fixed it. It partially fixed it for Elisa (the left panel icons), but the play/pause/... icons stayed broken the same way as before. I cycled through this a few times, but nothing changed. (I can post another screenshot, if that helps in any way, but I think you have the idea.) Finally I rebooted the system and removed the icon cache even before logging in to KDE, thinking that some background process was still responsible for overwriting the cache with broken versions. After login both Dolphin and Elisa were back to the old broken state. Now, no matter how much I `rm` the cache, nothing changes. I have no idea about what's all involved in this, but my suspicion is that there's some background process caching unscaled icons (without taking the 1.7x scaling into account), and then the apps pick them up from the cache without realizing they're not the correct scale. Is there something I can do to debug this further? (Probably unrelated to this, but context menus on my Plasma desktop are not respecting the system-wide scaling, having proper text size but the icons and padding like on a 1x scaling. I was not able to convince it to follow system-wide scaling. Could Plasma be responsible for putting these unscaled icons into cache?) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #14 from Nate Graham --- Hmm, I cannot reproduce your problem with Dolphin or Elisa when using a 1.7x systemwide scale factor. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Vladimír Vondruš changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #13 from Vladimír Vondruš --- Hi again, I just updated to 5.55 (after being pinned to kiconthemes 5.47 since my last comment) and I'm sorry to say this, but it still doesn't happen to be fully fixed compared to 5.47. While the issue disappeared from almost all apps I use (KDevelop, Akregator, Kate works well), it's still present in Dolphin (file icons when you scale them all the way down) and Elisa play/pause/... controls (but not the Albums / Artists / ... icons). The bug presents itself similarly as before -- a weirdly scaled down version in the bottom right corner. I rebuilt Elisa from Git just to be sure, but that didn't help. Reverting again back to kiconthemes 5.47 helped, tho. Is there something special these two apps do, compared to others? To help you reproduce, my desktop scaling is 1.7x. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Nate Graham changed: What|Removed |Added Version Fixed In||5.52 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Kai Uwe Broulik changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kic ||onthemes/2699d36365fabb7be5 ||6a5d6d8a3ef3867eac7605 --- Comment #12 from Kai Uwe Broulik --- Git commit 2699d36365fabb7be56a5d6d8a3ef3867eac7605 by Kai Uwe Broulik. Committed on 18/10/2018 at 08:41. Pushed by broulik into branch 'master'. Center icons properly if size doesn't fit When requesting an icon size that cannot be served, the pixmap is centered in the requested size. By using the original pixmap's device pixel ratio we ensure the padded pixmap is painted correctly. Differential Revision: https://phabricator.kde.org/D16291 M +2-2src/kiconengine.cpp https://commits.kde.org/kiconthemes/2699d36365fabb7be56a5d6d8a3ef3867eac7605 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #11 from Kai Uwe Broulik --- Please give this patch a try: https://phabricator.kde.org/D16291 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #10 from Alexander Mentyu --- I can reproduce this bug in Default Dolphin view settings, FHD screen Operating System: KDE neon Developer Edition KDE Plasma Version: 5.14.80 Qt Version: 5.11.1 KDE Frameworks Version: 5.52.0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 --- Comment #9 from Nate Graham --- I can no longer reproduce this issue with git master when doing `QT_SCALE_FACTOR=[anything] dolphin` or using the KScreen KCM's scaling UI. Icons now look correct at all scale factors for me. Is anyone else still able to reproduce this with KDE Frameworks 5.51 and/or git master? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 396990] [Regression from Frameworks 5.47 -> 5.48] Dolphin icons are incorrectly aligned if display scaling is used
https://bugs.kde.org/show_bug.cgi?id=396990 Nate Graham changed: What|Removed |Added CC||k...@privat.broulik.de Component|general |general Assignee|fa...@kde.org |cf...@kde.org Product|frameworks-kio |frameworks-kiconthemes --- Comment #8 from Nate Graham --- You're very welcome, and thanks for the investigation, Vladimir. I can confirm it, and reverting 20f7137145f6b6fb38d2c3dd01a8443b8315cf41 fixes the issue for me. Kai, could you take a look? You can trivially reproduce the issue by running `QT_SCALE_FACTOR=1.3 dolphin`. With 20f7137145f6b6fb38d2c3dd01a8443b8315cf41, the icons are broken; without it, they're fine. -- You are receiving this mail because: You are watching all bug changes.
