[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #18 from Ilya Fedin --- I explained in the previous message, please re-read it. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #17 from soredake --- This bug title is "telegram notification counter not working" I description we have this: ``` OBSERVED RESULT The icon tray doesn't show any red dot or any number of received messages EXPECTED RESULT The notification counter in system-tray should become red and show a number of received messages ``` Bug closed as "Resolved Fixed". The question is, what's fixed if notification counter is still not working? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #16 from Ilya Fedin --- So it works as intended -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #15 from soredake --- (In reply to Ilya Fedin from comment #14) > Are you sure you have non-monochrome icon? This bug is about non-monochrome > icon not having the counter when it's supposed to. The monochrome icon is > not supposed to have the counter and that's intended from Telegram side. I get monochrome icon with dot, still, i use telegram from flatpak. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #14 from Ilya Fedin --- Are you sure you have non-monochrome icon? This bug is about non-monochrome icon not having the counter when it's supposed to. The monochrome icon is not supposed to have the counter and that's intended from Telegram side. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #13 from soredake --- Is this really fixed? I'm on opensuse leap kde 15.4 with last kde software and i still see kde's icon without counter. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Kai Uwe Broulik changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kiconthemes/commit/1 ||f48af65477ef1829bd07dc4bdb2 ||67ecca870be1 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #12 from Kai Uwe Broulik --- Git commit 1f48af65477ef1829bd07dc4bdb267ecca870be1 by Kai Uwe Broulik. Committed on 20/09/2022 at 09:18. Pushed by broulik into branch 'master'. KIconEngine: Return actual icon name of loaded icon XDG icon themes return a "more generic" fallback icon if the requested one cannot be found, e.g. `foo-bar` may return `foo`. Previously, the returned `QIcon` would still return a name of `foo-bar`, which made it impossible for applications to check whether the specific icon requested was actually loaded. M +7-0autotests/kiconengine_unittest.cpp M +26 -6src/kiconengine.cpp M +24 -13 src/kiconloader.cpp M +9-1src/kiconloader_p.h https://invent.kde.org/frameworks/kiconthemes/commit/1f48af65477ef1829bd07dc4bdb267ecca870be1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Bug Janitor Service changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #11 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/79 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #10 from soredake --- https://bugs.kde.org/show_bug.cgi?id=454761 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 soredake changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=454761 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #9 from soredake --- Are there any progress on this? I really want to see notification counter in telegram's icon. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 soredake changed: What|Removed |Added CC||ndrzj1...@relay.firefox.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Orivej Desh changed: What|Removed |Added CC||ori...@gmx.fr -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 EGD changed: What|Removed |Added CC||egdf...@opensuse.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Colin Griffith changed: What|Removed |Added CC||tyna...@gmail.com --- Comment #8 from Colin Griffith --- Okay, I'm on KDE Neon and just got the update that supposedly fixed this. It broke it. I cannot see how many conversations have new messages for me in Telegram, instead only seeing a blue dot. I have KDE Frameworks 5.79. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Michael changed: What|Removed |Added CC||gf...@gfdsa.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Nate Graham changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #7 from Nate Graham --- Fair enough. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Ilya Fedin changed: What|Removed |Added CC||fedin-ilja2...@ya.ru --- Comment #6 from Ilya Fedin --- Why the bugreport is closed if the underlying bug in kiconthemes is still not fixed? Even if it won't be observable with the Breeze icon theme, it will still be observable with any third-party icon theme with color and without monochrome icon. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||5.79 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 --- Comment #5 from giuseppe --- (In reply to ariasuni from comment #4) > I believe this is fixed by: > https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/81 > > This will be available in KDE Frameworks 5.79, which will be released this > month: > https://community.kde.org/Schedules/Frameworks > > (I asked on the merge request if it couldn’t be backported to avoid this > feature be broken for too long for people who won’t get KDE Frameworks 5.79 > soon) Seems good, I will give a try in a live system as soon as the 5.79 comes out, thank you. This should fix the monochrome icon problem and also give the possibility to have a message counter on it. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 ariasuni changed: What|Removed |Added CC||pe...@hack-libre.org --- Comment #4 from ariasuni --- I believe this is fixed by: https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/81 This will be available in KDE Frameworks 5.79, which will be released this month: https://community.kde.org/Schedules/Frameworks (I asked on the merge request if it couldn’t be backported to avoid this feature be broken for too long for people who won’t get KDE Frameworks 5.79 soon) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 CC||n...@kde.org Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293
--- Comment #3 from giuseppe ---
(In reply to Kai Uwe Broulik from comment #2)
> Ok, so the bug is probably that KIconEngine::name() always returns the input
> name whereas Qt does a check for whether the icon("foo-bar") is actually
> what it got. Since KIconEngine always returns "foo-bar" even if it did a
> fallback to "foo", Qt will always consider it existing. Now this I would say
> is a genuine bug in KIconEngine/KIconLoader.
I don't understand a lot of technical details but it seems to be at a dead end.
This problem came out after telegram changed its behaviour about monochrome
icons, now they only show a dot (as per request from many users with a
monochrome icon theme). It worked perfectly before for normal icons.
I don't know if can be of interest but if I download the binary from
https://desktop.telegram.org/ it works as intended, even the beta version
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293
--- Comment #2 from Kai Uwe Broulik ---
Ok, so the bug is probably that KIconEngine::name() always returns the input
name whereas Qt does a check for whether the icon("foo-bar") is actually what
it got. Since KIconEngine always returns "foo-bar" even if it did a fallback to
"foo", Qt will always consider it existing. Now this I would say is a genuine
bug in KIconEngine/KIconLoader.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-kiconthemes] [Bug 432293] telegram notification counter not working
https://bugs.kde.org/show_bug.cgi?id=432293
Kai Uwe Broulik changed:
What|Removed |Added
CC||k...@privat.broulik.de
--- Comment #1 from Kai Uwe Broulik ---
I was told QIcon::hasThemeIcon("telegram-attention-panel") returns true with
KIconEngine because it falls back to "telegram" which exists. Qt does not do
that.
I think when explicitly checking for hasThemeIcon we don't really want to do
that fallback dance? However, I don't know what else it would break if we
changed that...
--
You are receiving this mail because:
You are watching all bug changes.
