[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=223937

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://cgit.kde.org/kio.gi
   ||t/commit/?id=59b944470470f6
   ||bb65fc46cfff8181f7887fd9c8
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.66

--- Comment #5 from Nate Graham  ---
author  Arjen Hiemstra  2019-12-21 11:55:38 -0700
committer   Nate Graham   2019-12-21 11:56:04 -0700
commit  59b944470470f6bb65fc46cfff8181f7887fd9c8 (patch)
tree677ebbeb0ca56422733e4908c16dd7991f1effc0
parent  9c131b2944334dd7185c2c8e3537ffe76d3ba7ae (diff)
KDirOperator: Use a fixed line height for scroll speedHEADmaster
Summary:
This patch intends to do mostly the same as D19190, but for KDirOperator.
This uses the font's line height multiplied by the amount of scroll lines
from QApplication as a scroll speed for views. This makes the scroll speed
not depend on the icon size, which greatly improves scrolling behaviour.
For more details, see the linked review.

Test Plan:
Run tests/kfilewidgettest_gui and go to a directory with a lot of items.
Scroll around, then change icon size and see that scrolling speed remains
the same.

Reviewers: ngraham, elvisangelaccio

Reviewed By: ngraham, elvisangelaccio

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25683

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[petrk]

https://bugs.kde.org/show_bug.cgi?id=223937

petrk  changed:

   What|Removed |Added

 CC||pepk...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[lots0logs]

https://bugs.kde.org/show_bug.cgi?id=223937

lots0logs  changed:

   What|Removed |Added

 CC||dus...@falgout.us

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=223937

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=223937

Nate Graham  changed:

   What|Removed |Added

 Blocks|86838   |


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=86838
[Bug 86838] Switch to icons-on-top mode by default for Short View
-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Colin Griffith]

https://bugs.kde.org/show_bug.cgi?id=223937

Colin Griffith  changed:

   What|Removed |Added

 CC||tyna...@gmail.com

--- Comment #4 from Colin Griffith  ---
(In reply to Nate Graham from comment #3)
> Created attachment 118226 [details]
> Skeleton patch
> 
> Something like the attached patch should do it. It doesn't work, and I'm not
> sure why yet, but it shows the general idea of a fix for this issue.

Second to last line of the patch:

> const int height = itemView->iconSize().height() + metrics.height() * 2.5;

So, you're still including the iconSize().height() in the calculation. Removing
that should work, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=223937

--- Comment #3 from Nate Graham  ---
Created attachment 118226
  --> https://bugs.kde.org/attachment.cgi?id=118226=edit
Skeleton patch

Something like the attached patch should do it. It doesn't work, and I'm not
sure why yet, but it shows the general idea of a fix for this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=223937

boski_ci...@o2.pl changed:

   What|Removed |Added

 CC||boski_ci...@o2.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=223937

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Cqoicebordel]

https://bugs.kde.org/show_bug.cgi?id=223937

Cqoicebordel  changed:

   What|Removed |Added

 CC||david.bar...@wanadoo.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 223937] Scrolling with mouse wheel is too fast in large-icon-sized dialog boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=223937

Nate Graham  changed:

   What|Removed |Added

   Assignee|kdelibs-b...@kde.org|fa...@kde.org
 CC||kdelibs-b...@kde.org
  Component|general |Open/save dialogs
Product|kfile   |frameworks-kio

-- 
You are receiving this mail because:
You are watching all bug changes.