[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=368104

Méven Car  changed:

   What|Removed |Added

 CC||meve...@gmail.com
   Version Fixed In|5.95|5.98

--- Comment #21 from Méven Car  ---
(In reply to Philippe ROUBACH from comment #19)
> I confirm. The problem is still there for movies (ts, mp4).
> 
> It seems this problem occurs with movies you fly over with mouse cursor.

The previous patch 4984b26849e2d1f182bf6a60216848ae9307295a was reverted the
new one should arrive in KF 5.98 provided testing goes well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=368104

Méven Car  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/kio/commit/4984b2684 |eworks/kio/commit/1773ee3e8
   |9e2d1f182bf6a60216848ae9307 |ae224b4a3536b403439e7e3b7c6
   |295a|f53e
 Status|REOPENED|RESOLVED

--- Comment #20 from Méven Car  ---
Git commit 1773ee3e8ae224b4a3536b403439e7e3b7c6f53e by Méven Car.
Committed on 21/08/2022 at 09:15.
Pushed by meven into branch 'master'.

trash:/ set the UDS_LOCAL_PATH

Should fix test regression:
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/1586/testReport/projectroot.src.ioslaves.trash/tests/testtrash/

cc https://invent.kde.org/frameworks/kio/-/merge_requests/618#note_457689

M  +15   -3autotests/dropjobtest.cpp
M  +12   -7src/core/copyjob.cpp
M  +2-1src/ioslaves/trash/kio_trash.cpp
M  +11   -5src/ioslaves/trash/tests/testtrash.cpp

https://invent.kde.org/frameworks/kio/commit/1773ee3e8ae224b4a3536b403439e7e3b7c6f53e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=368104

Philippe ROUBACH  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #19 from Philippe ROUBACH  ---
I confirm. The problem is still there for movies (ts, mp4).

It seems this problem occurs with movies you fly over with mouse cursor.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #18 from Patrick Silva  ---
This bug persists at least with .jpg files after update to frameworks 5.95.

Operating System: Arch Linux
KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4
Graphics Platform: Wayland

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368104

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.89|5.95

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=368104

Méven Car  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/kio/commit/dedf0ee37 |eworks/kio/commit/4984b2684
   |f16c587826cf6ad9a6e6cec241a |9e2d1f182bf6a60216848ae9307
   |8d37|295a

--- Comment #17 from Méven Car  ---
Git commit 4984b26849e2d1f182bf6a60216848ae9307295a by Méven Car, on behalf of
Méven Car.
Committed on 26/05/2022 at 07:21.
Pushed by meven into branch 'master'.

trash:/ set the UDS_LOCAL_PATH

M  +2-1src/ioslaves/trash/kio_trash.cpp
M  +1-1src/ioslaves/trash/tests/testtrash.cpp

https://invent.kde.org/frameworks/kio/commit/4984b26849e2d1f182bf6a60216848ae9307295a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Andrew Simmons]

https://bugs.kde.org/show_bug.cgi?id=368104

Andrew Simmons  changed:

   What|Removed |Added

 CC||agsimmo...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=368104

Patrick Silva  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #16 from Patrick Silva  ---
The 'fix' was reverted in frameworks 5.90 and this bug persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=368104

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #15 from Kai Uwe Broulik  ---
Not just trash, I dont see any thumbnails on any remote location anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Eduardo Sánchez Muñoz]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #14 from Eduardo Sánchez Muñoz  ---
I still think it is better than filling then RAM and crashing the whole OS.

There is https://invent.kde.org/frameworks/kio/-/merge_requests/618, which
should bring back trash thumbnails without needing to copy anything to /tmp.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #13 from Patrick Silva  ---
The 'fix' seems a regresion to me. Now Trash does not generate any preview,
what makes impossible to find the exact file I want to restore
when my Trash has lots of files with random names.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368104

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.89

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=368104

Méven Car  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/dedf0ee37
   ||f16c587826cf6ad9a6e6cec241a
   ||8d37
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #12 from Méven Car  ---
Git commit dedf0ee37f16c587826cf6ad9a6e6cec241a8d37 by Méven Car, on behalf of
Eduardo Sánchez Muñoz.
Committed on 28/11/2021 at 19:46.
Pushed by meven into branch 'master'.

Do not create thumbnails when it requires to copy the file to /tmp

M  +5-17   src/widgets/previewjob.cpp

https://invent.kde.org/frameworks/kio/commit/dedf0ee37f16c587826cf6ad9a6e6cec241a8d37

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=368104

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=368104

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/618

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/618

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Eduardo Sánchez Muñoz]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #9 from Eduardo Sánchez Muñoz  ---
It created MR https://invent.kde.org/frameworks/kio/-/merge_requests/617 to fix
this bug

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Eduardo Sánchez Muñoz]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #8 from Eduardo Sánchez Muñoz  ---
I wonder why trash files are copied to /tmp to make the thumbnails. They are
just regular files in ~/.local/share/Trash and they can be read without needing
to copy them elsewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=368104

Patrick Silva  changed:

   What|Removed |Added

 CC||eduardosanchezmunoz@gmail.c
   ||om

--- Comment #7 from Patrick Silva  ---
*** Bug 444349 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #6 from Philippe ROUBACH  ---
Please I get recently a non responded system due to a full / partition. Happily
I get a backup system. I was able to repair /tmp.

kde apps 20.12.2
kde plasma 5.20.5
kde frameworks 5.78.0
qt 5.15.2

Please it's a 5 years old problem. Freezing your system is a blocking bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Philippe ROUBACH]

https://bugs.kde.org/show_bug.cgi?id=368104

Philippe ROUBACH  changed:

   What|Removed |Added

Version|5.24.0  |5.66.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=368104

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||philippe.roub...@free.fr

--- Comment #5 from Wolfgang Bauer  ---
*** Bug 415924 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368104

Dr. Chapatin  changed:

   What|Removed |Added

 CC||hotmusic...@mail.bg

--- Comment #4 from Dr. Chapatin  ---
*** Bug 397165 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Jaime Torres]

https://bugs.kde.org/show_bug.cgi?id=368104

Jaime Torres  changed:

   What|Removed |Added

 CC||jtam...@gmail.com

--- Comment #3 from Jaime Torres  ---
Detailed code analysis:

In PreviewJobPrivate::getOrCreateThumbnail, as the KFileItem item localPath()
is empty, the copy takes place.
And a KFileItem has localPath() empty if there is no
KIO::UDSEntry::UDS_LOCAL_PATH in the UDSEntry.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=368104

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368104

s...@kabelfunk.de changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||s...@kabelfunk.de
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from s...@kabelfunk.de ---
I can confirm mostly comment#1, but my test case is a little bit different.

Test case:
1. Five mpeg files trashed, each ~400-1200 MB.
2. go to trash:/ in dolphin.
3. Open a second dolphin window to see the free space information (of /tmp) in
the status bar.
4. Turn on preview (in the first dolphin window).
5. All mpeg files will be copied sequentially to /tmp, preview generated and
deleted afterwards.
6. You can watch the free space information going down and up dependent of the
size of the trashed files.

Re-trigger the test case: (the preview pictures are cached.)
Restore the files, rename them and then start with #1 again.

Plasma: 5.12.3
Framework: 5.44.0
Application: 17.12.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 368104] files/folders in trash get copied to /tmp while previews are generated

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368104

--- Comment #1 from Wolfgang Bauer  ---
I CC'ed the dolphin maintainers too, so that they know about the problem in
case similar bug reports get filed against dolphin.

-- 
You are receiving this mail because:
You are watching all bug changes.