[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 Nicolas Fella changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kio/commit/5e2dc5a18 ||473f47f44ec93f9c23d4aae4838 ||a77b Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #8 from Nicolas Fella --- Git commit 5e2dc5a18473f47f44ec93f9c23d4aae4838a77b by Nicolas Fella. Committed on 14/08/2022 at 18:34. Pushed by nicolasfella into branch 'master'. [kfileitemactions] Show desktop file actions more prominently For desktop files we currently show two kinds of actions in the "Actions" submenu: The actions defined by the desktop file itself and the externally provided file actions However, the two are conceptually different things. The latter operate on the desktop file itself, the former does not The former are also much more relevant in a folderview context This patch moves the desktop file's own actions out of the menu and up next to the "Open with" actions It also fixes executing those actions by not passing the file url as an argument M +27 -9src/widgets/kfileitemactions.cpp https://invent.kde.org/frameworks/kio/commit/5e2dc5a18473f47f44ec93f9c23d4aae4838a77b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/878 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 --- Comment #6 from Nicolas Fella --- The relevant code is at https://invent.kde.org/frameworks/kio/-/blob/master/src/widgets/kfileitemactions.cpp#L201 The problem is this: The actions menu is a list of externally supplied actions that can be performed on the file. So passing the file as argument when executing the action makes sense. The problem here is that we are operating on a desktop file, which itself contains a list of actions (e.g. "New tab"). We append these actions to the actions submenu. However, these actions are different to all the other actions in the sense that they should not be applied to the desktop file itself. Probably they should not be part of the actions submenu at all. Perhaps it could make sense to show them at the top of the menu, next to the Open/Open With action -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de --- Comment #5 from Nicolas Fella --- (In reply to Pit from comment #4) > Not sure if that's the same bug: Also happens with the "Application > Launcher"(*): > It now (as of 5.24.0) opens the .desktop file in kate, instead of launching > the application :(( > > (*) Not the "Application Menu" in the panel, but the "Application Launcher > Version pre0.1" that you can bind to root window mouse clicks in Desktop > Settings->Mouse Actions It's a different bug -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 Pit changed: What|Removed |Added CC||p.suetter...@royac.iac.es --- Comment #4 from Pit --- Not sure if that's the same bug: Also happens with the "Application Launcher"(*): It now (as of 5.24.0) opens the .desktop file in kate, instead of launching the application :(( (*) Not the "Application Menu" in the panel, but the "Application Launcher Version pre0.1" that you can bind to root window mouse clicks in Desktop Settings->Mouse Actions -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 417012] Launching an app shortcut through the "Actions" menu items of its context menu passes the .desktop file as an argument to the program
https://bugs.kde.org/show_bug.cgi?id=417012 Nate Graham changed: What|Removed |Added Component|Desktop Containment |general Summary|Clicking a desktop shortcut |Launching an app shortcut |through the "Actions" |through the "Actions" menu |context menu passes the |items of its context menu |.desktop file as an |passes the .desktop file as |argument to the program |an argument to the program Version|5.17.5 |git master Product|plasmashell |frameworks-kio CC||kdelibs-b...@kde.org Assignee|notm...@gmail.com |kio-bugs-n...@kde.org Target Milestone|1.0 |--- --- Comment #3 from Nate Graham --- Happens when the short is launched from Dolphin too; not sure this has to to with Plasma. Moving to KIO. -- You are receiving this mail because: You are watching all bug changes.
