[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2023-12-26 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453890

hoyt.eter...@gmail.com changed:

   What|Removed |Added

 CC||hoyt.eter...@gmail.com

--- Comment #29 from hoyt.eter...@gmail.com ---
The icon is shown regardless of /etc/fstab mount options, and doesn't even ask
for privilege elevation password. 
Maybe it should be shown only for internal drives that have user and users
mount options in fstab?
But it ignores nouser mount option. 
If I am trying to use mount and umount on a drive with nouser option in fstab,
I get:
mount: /mount/point: must be superuser to use mount.
umount: /mount/point: must be superuser to unmount.
But under the same user, in dolphin, I am still able to mount and unmount the
same device.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2023-11-04 Thread Julius R.
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #28 from Julius R.  ---
I also still experience this bug. When mounting a drive with $ veracrypt or $
cryptsetup, the drive will be shown with the unmount icon. Unmounting an
encrypted drive accidently can cause serious data corruption! This icon MUST
go.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2023-01-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #27 from yiz...@kulodgei.com ---
(In reply to yizel7 from comment #19)
> (In reply to Kai Uwe Broulik from comment #17)
> > KIO 5.95 should have this fix. So it seems something else is missing. What
> > partition / drive / device is still showing an Eject button for you? 
> > 
> > Can you check solid-hardware5 list for your drive(s) and provide the output
> > of solid-hardware5 details for each of them, and perhaps your list of 
> > mounts.
> 
> In addition to the details I added in Comment 18 I checked the details for
> those 3 drives and they all say removable false and hotpluggable false so I
> would assume that means the unmount shouldn't be showing.
> 
>   StorageDrive.bus = 'Sata'  (0x4)  (enum)
>   StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
>   StorageDrive.removable = false (bool)
>   StorageDrive.hotpluggable = false (bool)
>   StorageDrive.inUse = true (bool)
> 
>   Block.device = '/dev/nvme1n1' (string)
>   StorageDrive.bus = 'Platform'  (0x5)  (enum)
>   StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
>   StorageDrive.removable = false (bool)
>   StorageDrive.hotpluggable = false (bool)
>   StorageDrive.inUse = true (bool)
> 
>   Block.device = '/dev/nvme0n1' (string)
>   StorageDrive.bus = 'Platform'  (0x5)  (enum)
>   StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
>   StorageDrive.removable = false (bool)
>   StorageDrive.hotpluggable = false (bool)
>   StorageDrive.inUse = true (bool)

I still have this issue and icons for all 3 of my internal drives that are
inside my laptop that can not be physically removed without screws and are
marked false for removable and hotpluggable.

Operating System: Arch Linux
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 6.0.17-hardened1-1-hardened (64-bit)
kio 5.101.0-1
kio-extras 22.12.0-1
kio-fuse 5.0.1-1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-09-01 Thread jackdinn
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #26 from jackdinn  ---
(In reply to Norbert from comment #25)
> Additionally on my system the icon is not shown but I can click it, and it
> asks for password.
> 
> KDE Plasma Version: 5.25.2
> KDE Frameworks Version: 5.95.0
> Qt Version: 5.15.5

Yes, and the tooltip is also still there if you hover in the area where the
button/icon used to be. (well is on my KDE Dolphin). So the umount button is
actually still there, it's just hidden??

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-09-01 Thread Norbert
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #25 from Norbert  ---
Additionally on my system the icon is not shown but I can click it, and it asks
for password.

KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-08-27 Thread Steve Vialle
https://bugs.kde.org/show_bug.cgi?id=453890

Steve Vialle  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||stev...@orcon.net.nz
 Resolution|FIXED   |---

--- Comment #24 from Steve Vialle  ---
> KIO 5.95 should have this fix.

Nope, still doing silly things as of KIO 5.97.0
Presumably mdraid volumes are "hot pluggable" as well these days?

If anyone can think of any reason at all I would want to unmount /dev/md127
(mounted by-label in fstab) from dolphin, I'm all ears... Suddenly it has an
unmount button here.
I mean, I'm never going to even unmount it, let alone "eject" it (as suggested
by the icon). The latter would mean stopping the array (which can't be done
from KDE / GUI anyway) and physically pulling the disks...

As far as I can deduce, at least empirically, the real logic (if you can call
it that) here is that *anything* mounted to /mnt or /media that is not a
network mount winds up with this silly button.
How's about only showing it for stuff the *user* can reasonably unmount? If
it's in fstab and doesn't have the "user" mount option (yes, that means
tracking by-label and by-uuid etc. as well) then it's a system mount, leave it
alone.

$ solid-hardware5 details '/org/freedesktop/UDisks2/block_devices/md127'
udi = '/org/freedesktop/UDisks2/block_devices/md127'
  parent = '/' (string)
  vendor = '' (string)
  product = '' (string)
  description = 'rust' (string)
  icon = 'drive-harddisk' (string)
  Block.major = 9  (0x9)  (int)
  Block.minor = 127  (0x7f)  (int)
  Block.device = '/dev/md127' (string)
  StorageAccess.accessible = true (bool)
  StorageAccess.filePath = '/mnt/rust' (string)
  StorageAccess.ignored = true (bool)
  StorageAccess.encrypted = false (bool)
  StorageVolume.ignored = false (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'ext4' (string)
  StorageVolume.label = 'rust' (string)
  StorageVolume.uuid = 'da6b28d7-799f-4667-a2cf-0021b47df500' (string)
  StorageVolume.size = 4000650690560  (0x3a3795d)  (qulonglong)

$ grep rust /etc/fstab 
LABEL=rust  /mnt/rust   ext4noatime
0 4

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-08-23 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #23 from Frank Steinmetzger  ---
(In reply to Kai Uwe Broulik from comment #22)
> Can you check in solid-hardware5 list for those drives and then post the
> output of solid-hardware5 details for each one of these.

I used to have most of my internal SATA-drives set to hotpluggable in the BIOS,
mostly because I have a dual hotswap bay installed. It is currently not in use,
though.

Nowadays, all the partitions shown on my screenshot reside on an NVMe drive,
which by definition is not hot-pluggable, AFAIK.

Before I post the whole wall of text from solid-hardware5, here is a summary, I
hope the formatting is retained:

> Device   Name  Mount pointRemove button shown
> 
> nvme 1   boot  /boot  entry not shown in Dolphin
> nvme 3   windows   /mnt/windows   no
> nvme 4 (LVM base partition)   no
> dm-1 arch  /  no
> dm-2 home  /home  no
> dm-3 gentoo/mnt/gentooyes
> dm-4 data  /mnt/data  yes

Looking at your list of criteria again, I think I may see the problem: my
affected partitions all reside on LVM and not on NVMe directly (like the
unaffected windows partition). So maybe solid knows that the NVMe drive is not
hot-pluggable, but does not know this about LVM. Or maybe it even assumes that
LVM *is* hot-pluggable (except for / and $HOME).


The boot partition (not shown in Dolphin, possibly due to
StorageVolume.ignored?):

solid-hardware5 details '/org/freedesktop/UDisks2/block_devices/nvme0n1p1'
udi = '/org/freedesktop/UDisks2/block_devices/nvme0n1p1'
  parent =
'/org/freedesktop/UDisks2/drives/Samsung_SSD_970_EVO_Plus_2TB_xxx'
(string)
  vendor = '' (string)
  product = 'Samsung SSD 970 EVO Plus 2TB' (string)
  description = 'EFI system partition' (string)
  icon = 'drive-harddisk' (string)
  Block.major = 259  (0x103)  (int)
  Block.minor = 1  (0x1)  (int)
  Block.device = '/dev/nvme0n1p1' (string)
  StorageAccess.accessible = true (bool)
  StorageAccess.filePath = '/boot' (string)
  StorageAccess.ignored = true (bool)
  StorageAccess.encrypted = false (bool)
  StorageVolume.ignored = true (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'vfat' (string)
  StorageVolume.label = 'EFI system partition' (string)
  StorageVolume.uuid = 'e875-7c1b' (string)
  StorageVolume.size = 104857600  (0x640)  (qulonglong)


The windows partition at /mnt/windows (shown without remove button):

solid-hardware5 details '/org/freedesktop/UDisks2/block_devices/nvme0n1p3'
udi = '/org/freedesktop/UDisks2/block_devices/nvme0n1p3'
  parent =
'/org/freedesktop/UDisks2/drives/Samsung_SSD_970_EVO_Plus_2TB_xxx'
(string)
  vendor = '' (string)
  product = 'Samsung SSD 970 EVO Plus 2TB' (string)
  description = 'Windows' (string)
  icon = 'drive-harddisk' (string)
  Block.major = 259  (0x103)  (int)
  Block.minor = 3  (0x3)  (int)
  Block.device = '/dev/nvme0n1p3' (string)
  StorageAccess.accessible = true (bool)
  StorageAccess.filePath = '/mnt/windows' (string)
  StorageAccess.ignored = true (bool)
  StorageAccess.encrypted = false (bool)
  StorageVolume.ignored = false (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'ntfs' (string)
  StorageVolume.label = 'Windows' (string)
  StorageVolume.uuid = '3c0ec7340ec6e64c' (string)
  StorageVolume.size = 20971520  (0x30d400)  (qulonglong)


My system’s root partition (LVM-lv "arch"):

solid-hardware5 details '/org/freedesktop/UDisks2/block_devices/dm_2d1'
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d1'
  parent = '/' (string)
  vendor = '' (string)
  product = '' (string)
  description = 'arch' (string)
  icon = 'drive-harddisk-root' (string)
  Block.major = 254  (0xfe)  (int)
  Block.minor = 1  (0x1)  (int)
  Block.device = '/dev/dm-1' (string)
  StorageAccess.accessible = true (bool)
  StorageAccess.filePath = '/' (string)
  StorageAccess.ignored = true (bool)
  StorageAccess.encrypted = false (bool)
  StorageVolume.ignored = false (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'ext4' (string)
  StorageVolume.label = 'arch' (string)
  StorageVolume.uuid = '59056c42-c6f3-4975-a56f-d86e64c003bb' (string)
  StorageVolume.size = 47244640256  (0xb)  (qulonglong)


The home partition (LVM-lv "home"):

solid-hardware5 details '/org/freedesktop/UDisks2/block_devices/dm_2d2'
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d2'
  parent = '/' (string)
  vendor = '' (string)
  product = '' (string)
  description = 'home' (string)
  icon = 'drive-harddisk' (string)
  Block.major = 254  (0xfe)  (int)
  Block.minor = 2  (0x2)  (int)
  Block.device = '/dev/dm-2' (string)
  StorageAccess.accessible = true (bool)
  StorageAccess.filePath = '/home' (string)
  StorageAccess.ignored = true (bool)
  StorageAccess.encrypted = false (bool)
  

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-08-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #22 from Kai Uwe Broulik  ---
Can you check in solid-hardware5 list for those drives and then post the output
of solid-hardware5 details for each one of these.

The mount icon is shown if:
* it is mounted
* and it isnt / or where your $HOME is
* and it is not a network share (nfs/cifs mount in fstab)
* and there is a drive associated with it that is hotpluggable or removable (by
definitions of hotpluggable and removable which I would need to look up)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-08-23 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=453890

Frank Steinmetzger  changed:

   What|Removed |Added

 CC||dev-...@felsenfleischer.de

--- Comment #21 from Frank Steinmetzger  ---
Created attachment 151529
  --> https://bugs.kde.org/attachment.cgi?id=151529=edit
Screenshot

Having just upgraded to 22.08, I came to this bug from Nate Graham’s blog,
where he links to here and states that ‘The “Eject” button next to mounted
disks in Dolphin’s Places panel no longer appears for internal disks and those
manually added to your /etc/fstab file’.

Sadly, I must disagree to his statement.

I have several partitions on my internal NVMe drive, all of which have an
auto-mount entry in fstab, and two of them have a remove button. Interestingly,
they are both mounted under /mnt (data and gentoo). But that in itself is not
the cause, because there is a third, /mnt/windows, and it has no remove button.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-06-29 Thread jackdinn
https://bugs.kde.org/show_bug.cgi?id=453890

jackdinn  changed:

   What|Removed |Added

 CC||j...@jackdinn.co.uk

--- Comment #20 from jackdinn  ---
I was just wondering if this might be the cause of my loss of Umount icon for
all my network mounts? I do need them.

https://forum.manjaro.org/t/where-did-the-mount-unmount-icons-on-dolphin-go/115426

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-06-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #19 from yiz...@kulodgei.com ---
(In reply to Kai Uwe Broulik from comment #17)
> KIO 5.95 should have this fix. So it seems something else is missing. What
> partition / drive / device is still showing an Eject button for you? 
> 
> Can you check solid-hardware5 list for your drive(s) and provide the output
> of solid-hardware5 details for each of them, and perhaps your list of mounts.

In addition to the details I added in Comment 18 I checked the details for
those 3 drives and they all say removable false and hotpluggable false so I
would assume that means the unmount shouldn't be showing.

  StorageDrive.bus = 'Sata'  (0x4)  (enum)
  StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
  StorageDrive.removable = false (bool)
  StorageDrive.hotpluggable = false (bool)
  StorageDrive.inUse = true (bool)

  Block.device = '/dev/nvme1n1' (string)
  StorageDrive.bus = 'Platform'  (0x5)  (enum)
  StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
  StorageDrive.removable = false (bool)
  StorageDrive.hotpluggable = false (bool)
  StorageDrive.inUse = true (bool)

  Block.device = '/dev/nvme0n1' (string)
  StorageDrive.bus = 'Platform'  (0x5)  (enum)
  StorageDrive.driveType = 'HardDisk'  (0x0)  (enum)
  StorageDrive.removable = false (bool)
  StorageDrive.hotpluggable = false (bool)
  StorageDrive.inUse = true (bool)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-06-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #18 from yiz...@kulodgei.com ---
(In reply to Kai Uwe Broulik from comment #17)
> KIO 5.95 should have this fix. So it seems something else is missing. What
> partition / drive / device is still showing an Eject button for you? 
> 
> Can you check solid-hardware5 list for your drive(s) and provide the output
> of solid-hardware5 details for each of them, and perhaps your list of mounts.

I have 3 internal drives in my laptop. 1 SATA and 2 NVMe. I am still very new
to Linux so I don't know if this is what you needed but I ran 'solid-hardware5
list' and can see my drives there:

udi = '/org/freedesktop/UDisks2/block_devices/nvme0n1'
udi = '/org/freedesktop/UDisks2/block_devices/nvme0n1p2'
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d1'
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d2'
udi = '/org/freedesktop/UDisks2/block_devices/sda1'
udi = '/org/freedesktop/UDisks2/block_devices/nvme1n1'
udi = '/org/freedesktop/UDisks2/block_devices/sda'
udi = '/org/freedesktop/UDisks2/block_devices/nvme0n1p1'
udi = '/org/freedesktop/UDisks2/block_devices/dm_2d0'
udi = '/org/freedesktop/UDisks2/drives/WDC__WDS100T2B0A_*_**'
udi = '/org/freedesktop/UDisks2/drives/KINGSTON_SNVS1000GB_'
udi = '/org/freedesktop/UDisks2/drives/WDBGMP0010BNC_WRSN_**'
(I masked the serials for privacy)

I wonder if maybe they are listed with unmount icons because they are the
unencrypted LUKS partitions? They used to not have the eject button but a
little over a month ago that changed. Did your fix include drives that would be
unencrypted? Like maybe the encrypted version would not show eject but when you
unencrypt it does.

Here is my mounts:
mount | grep 'btrfs'
/dev/mapper/cryptlvm on / type btrfs
(rw,relatime,ssd,space_cache=v2,subvolid=5,subvol=/)
/dev/mapper/luks-zy2h24g1-74n1-6362-hy56-a2ursf2ba7hc on /mnt/Documents type
btrfs
(rw,nosuid,nodev,relatime,ssd,space_cache=v2,subvolid=5,subvol=/,x-gvfs-show)
/dev/mapper/luks-hbv25egs-67b4-7ahe-c378-52742a0y2153 on /mnt/Roms type btrfs
(rw,nosuid,nodev,relatime,ssd,space_cache=v2,subvolid=5,subvol=/,x-gvfs-show)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-06-17 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #17 from Kai Uwe Broulik  ---
KIO 5.95 should have this fix. So it seems something else is missing. What
partition / drive / device is still showing an Eject button for you? 

Can you check solid-hardware5 list for your drive(s) and provide the output of
solid-hardware5 details for each of them, and perhaps your list of mounts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-06-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #16 from yiz...@kulodgei.com ---
I cannot tell if this bug fix has been sent out yet or not? I did a major
upgrade in Arch today to 5.25.0 and framework 5.95.0 and I am still seeing the
unmount icons in Dolphin for my internal laptop drives that will never be
removed. Your help is appreciated! I am still new to the whole KDE invent page
so I can't tell when this fix was supposed to go out.

kio 5.95.0-1
kio-extras 22.04.2-1
kio-fuse 5.0.1-1
dolphin 22.04.2-1
frameworkintegration 5.95.0-1
plasma-framework 5.95.0-2

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-26 Thread Julius R.
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #15 from Julius R.  ---
Absolutely impressive! Thanks to all involved

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-26 Thread Thomas
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #14 from Thomas  ---
Thank You..!!
To everyone - for listening to the end users, responding, and getting a fix out
so quickly.
Yet another reason KDE/Plasma rocks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453890

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.95

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-24 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=453890

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/69b077708
   ||99098afd879f7dc1ed5f519f1df
   ||ba7d

--- Comment #13 from Kai Uwe Broulik  ---
Git commit 69b07770899098afd879f7dc1ed5f519f1dfba7d by Kai Uwe Broulik.
Committed on 24/05/2022 at 13:44.
Pushed by ngraham into branch 'master'.

[KFilePlacesView] Show inline eject button only for removable drives

Otherwise it clutters a list of internal drives that are never meant
to be unmounted, and potentially not even allowed to be, with eject icons.

Also, we currently only show fixed network shares (e.g. through fstab),
which are usually not meant to be unmounted by the user.

Storage without a drive (e.g. a mounted ISO image) keeps its eject inline
button, too.

Triggering an unmount from the contextmenu remains possible (except for
Root and Home, as before).

M  +16   -0src/filewidgets/kfileplacesitem.cpp
M  +2-0src/filewidgets/kfileplacesitem_p.h
M  +11   -0src/filewidgets/kfileplacesmodel.cpp
M  +9-0src/filewidgets/kfileplacesmodel.h
M  +1-1src/filewidgets/kfileplacesview.cpp

https://invent.kde.org/frameworks/kio/commit/69b07770899098afd879f7dc1ed5f519f1dfba7d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-23 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=453890

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #12 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/849

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Julius R.
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #11 from Julius R.  ---
(In reply to Thomas from comment #10)
> So I guess the question/rub for me - is why did this have to change..?? Put
> the code that handled this back the way it was.
> Seemed to work perfectly before. So why was it "fixed".
> 
> If I want to unmount a physical drive attached to a SATA cable screwed into
> the case of the computer and mounted via FSTAB - I should need to do more
> that just click an always visible Unmount icon cluttering up the view in
> Dolphin. Whether in fact clicking that Icon intentionally or accidentally
> will or will not cauise additional dialogue to prevent the Unmount.
> 
> If I plug a Thumb Drive or some other USB Storage device, with no
> over-riding FSTAB entry to make it a "permanent" drive - then an Unmount
> Icon makes absolute sense.
> 
> Just like it worked a few days ago.
> 
> Thanks!

I second every word of that comment! As can be seen in my bug duplicate above,
this little changed caused several - even critical - disturbances. A solid
drive, that is integrated in the system (like network drives in a company)
should not be unmountable with a single click. Imho :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Thomas
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #10 from Thomas  ---
So I guess the question/rub for me - is why did this have to change..?? Put the
code that handled this back the way it was.
Seemed to work perfectly before. So why was it "fixed".

If I want to unmount a physical drive attached to a SATA cable screwed into the
case of the computer and mounted via FSTAB - I should need to do more that just
click an always visible Unmount icon cluttering up the view in Dolphin. Whether
in fact clicking that Icon intentionally or accidentally will or will not
cauise additional dialogue to prevent the Unmount.

If I plug a Thumb Drive or some other USB Storage device, with no over-riding
FSTAB entry to make it a "permanent" drive - then an Unmount Icon makes
absolute sense.

Just like it worked a few days ago.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453890

Nate Graham  changed:

   What|Removed |Added

 CC||c3i8zv...@mozmail.com

--- Comment #9 from Nate Graham  ---
*** Bug 453894 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #8 from Kai Uwe Broulik  ---
I don't know if we can know if the current user would be allowed to unmount it,
i.e. don't shows the eject button if clicking it would prompt for root
credentials.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Thomas
https://bugs.kde.org/show_bug.cgi?id=453890

--- Comment #7 from Thomas  ---
Created attachment 148940
  --> https://bugs.kde.org/attachment.cgi?id=148940=edit
Internal HDD FSTAB mounted Drives now show unmount icons

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-18 Thread Thomas
https://bugs.kde.org/show_bug.cgi?id=453890

Thomas  changed:

   What|Removed |Added

 CC||onethom...@comcast.net

--- Comment #6 from Thomas  ---
Apologies up front if I am posting incorrectly here - first time, but wanted to
comment on this issue.

Was this an itentional change or a bug?
I vote as well that it is an undesirable change.

Yesterday the 3 internal HDD drives (SDB1, SDC1, SDD1) that are mounted via
FSTAB at boot did not show an unmount Icon in Dolphin.
Did all the availalbe Manjaro KDE updates this morning.
Now the 3 internal HDD drives storing media that are never intended to be
removed or unmounted in the Tower do.
It is both functionally and asthetically undersirable and unnecessary for the
Icons to be there.

This my be (probably is) my misunderstanding - but wasn't one of the benefits
of entering drives into FSTAB to get them set to a static mount point/location?
Seems counterintuitive/confusing to now show an unmount Icon for internal
drives mounted via FSTAB.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453890

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
  Component|panels: folders |Places
 Status|REPORTED|CONFIRMED
Summary|Umount icon shown on|Umount icon unnecessarily
   |internal drives |shown for internal drives
Product|dolphin |frameworks-kio
 CC||kdelibs-b...@kde.org,
   ||n...@kde.org
Version|22.04.0 |5.93.0
   Assignee|dolphin-bugs-n...@kde.org   |kio-bugs-n...@kde.org

--- Comment #5 from Nate Graham  ---
Thanks for triaging, Guilherme. I was going to ask that very question. :) 

It sounds like the problem is "it's visual clutter that could potentially lead
to unintentional unmounts".

I think we can consider hiding the unmount button for internal disks, either
optionally or always.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

2022-05-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=453890

Nate Graham  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

-- 
You are receiving this mail because:
You are watching all bug changes.