[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 Dan Jensen changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #7 from Dan Jensen --- This was fixed in https://phabricator.kde.org/R304:301fe73569ba9dbd1f80398fd616d8755accda15 Fix semantics for ghns_exclude After much discussion on the topic, it came to light that the specific grammar used for the default tag in KNSCore was incorrect, as it was an action verb (rather than an adjective the way the metadata tags are supposed to be). While this does mean that previous versions of Frameworks will not have the filtering functionality by default, it is otherwise non-invasive and causes no side effects apart from the server-suggested filtering working. BUG: 402888 Differential Revision: https://phabricator.kde.org/D18038 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 --- Comment #6 from Dan Jensen --- Related review: https://phabricator.kde.org/D18038 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 --- Comment #5 from Dan Jensen --- So, turns out that this is a deeper issue after all. Simply put, the problem is that there are semantic issues, which given this is meta data becomes very important to get fixed. So, what will happen next is that i whip up a patch to fix the client's expectations. The result will be that older versions of Frameworks will not have items excluded, but future metadata will be more consistent (in short, the metadata should not be action verbs - for a specific example, (ghns_)excluded rather than (ghns_)exclude). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 --- Comment #4 from Dan Jensen --- Right, found the problem. The OCS server is exporting the exclusion tag as "ghns_excluded" rather than the expected "ghns_exclude", and so it is entirely ignored. The server team is aware of this, and i'll close this as fixed once it has, in fact, been fixed :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 Dan Jensen changed: What|Removed |Added Ever confirmed|0 |1 Assignee|jpwhit...@kde.org |ad...@leinir.dk Status|REPORTED|CONFIRMED --- Comment #3 from Dan Jensen --- So, the plot thickens. We are now at a point where i can confirm that there is indeed a problem and that items are not being excluded, even when the ocs data says it should be. Taking and poking, shall report when i work out what's going on. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 --- Comment #2 from Dan Jensen --- As a test (because the item is already excluded by other means) i just tried to mark https://share.krita.org/p/1207357/ as excluded, and was informed by the site that it was successfully excluded. I just went back to check again, and it looks like that was not entirely true. Looks like we've probably got a bit of a server issue here... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 Dan Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #1 from Dan Jensen --- Could you check and make sure this is still marked as ghns-excluded for you? Just looked here, and it seems not to be excluded for me... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 402888] ghns_exclude tagged items are not actually excluded
https://bugs.kde.org/show_bug.cgi?id=402888 Nate Graham changed: What|Removed |Added CC||lei...@leinir.dk -- You are receiving this mail because: You are watching all bug changes.
