[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-09-15 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=417510

Alexander Lohnau  changed:

   What|Removed |Added

   Version Fixed In|5.69|5.75
 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/kne |https://invent.kde.org/fram
   |wstuff/f1dcbddf12ea44a13963 |eworks/knewstuff/commit/28f
   |ce800223a2e683b2617d|254aa6bdf5336f9b4a280f33577
   ||d5397fdcf8
 Status|REOPENED|RESOLVED

--- Comment #22 from Alexander Lohnau  ---
Git commit 28f254aa6bdf5336f9b4a280f33577d5397fdcf8 by Alexander Lohnau.
Committed on 15/09/2020 at 16:52.
Pushed by alex into branch 'master'.

Fix updating of entry if version number is empty

The status was set to installed and then the values were not updated.
FIXED-IN: 5.75

M  +5-9src/core/installation.cpp

https://invent.kde.org/frameworks/knewstuff/commit/28f254aa6bdf5336f9b4a280f33577d5397fdcf8

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-09-15 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #21 from Alexander Lohnau  ---
See https://invent.kde.org/frameworks/knewstuff/-/merge_requests/54 for the
fix.

It seems that the most icons were affected by this bug, because the authors
don't provider version numbers and the modification date does not get persisted
as it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-09-07 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #20 from Alexander Lohnau  ---
I can reproduce this. From the logs it seems like the entry got downloaded.
This will need some more debugging (have not that time right now to do this,
sorry).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-09-07 Thread Alexander Lohnau
https://bugs.kde.org/show_bug.cgi?id=417510

Alexander Lohnau  changed:

   What|Removed |Added

 CC||alexander.loh...@gmx.de

--- Comment #19 from Alexander Lohnau  ---
>Why would  There is simply no easy way to update and never has been. I only 
>raised the issue as updating any widget is broken now.
The widgets are now updatable, that has been tracked in BUG 424429

@Patrick Silva All the bugs you linked are resolved. So hopefully we can
resolve this one too :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #18 from Patrick Silva  ---
I have never seen GHNS feature working well.
The old system is also buggy.

https://bugs.kde.org/show_bug.cgi?id=405186
https://bugs.kde.org/show_bug.cgi?id=420312
https://bugs.kde.org/show_bug.cgi?id=414570
https://bugs.kde.org/show_bug.cgi?id=423055

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #17 from Piotr Mierzwinski  ---
(In reply to Martin from comment #15)
> Yeah, the entire widget update process has serious usability issues.
> Currently the process looks like this: 
> 1. Right click on panel and click "Add Widgets"
> 2. Click on "Get new widgets..."
> 3. Download New Plasma widgets
> 4. Click on "Installed"
> 5. You will realize that "Search" is inactive, that is, broken. 
> 6. You click on "Most downloads"
> 7. Search for the widget you want to update. 
> 8. You will realize that you cannot find all widgets in this way. 
> 9. You are only able to find widgets which are listed under "Most downloads"
> 10. Click on "Install"
> 11. You will realize that the "Install" button may occasionally change to
> "Installing", sometimes it simply remains at "Install" despite you having
> clicked it. 
> 12. You wait forever, nothing happens. 
> 13. You restart your laptop.
> 14. You check on a widget to see if it has updated and realize that it
> failed to update. 
> 15. You start process 1) to 12) again. By the time you reach 13) you think
> that either you switch to GNOME or you help the Plasma guys out with
> establishing guidelines on what usability is. Without any proper KDE Human
> Interface Guidelines, any attempt at improving usability is but a futile
> attempt. Let's just fix the update process for now but for anyone who reads
> this, we need a Plasma revolution for this to work properly. 
> 
> 
> Why would  There is simply no easy way to update and never has been. I only
> raised the issue as updating any widget is broken now. Not sure when this
> regression was introduced but it must have been before 5.18.5.

As far as I remember new version "Get New..." doesn't work correctly from very
first its release. 
Please consider that in KDE/Plasma was correctly working widget (including
update). Maybe this widget was not so pretty and not so usable and so human
readable, but has one big advantage - was working! Only this previous version
wasn't based on QtQuick framework.
If you want to know how looked previous version then open "System Settings ->
Application Style -> Windows Decorations -> Gen New Window"

I think you don't need to switch to GNOME just because this issue.
There is some ugly work around for update not working well. I mean manually
update. For example you remove some addon for example icons set, try to find it
in "Get New ..."  and just install what you found. Of course better is not
remove only just rename some package (in file system).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #16 from Martin  ---
To add to my previous comment: I actually wonder to what extent it makes sense
to fix this. The best way may be to write this from scratch and provide a way
to update widgets that actually makes sense. My suggestion here would be:
Right-click on a widget in the widget overview on the left side, click update.
Done!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #15 from Martin  ---
Yeah, the entire widget update process has serious usability issues. Currently
the process looks like this: 
1. Right click on panel and click "Add Widgets"
2. Click on "Get new widgets..."
3. Download New Plasma widgets
4. Click on "Installed"
5. You will realize that "Search" is inactive, that is, broken. 
6. You click on "Most downloads"
7. Search for the widget you want to update. 
8. You will realize that you cannot find all widgets in this way. 
9. You are only able to find widgets which are listed under "Most downloads"
10. Click on "Install"
11. You will realize that the "Install" button may occasionally change to
"Installing", sometimes it simply remains at "Install" despite you having
clicked it. 
12. You wait forever, nothing happens. 
13. You restart your laptop.
14. You check on a widget to see if it has updated and realize that it failed
to update. 
15. You start process 1) to 12) again. By the time you reach 13) you think that
either you switch to GNOME or you help the Plasma guys out with establishing
guidelines on what usability is. Without any proper KDE Human Interface
Guidelines, any attempt at improving usability is but a futile attempt. Let's
just fix the update process for now but for anyone who reads this, we need a
Plasma revolution for this to work properly. 


Why would  There is simply no easy way to update and never has been. I only
raised the issue as updating any widget is broken now. Not sure when this
regression was introduced but it must have been before 5.18.5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #14 from Piotr Mierzwinski  ---
(In reply to Martin from comment #13)
> Did you try updating any widgets?

I think I updated Colors in the past (after fix) and passed well.
Today I updated one set of Cursors and passed well.
BTW.
Option "Updateable" is a bit not clear.
Firstly I thought here I found all widgets/packages to update, but I was wrong.
Today I discovered that after update one package (here one set of Cursors) this
one appears in "Updateable". 
Please notice that potentially all widges/packages are able to be updated.
I don't know what I should expect to find in this option.

Issue I described that "Get New..." is not able to recognize that something is
already installed also I found in another category. I mean in "Colors". Here
took "first better", so "LuckyEyes" from installed already. Opened "Get New
Color...", found it with button "Install". Why? This is already installed. This
is not part of "Global Theme".

cd ~/.local/share/color-schemes
$ ls -l |grep Lucky
-rw-r--r-- 1 piotra piotra 2213 15.08.2017 17:22 LuckyEyes.colors
$ grep Name LuckyEyes.colors 
Name=LuckyEyes

The same in Plasma Style. I took for checking: "Nilium" (not part of "Global
Theme"), which I have installed. I found it with selected option "Show
Everything" (the same like for Colors) and also here found button "Install",
whereas I expected "Uninstall" and "Use". And of course it wasn't present in
"Installed only", because I have it empty.

If you need I can provide more details.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-30 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #13 from Martin  ---
Did you try updating any widgets?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-29 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #12 from Piotr Mierzwinski  ---
I noticed that in case of "Global Themes" for option "Installed only" is
showing nothing. The same in option "Updateable only". I have in local
directory ("~/.local/share/plasma/look-and-feel") couple themes. No one is
achievable in both mentioned option. Among others I have such: "Moddzik". In
option "Show 
Everything" I found it, but I cannot uninstall it. I have only option
"Install". 

Second thing is "Plasma Style". Here happens the same. I have a lot installed
styles locally ("~/.local/share/plasma/desktoptheme") and using option
"Installed only" I can see empty view. I suppose option "Updateable only"
doesn't work, as well. I'm going to check every one to find is any of them has
update or not.

Seems this still doesn't work correctly.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 5.19.2
KDE Frameworks Version: 5.71
Qt Version: 5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-29 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #11 from Martin  ---
Thanks for pointing to this bug. Besides icon theme, color scheme and global
theme, none of the widgets update. It's impossible to find duplicates (for
anyone new like me) if this bug isn't renamed to more adequately describe the
issue at hand. I'd recommend to keep my previous title or add it to this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-29 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417510

Patrick Silva  changed:

   What|Removed |Added

 CC||digitaleth...@mailbox.org

--- Comment #10 from Patrick Silva  ---
*** Bug 423656 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-06-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417510

Patrick Silva  changed:

   What|Removed |Added

Version|5.67.0  |5.71.0
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #9 from Patrick Silva  ---
This problem persists.
On my system I can't update icon theme, color scheme and global theme.
The GHNS windows apparently install the updates without any error but the same
updates are available when the GHNS windows are reopened.

Operating System: Arch Linux 
KDE Plasma Version: 5.19.0
KDE Frameworks Version: 5.71.0
Qt Version: 5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-04-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417510

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Nate Graham  ---
Let's keep this closed and tack the new failure at Bug 419959.

:(

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-04-20 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #7 from Patrick Silva  ---
(In reply to Piotr Mierzwinski from comment #6)
> Anyway I got saying nothing (for me) error like:
> "Unknown Open Collaboration Service API/error (0)."

Already reported as bug 419959

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-04-20 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #6 from Piotr Mierzwinski  ---
OK. I tried couple times and finally noticed barely visible error message. 
It appeared on bottom of window on line of combo boxes as tool tip. I didn't
notice it before because background of tool tip was transparent. I have
transparent Plasma Style, so it's correct. Only I wonder why this error was
reported in totally different way than in other KDE/Plasma applications, where
usually appears (on top or on bottom of window) as red bar with error message
which is pretty visible.
Anyway I got saying nothing (for me) error like:
"Unknown Open Collaboration Service API/error (0)."

I tried to update also in KaOS (up-to-dated). And got the same message.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-04-20 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

Piotr Mierzwinski  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #4 from Piotr Mierzwinski  ---
I'm sorry but fix seems doesn't work for me.

This time after I click 'Update' button I get animation and label "Updating..."
below. The view of icon set I want to update is grey. I waited several minutes
and nothing happened. Content of directory with this set is not changed at all.
Icon set is placed at: ~/.local/share/icons. On disct here there is enough free
space, and in / is also enough free space.
I tried to update "McMojave-circle".
I closed this window and opened again, but still can see the same: 'Updating'.
Only closing systemsettings5 application stops it.
I attach log what produced application on stdout.

Please notice I tried also to update any "Plasma Style" with the same result.

Operating System: Antergos Linux 
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2
Kernel Version: 5.6.4-arch1-1
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-6700 CPU @ 3.40GHz
Memory: 15,5 GiB of RAM

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-04-20 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=417510

--- Comment #5 from Piotr Mierzwinski  ---
Created attachment 127722
  --> https://bugs.kde.org/attachment.cgi?id=127722=edit
systemsettings output

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-03-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417510

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.69

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-03-19 Thread Dan Leinir Turthra Jensen
https://bugs.kde.org/show_bug.cgi?id=417510

Dan Leinir Turthra Jensen  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://commits.kde.org/kne
   ||wstuff/f1dcbddf12ea44a13963
   ||ce800223a2e683b2617d

--- Comment #3 from Dan Leinir Turthra Jensen  ---
Git commit f1dcbddf12ea44a13963ce800223a2e683b2617d by Dan Leinir Turthra
Jensen.
Committed on 19/03/2020 at 10:34.
Pushed by leinir into branch 'master'.

Fix update scenarios with no explicit downloadlink selected

Summary:
The old downloadwidget's update system would explicitly require a user
to pick which download item to use for updating if there was more than
one available. This work is an attempt at implementing this at the
engine level, while also allowing for there to be no requirement to
make an active choice, unless there is no way to deduce which of
the various potential download items is the one we are trying to
update.

The current heuristics are:
- If there is one downloaditem, that's what we're updating
- If there are more, first try and see if one has the precise url
  as the previously installed payload
- If that fails, check for filename matches (without the rest of
  the url)
- Only if that fails, present the user with a choice

Add an explicit update function in the QtQuick items model

Fix erroneous uses of installItem, and use updateItem for updates
in the QtQuick components

Reviewers: #knewstuff, #frameworks, #plasma, ngraham, apol,
#discover_software_store, ahiemstra

Reviewed By: ngraham, ahiemstra

Subscribers: ahiemstra, alexde, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27544

M  +5-0CMakeLists.txt
M  +83   -1src/core/engine.cpp
M  +2-2src/qtquick/qml/EntryDetails.qml
M  +2-2src/qtquick/qml/NewStuffItem.qml
M  +2-2   
src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +2-2src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
M  +2-2src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
M  +5-0src/qtquick/quickitemsmodel.cpp
M  +23   -0src/qtquick/quickitemsmodel.h

https://commits.kde.org/knewstuff/f1dcbddf12ea44a13963ce800223a2e683b2617d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-02-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417510

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|jpwhit...@kde.org   |ad...@leinir.dk

--- Comment #2 from Nate Graham  ---
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-02-27 Thread Dan Leinir Turthra Jensen
https://bugs.kde.org/show_bug.cgi?id=417510

Dan Leinir Turthra Jensen  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Dan Leinir Turthra Jensen  ---
i've submitted a patch to hopefully attempt to alleviate this issue. It turns
out that it is less than straightforward and the way the old widget did the job
was just not suitable in the general case (and especially for unattended update
situations, such as it would want to be in e.g. Discover)...
https://phabricator.kde.org/D27544

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-02-12 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417510

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 417510] Update of icons set doesn't work

2020-02-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417510

Nate Graham  changed:

   What|Removed |Added

 CC||ad...@leinir.dk,
   ||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.