[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Alexander Lohnau changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/745 ||3b03a4ecce6f51de366f84e04dd ||adae19a68b Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Version Fixed In||5.74 --- Comment #13 from Alexander Lohnau --- Git commit 7453b03a4ecce6f51de366f84e04ddadae19a68b by Alexander Lohnau. Committed on 02/09/2020 at 12:30. Pushed by alex into branch 'master'. Fix cache sync issues with QtQuick dialog The engine is reused for the QtQuick dialog, consequently the cache gets only updated once the dialog is initialized. Now the cache is updated if the RemoveDeadEntries option is selected every time every time the dialog is about to show. Also the state of the entries gets updated and with 8531bbcc the current filter rev-alidates these entries properly. FIXED-IN: 5.74 M +28 -4src/core/engine.cpp M +9-0src/core/engine.h M +1-0src/qtquick/qml/Button.qml https://invent.kde.org/frameworks/knewstuff/commit/7453b03a4ecce6f51de366f84e04ddadae19a68b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Bug Janitor Service changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #12 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/48 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #11 from Alexander Lohnau --- Can confirm. This is because the engine is reused and the removed entries are only deleted when initializing. So we would need to do this whenever the dialog gets shown. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Patrick Silva changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #10 from Patrick Silva --- it's still reproducible. 1. open system settings > Icons 2. click on "Get new icons..." button and install some icon theme 3. close "Get new icons..." window 4. hover over the just installed icon theme, click on its "Remove icon theme" button and click on "Apply" button 5. open "Get new icons..." window and set the first dropdown on bottom to "Installed only" Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.74.0 Qt Version: 5.14.2 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Alexander Lohnau changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #9 from Nate Graham --- Thank for your work on this, Dan! Good stuff. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #8 from Dan Leinir Turthra Jensen --- Git commit 84401e094669bf9322659f4423a8d8972c9de52b by Dan Leinir Turthra Jensen. Committed on 06/08/2020 at 08:04. Pushed by leinir into branch 'master'. Request that KNS cleans up its cache if there are dead entries This requires (though not hard) the code found in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/23 and the idea behind this is to clean up KNewStuff's knowledge of entries which have been deleted without telling KNewStuff about it first. This is a further step towards fixing the bug below. M +1-0kcms/icons/icons.knsrc https://invent.kde.org/plasma/plasma-workspace/commit/84401e094669bf9322659f4423a8d8972c9de52b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #7 from Dan Leinir Turthra Jensen --- Git commit c83c377ff82aab27172699cdc7da5d4e28d54d27 by Dan Leinir Turthra Jensen. Committed on 06/08/2020 at 08:02. Pushed by leinir into branch 'master'. Add a RemoveDeadEntries option for knsrc files If you set RemoveDeadEntries=true, entries whose installed files have all been deleted without going through KNewStuff will be removed from the cache. The removal will happen if, and only if, all listed files were removed, which means that if, for example, an entry was installed from archive, which was decompressed to yield multiple installed files, if even one of those files remains, the entry will remain marked as installed. This is to help work around people deleting files from underneath KNewStuff, which turns out to happen a lot with e.g. wallpapers and icons. Only CCBUGing this one, as it is an imcomplete fix for the issue, and requires intervention in the icons.knsrc file for the fix to be applied to the issue mentioned in that bug. M +8-0src/core/engine.cpp M +9-0src/downloaddialog.h https://invent.kde.org/frameworks/knewstuff/commit/c83c377ff82aab27172699cdc7da5d4e28d54d27 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #6 from Dan Leinir Turthra Jensen --- Just opened two relevant merge requests (as mentioned in comments above): https://invent.kde.org/frameworks/knewstuff/-/merge_requests/23 which exposes an option to turn on the cleanup for any knsrc which wants that functionality https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/190 which uses said option to clean up icons (as described in #c0) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #5 from Dan Leinir Turthra Jensen --- Sure, it wouldn't work for things where there is more knowledge required than a file disappearing, but it /would/ fix it for those situations where that's the problem. Since the former would require massive interventions throughout the stack, i feel like a smaller patch to fix a bunch of situations would be time well spent :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #4 from Alexander Lohnau --- > I guess we probably want to actually have a setting in knsrc to enable that > for things which don't use KPackage as well But that will only work for items where the downloaded location is the same as the location where the addon is installed. For instance if we use packagekit or an install script we would need to do the same as if we were going to uninstall the addon with the KNS dialog. Otherwise we can't be sure if the addon is properly removed. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #3 from Dan Leinir Turthra Jensen --- This is partly what the intention of the functionality that clears the cache for KPackage things was intended to help with. I guess we probably want to actually have a setting in knsrc to enable that for things which don't use KPackage as well (see core/engine.cpp:186) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Alexander Lohnau changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||alexander.loh...@gmx.de Ever confirmed|0 |1 --- Comment #2 from Alexander Lohnau --- Can confirm, if we have a look at the implementation (plasma-desktop/kcms/icons/main.cpp line 180) we see: >auto *job = KIO::del(QUrl::fromLocalFile(theme.dir()), KIO::HideProgressInfo); So we just delete the theme dir, but KNS does not know that the entry was deleted. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 Patrick Silva changed: What|Removed |Added Summary|Addons removed via KCMs are |Addons from KDE Store |still listed as installed |removed via KCMs are still |in respective GHNS window |listed as installed in ||respective GHNS window -- You are receiving this mail because: You are watching all bug changes.
