[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=375160

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Christoph Cullmann  ---
That is not totally trivial, if we add all commands, we need to ensure we
handle the removal of them, too. Otherwise we will later work on invalid
pointers.

If someone has time to work an this, patches are welcome.

https://kate-editor.org/join-us/

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=375160

--- Comment #6 from Christoph Cullmann  ---
(In reply to Jan Paul Batrina from comment #5)
> I think it makes sense since we add non-vimode commands already
> (https://invent.kde.org/frameworks/ktexteditor/-/blob/master/src/vimode/
> emulatedcommandbar/commandmode.cpp#L46), and excluding some (e.g. the char
> command) would be an annoying inconsistency since switching to non-vimode
> will be needed just to access those kate commands.
> 
> For conflicting commands, I think it would be safer to prefer the vimode
> versions if present. That means in the attached patch, I think that the kate
> commands should be added BEFORE the vimode commands since commands with the
> same string will overwrite the previous command
> (https://invent.kde.org/frameworks/ktexteditor/-/blob/master/src/vimode/
> emulatedcommandbar/commandmode.cpp#L60.
> 
> I haven't checked yet if `KateCmd::self()->commands()` has commands that
> have already been added by the previous cmds.push_back calls.

Are you interested in working on this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Jan Paul Batrina]

https://bugs.kde.org/show_bug.cgi?id=375160

--- Comment #5 from Jan Paul Batrina  ---
I think it makes sense since we add non-vimode commands already
(https://invent.kde.org/frameworks/ktexteditor/-/blob/master/src/vimode/emulatedcommandbar/commandmode.cpp#L46),
and excluding some (e.g. the char command) would be an annoying inconsistency
since switching to non-vimode will be needed just to access those kate
commands.

For conflicting commands, I think it would be safer to prefer the vimode
versions if present. That means in the attached patch, I think that the kate
commands should be added BEFORE the vimode commands since commands with the
same string will overwrite the previous command
(https://invent.kde.org/frameworks/ktexteditor/-/blob/master/src/vimode/emulatedcommandbar/commandmode.cpp#L60.

I haven't checked yet if `KateCmd::self()->commands()` has commands that have
already been added by the previous cmds.push_back calls.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=375160

Christoph Cullmann  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=375160

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org,
   ||jpmbatrin...@gmail.com

--- Comment #4 from Christoph Cullmann  ---
Hi, Jan Paul Batrina, would such a change make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[jaro]

https://bugs.kde.org/show_bug.cgi?id=375160

--- Comment #3 from jaro  ---
Hi,
sorry for so late response.
I've wrote some simple plugin in C++ to add some additional commends.

The new commands are available in normal input mode but not visible in VI mode.

They are added to command set which is not available in VI mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Simon St James]

https://bugs.kde.org/show_bug.cgi?id=375160

--- Comment #2 from Simon St James  ---
Will take a look over the weekend.  In the meantime: @jaro - can you give steps
to reproduce? I'll need this to form a regressoin test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 375160] Missing standard kate commands in VI mode

[Dominik Haumann]

https://bugs.kde.org/show_bug.cgi?id=375160

Dominik Haumann  changed:

   What|Removed |Added

 CC||kdedevel@etotheipiplusone.c
   ||om

--- Comment #1 from Dominik Haumann  ---
@Simon: Does that make sense, or can that possibly interfere with other vi
actions?

-- 
You are receiving this mail because:
You are watching all bug changes.