[frameworks-plasma] [Bug 382233] FrameSvgItem::setEnabledBorders causes fixedMargins to signal an update

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=382233

Aleix Pol  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/11c9206bf68f6
   ||e8f00d9bc41601f492d38d67f4d
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Aleix Pol  ---
Git commit 11c9206bf68f6e8f00d9bc41601f492d38d67f4d by Aleix Pol.
Committed on 16/11/2017 at 15:18.
Pushed by apol into branch 'master'.

Reduce spurious signal emissions

Summary:
We were reporting that the margins were changing whenever anything changed
in a FrameSvg, this patch makes sure we are only reporting the changes
when it actually changes.
This also fixes a binding loop in Desktop.qml from plasma-desktop.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, davidedmundson, plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D8809

M  +39   -21   src/declarativeimports/core/framesvgitem.cpp
M  +3-0src/declarativeimports/core/framesvgitem.h
M  +2-2src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/11c9206bf68f6e8f00d9bc41601f492d38d67f4d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 382233] FrameSvgItem::setEnabledBorders causes fixedMargins to signal an update

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=382233

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 382233] FrameSvgItem::setEnabledBorders causes fixedMargins to signal an update

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=382233

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.