[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2020-05-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=176537

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #14 from Nate Graham  ---
This was fixed two months ago when that patch landed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-23 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=176537

Waqar Ahmed  changed:

   What|Removed |Added

   Assignee|martin.sandsm...@kde.org|waqar@gmail.com

--- Comment #13 from Waqar Ahmed  ---
Patch submitted at: https://phabricator.kde.org/D25495

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-23 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=176537

Waqar Ahmed  changed:

   What|Removed |Added

 CC||waqar@gmail.com

--- Comment #12 from Waqar Ahmed  ---
> https://cgit.kde.org/sonnet.git/tree/src/core/guesslanguage.cpp

> It's worth nothing that trigram-based detection is a fallback codepath. We'd 
> first need to determine why the script-based detection here fails:

As far as I can understand trigram based detection isn't a fallback. It is the
first source, and if that fails Sonnet bruteforces the dictionaries for a
guess.

The script detection is working fine, but if the detected scripted doesn't have
any trigrams, no candidate languages are returned and if no candidate languages
are returned, sonnet goes ahead and checks the sample text with the 'default
language' and fails.

The solution that can fix this particular issue is quite simple. We just check
the script of the text, then we count the number of languages a particular
script has. If it has only one, like in this case, we just return that
language. The language can be more than one for latin script languages though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-14 Thread aiswarya
https://bugs.kde.org/show_bug.cgi?id=176537

--- Comment #11 from aiswarya  ---
Indeed when I set default language as Malayalam it is working. Still the
problem exist when selecting just the language from "choose dictionary".

I will try to contribute trigrams.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-08 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=176537

--- Comment #10 from Eike Hein  ---
Missing trigrams could mean that automatic language detection failed. Maybe
this is the problem. Can you try overriding it it by disabling automatic
language detection and and setting Malayalam as the default language?

If this works (as it did here), then the problem is in this code:

https://cgit.kde.org/sonnet.git/tree/src/core/guesslanguage.cpp

It's worth nothing that trigram-based detection is a fallback codepath. We'd
first need to determine why the script-based detection here fails:

https://cgit.kde.org/sonnet.git/tree/src/core/guesslanguage.cpp#n172

It's true the trigram data set doesn't have trigrams for Malayalam though which
could be worth contributing if you can:

https://cgit.kde.org/sonnet.git/tree/data/trigrams

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-04 Thread aiswarya
https://bugs.kde.org/show_bug.cgi?id=176537

aiswarya  changed:

   What|Removed |Added

 CC||aiswaryak...@gmail.com

--- Comment #9 from aiswarya  ---
I reproduced it by launching Kate from the terminal. Here is the error message:
sonnet.core: Missing trigrams for languages: QSet("he_IL", "ml_IN")

Note: I have hunspell-ml dictionary installed
OS: Mageia 7
hunspell 1.7
sonnet 5.57

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-11-03 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=176537

Eike Hein  changed:

   What|Removed |Added

 CC||h...@kde.org

--- Comment #8 from Eike Hein  ---
Created attachment 123694
  --> https://bugs.kde.org/attachment.cgi?id=123694=edit
Screenshot of frameworks+Kate from master from October

I can't reproduce this problem with the Mayalayam text file above.

Sonnet::TextBreaks was ported to QTextBoundaryFinder quite some time ago, which
shouldn't be suffering the glibc problem; glibc was patched in ~2009, too,
though.

As per the screenshot, the words are identified correctly and hunspell doesn't
return misspellings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-06-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=176537

--- Comment #7 from anim...@gmail.com ---
Created attachment 120631
  --> https://bugs.kde.org/attachment.cgi?id=120631=edit
Text file to reproduce the issue

You can use this file to troubleshoot the issue, as it contains perfectly valid
Malayalam content that should not be flagged as incorrect by the spell checker.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-06-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=176537

--- Comment #6 from anim...@gmail.com ---
Created attachment 120630
  --> https://bugs.kde.org/attachment.cgi?id=120630=edit
screenshot of Kate showing the issue

This screenshot shows clearly the issue. Malayalam dictionary is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-sonnet] [Bug 176537] Sonnet fails to do spellcheck on Indian languages

2019-06-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=176537

anim...@gmail.com changed:

   What|Removed |Added

 CC||anim...@gmail.com,
   ||kdelibs-b...@kde.org
 Ever confirmed|0   |1
   Platform|Compiled Sources|Mageia RPMs
   Assignee|z...@kde.org|martin.sandsm...@kde.org
 Status|RESOLVED|REOPENED
Version|4.1 |5.57.0
 Resolution|NOT A BUG   |---
Product|kdelibs |frameworks-sonnet
  Component|kspell  |general

--- Comment #5 from anim...@gmail.com ---
Sorry, but this is very sad to see that after more than 10 years this bug is
still happening in all KDE applications.

tested with Hunspell with Malayalam dictionary, clearly it is broken and
unusable for that language.

So I'm reopening the bug, I hope you can find out how to fix this. If it's a Qt
bug, please forward it there.

I'm adding a screenshot showing the issue, and the corresponding text file to
reproduce. Let us know if you need more info.

(reproduced using sonnet 5.57, and hunspell 1.7.0)

-- 
You are receiving this mail because:
You are watching all bug changes.