[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/gwe
   ||nview/275e9288c8b587078b3c4
   ||ff75633157a44197eba
   Version Fixed In||21.04

--- Comment #28 from Nate Graham  ---
Implemented by Antonio Prcela with
https://commits.kde.org/gwenview/275e9288c8b587078b3c4ff75633157a44197eba in
Gwenview 21.04!

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Antonio Prcela]

https://bugs.kde.org/show_bug.cgi?id=348746

Antonio Prcela  changed:

   What|Removed |Added

 CC||antonio.prc...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=348746

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #27 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/gwenview/-/merge_requests/28

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #26 from Thomas Meiner  ---
(In reply to Serpico from comment #25)
> There's an easy fix for this. Just change the color of file located here and
> problem is solved:
> /usr/share/gwenview/images/background.png

It works well! A really working workaround!
Thank you Serpico! 

Since 4 years (!) the first working solution. 

Not really a solution. Just a workaround!

The bug is not fixed, because the next update for Gwenview, will override the
edited image again. Pleas, make the Background pending on the "solid color
background" in the settings. User shouldn't need to edit images in /usr/

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Serpico]

https://bugs.kde.org/show_bug.cgi?id=348746

Serpico  changed:

   What|Removed |Added

 CC||davido...@o2.pl

--- Comment #25 from Serpico  ---
There's an easy fix for this. Just change the color of file located here and
problem is solved:
/usr/share/gwenview/images/background.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI
 Status|REOPENED|CONFIRMED
   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Huon]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #24 from Huon  ---
(In reply to Henrik Fehlauer from comment #23)
> > checkbox in the fullscreen settings popup
> I guess that could work, but I can also see people getting confused by the
> wording (because they won't notice the difference to the texture and it's
> not clear why they'd want to change the setting).

If it changed instantly, it would be pretty noticeable. It's easy to see a
change if it's happening as you click.
We could word it differently? "Pure black background" suggests the default
isn't pure black. Or could even do something like "Projector mode", though
that's a bit cryptic for my liking.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #23 from Henrik Fehlauer  ---
> checkbox in the fullscreen settings popup
I guess that could work, but I can also see people getting confused by the
wording (because they won't notice the difference to the texture and it's not
clear why they'd want to change the setting).

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Huon]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #22 from Huon  ---
Just had an idea - why don't we put a checkbox in the fullscreen settings popup
accessed with the cog icon in the autohide bar. Something like "Use black
background".

That wouldn't clutter the main settings dialog with a specific setting, and it
would only affect Fullscreen View mode, which is what people want.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #21 from Henrik Fehlauer  ---
> full screen mode doesn't need any color or texture.
Sidebar, statusbar and the toolbar on the top can also be visible, so the
reason to have the texture is still applicable.

> But why excluding the full screen mode?
That's why I proposed to make it configurable as detailed in Comment 11.

> I don't care abut browse-mode at all.
Well, other users do care about a consistent background between fullscreen
Browse and View mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #20 from Thomas Meiner  ---
(In reply to Josef Kufner from comment #15)
> In fullscreen mode, there is no need for any color or texture. Just make it
> black. The black background, surroundings, and everything will nicely fit
> with black edges of the screen. When using projector, it will project
> nothing around the image. There is no use case for any other color than
> black in fullscreen mode.

Exactly... full screen mode doesn't need any color or texture. 

As I see, in windowed mode the surrounding and backgrund black now. But why
excluding the full screen mode? Makes no seance at all. 

I don't care abut browse-mode at all. Maybe use the texture there if you like.
For browsing is Dolphin doing a good job.

But in view mode it should act the same in both: windowed and full screen. If
you set black in the setting, it should be real black in both of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #19 from Nate Graham  ---
Strange, I compiled from source on my Kubuntu machine and I see pure black in
the View mode, but in my Neon VM, I see the texture.

My vote would be to officially adopt the (accidental/unintentional/mysterious?)
behavior that I see on my Kubuntu machine and make it pure black in View mode,
but not Browse mode. The inconsistency shouldn't actually matter here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #18 from Henrik Fehlauer  ---
Not quite, the texture is used consistently in both fullscreen modes. In both
modes none of the UI shows a pure black, so when I tested using only black for
fullscreen view mode it look inconsistent and it did not feel "right".

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #17 from Nate Graham  ---
The texture only shows up in full screen *browse* mode. If you're using
Gwenview to present images on a projector, Then the only relevant thing is what
color the background is in full-screen *view* mode, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #16 from Henrik Fehlauer  ---
@Thomas: Please compile and run the patch I linked to before adding another
comment.

@Josef:
> You are mixing two things together. Windowed mode and fullscreen mode.
No, I'm not. I simply do not subscribe to the view that _every_ user is using a
projector, therefore the texture has its use cases also in fullscreen view
mode.

> In windowed mode the surroundings of the image should
> use standard window background
No, because that would be a really light grey, blending in with the toolbar
colours. Note how Dolphin uses white, but Gwenview consciously uses something
darker.

> In fullscreen mode, there is no need for any color or texture.
Fullscreen mode is the _only_ mode where the texture is used. The texture is
not used in windowed mode.

> black edges of the screen
My screen does not have purely black edges. I agree for projectors it makes
sense, so I'm in favour of the option as I said above. And even if Gwenview
displayed pure black, there would still be some light shining through, unless
you own a huge OLED wall.

> There is no use case for any other color than black in fullscreen mode.
The use case is that it looks nicer, prevents extreme contrasts and gives a
warm feel to Gwenview. Note that in almost all dark colour schemes the
background is not set to a pure black, but something ligher, for exactly that
reason.

Just open the attached PNG in Firefox: They have nearly the same UI texture in
fullscreen (and even in windowed mode). For the background of the PNG, they
even use a light grey…

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Josef Kufner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #15 from Josef Kufner  ---
You are mixing two things together. Windowed mode and fullscreen mode.

In windowed mode the surroundings of the image should use standard window
background by default and it makes sense to provide an option to change it. The
dark grey texture is quite good for thumbnails, a bit worse for image view, but
still ok.

In fullscreen mode, there is no need for any color or texture. Just make it
black. The black background, surroundings, and everything will nicely fit with
black edges of the screen. When using projector, it will project nothing around
the image. There is no use case for any other color than black in fullscreen
mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #14 from Thomas Meiner  ---
(In reply to Henrik Fehlauer from comment #13)
> > Pleas, stop to act as guardian for users!!
> If your image's background is set to transparent, that's not something we
> should touch. If you want it black, GIMP it to black.

Have you seen the images I posted on 2017-12-11? Have you?
> 
> > Just make all (really all) the backgrounds depending on the
> > existing background setting
> That won't work, because in fullscreen mode the background should be darker.

No, it just be the background colour and not lighter or darker...

> 
> > Thats exactly what I did.
> I see. Next time, please specify what options you changed. This makes is
> easier to triage the bug.

I've never asked for different background colours for the image an the
surrounding backgrund. But an option that is called "background color" should
change the backgrund colour and not exclude the full scree. That's a bug and
not a design problem. 

> 
> > This bug isn't fixed since 2015.
> Just to let you know: We work on this in our free time.

In older versions of Gwenview it used to work as expected. Why make it more
complicated then needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #13 from Henrik Fehlauer  ---
> Pleas, stop to act as guardian for users!!
If your image's background is set to transparent, that's not something we
should touch. If you want it black, GIMP it to black.

> Just make all (really all) the backgrounds depending on the
> existing background setting
That won't work, because in fullscreen mode the background should be darker.

> Thats exactly what I did.
I see. Next time, please specify what options you changed. This makes is easier
to triage the bug.

> This bug isn't fixed since 2015.
Just to let you know: We work on this in our free time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #12 from Thomas Meiner  ---
Pleas, stop to act as guardian for users!!
Some need it black others like it greyish. Let them choose the colour!

It's not about design. It's about functionality. 
I often use Gwenview to instant present images. On screen or beamer.
A coloured or greyish backgrund destroys the true colour of the image. Allays. 

Just make all (really all) the backgrounds depending on the existing background
setting. If you like it greyish, you can just change this setting...

> @Thomas:
>> Since a few versions, the image background is black.
> I guess you set the config option "Transparent background: Solid color" to 
> black.

Thats exactly what I did. "Background color" and "Transparent background:" is
on #00.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=348746

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #11 from Henrik Fehlauer  ---
@Huon: Thanks for looking into this ;)

For Browse mode, I agree that the texture should be kept. However, I tried out
a purely black background in View mode, and I don't really like it, in
particular it looks odd next to the greyish background of the sidebar and the
top bar, as well as when switching between modes.

As far as I can see, there are two problems:
1. Texture comes out as too light on some projectors.
2. Transparent background of raster image does not adapt to texture.

For #2, by pure chance we have https://phabricator.kde.org/D11630. Regarding
#1, my preference would be to make the texture colour (or rather just the V in
HSV) configurable. Effectively this would also allow to set it to black.

@Thomas:
> Since a few versions, the image background is black.
I guess you set the config option "Transparent background: Solid color" to
black.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Huon]

https://bugs.kde.org/show_bug.cgi?id=348746

Huon  changed:

   What|Removed |Added

 CC||h...@plonq.org

--- Comment #10 from Huon  ---
This is fairly easy to implement, and I think the better option is to leave
Browse view with the texture, and only make Image view have a black background.

It's probably generally a bad idea to change it without giving the option to
change it back (I'm sure someone would complain). But I also think it's not
quite worthy of an option in the Config dialog. A hidden config option perhaps?

I will implement this if we have some sort of consensus on 'how'.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #9 from Thomas Meiner  ---
This bug isn't fixed since 2015.

Since a few versions, the image background is black. But the surrounding
backgrund still isn't

See the attached images!
I opened the image "red_text.png" in Gwenview 16.12.3 in full screen mode. The
second image shows a shreenshot of Gwenview-full screen mode. 
There you can see the grayish background outside of the image. I shuld be as
back as the image backgrund itself. 
"red_text.png" contains on back at all. Most of it is transparent.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #8 from Thomas Meiner  ---
Created attachment 109325
  --> https://bugs.kde.org/attachment.cgi?id=109325=edit
Screenshot of Gewnview, mith loaded image red_text.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Thomas Meiner]

https://bugs.kde.org/show_bug.cgi?id=348746

--- Comment #7 from Thomas Meiner  ---
Created attachment 109324
  --> https://bugs.kde.org/attachment.cgi?id=109324=edit
Image to laod in Gwenview.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

Nate Graham  changed:

   What|Removed |Added

 CC||rburgstah...@freenet.de

--- Comment #6 from Nate Graham  ---
*** Bug 387801 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 348746] Background color in fullscreen mode should be pure black or else somehow user-customizable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348746

Nate Graham  changed:

   What|Removed |Added

Summary|Background color in |Background color in
   |fullscreen mode should use  |fullscreen mode should be
   |System Settings > Colors >  |pure black or else somehow
   |Tooltip Background color|user-customizable

-- 
You are receiving this mail because:
You are watching all bug changes.