[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #20 from Henrik Fehlauer  ---
Git commit 9056aa941e0d624094ef2762e9bbb705e56f753e by Henrik Fehlauer, on
behalf of Peter Mühlenpfordt.
Committed on 20/11/2017 at 16:40.
Pushed by rkflx into branch 'Applications/17.12'.

Persist path for "Copy/Move/Link To" to config file

Summary:
Additional patch to make the targetUrl persistent again.
Modified storage of dirpath only instead of filepath.
Save temporarily stored path of Copy/Move/Link To file dialogues from
ContextManager in rc-file and restore on next start.

Reviewers: rkflx

Reviewed By: rkflx

Subscribers: ngraham, dhaumann, rkflx

Differential Revision: https://phabricator.kde.org/D8785

M  +4-1app/fileoperations.cpp
M  +2-0app/mainwindow.cpp
M  +11   -0lib/contextmanager.cpp
M  +3-0lib/contextmanager.h
M  +6-0lib/gwenviewconfig.kcfg

https://commits.kde.org/gwenview/9056aa941e0d624094ef2762e9bbb705e56f753e

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362474

Nate Graham  changed:

   What|Removed |Added

 CC||mikl...@protonmail.ch

--- Comment #19 from Nate Graham  ---
*** Bug 374936 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362474

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #18 from Nate Graham  ---
It does definitely seem like bug 374936 is a duplicate of this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Peter Mühlenpfordt]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #17 from Peter Mühlenpfordt  ---
Patch is uploaded here:
https://phabricator.kde.org/D8747

Sorry, I can not confirm bug 374936 or if it's fixed by these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[DR]

https://bugs.kde.org/show_bug.cgi?id=362474

DR  changed:

   What|Removed |Added

 CC|daniel.x.r...@gmail.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=362474

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #16 from Henrik Fehlauer  ---
> Additional patch to make the targetUrl persistent
Thanks a lot! Can you confirm this fixes bug 374936?

It would be great if you could upload the patch to https://phabricator.kde.org
for review. (You'd need to register first at
https://identity.kde.org/index.php?r=registration/index, see also
https://community.kde.org/Infrastructure/Phabricator).

If that's too much of a hassle, I can do this too, but it might take me a while
to get to it and maybe you want to contribute more patches fixing some of the
low-hanging fruits in Gwenview in the future too ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Lukas Polacek]

https://bugs.kde.org/show_bug.cgi?id=362474

Lukas Polacek  changed:

   What|Removed |Added

 CC|lu...@ksp.sk|

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Peter Muehlenpfordt]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #15 from Peter Muehlenpfordt  ---
Created attachment 108775
  --> https://bugs.kde.org/attachment.cgi?id=108775=edit
Additional patch to make the targetUrl persistent

Many thanks for fixing this issue.  :-)
I added a few more lines to make the targetUrl persistent, as it used to be in
the 'original' version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362474

Christoph Feck  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||17.08.1
  Latest Commit||https://commits.kde.org/gwe
   ||nview/7be60997b7478c0bb79ae
   ||6e915600de3ac17d89e
 Resolution|--- |FIXED

--- Comment #14 from Christoph Feck  ---
Git commit 7be60997b7478c0bb79ae6e915600de3ac17d89e by Christoph Feck, on
behalf of Simon Thiel.
Committed on 18/08/2017 at 00:42.
Pushed by cfeck into branch 'Applications/17.08'.

Remember paths for Copy-To and Move-To
FIXED-IN: 17.08.1

Differential Revision: https://phabricator.kde.org/D6379

M  +12   -9app/fileoperations.cpp
M  +5-3app/fileoperations.h
M  +3-3app/fileopscontextmanageritem.cpp
M  +12   -0lib/contextmanager.cpp
M  +4-0lib/contextmanager.h

https://commits.kde.org/gwenview/7be60997b7478c0bb79ae6e915600de3ac17d89e

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362474

Christoph Feck  changed:

   What|Removed |Added

 CC||b...@londonlight.org

--- Comment #13 from Christoph Feck  ---
*** Bug 383532 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #12 from Christoph Feck  ---
https://phabricator.kde.org/D6379

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Simon]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #11 from Simon  ---
I've updated and improved the fix for the current version of the master branch
on GitHub at https://github.com/thielsn/gwenview/commits/fix_362474

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[John O'Neall]

https://bugs.kde.org/show_bug.cgi?id=362474

John O'Neall  changed:

   What|Removed |Added

 CC||jone...@alumni.duke.edu

--- Comment #10 from John O'Neall  ---
Problem persists. Very annoying if working on lots of images.

Gwenviw 17.04.0, KDE 5.33.0.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Daniel Schröter]

https://bugs.kde.org/show_bug.cgi?id=362474

Daniel Schröter  changed:

   What|Removed |Added

 CC||d.schroe...@gmx.de

--- Comment #9 from Daniel Schröter  ---
No Fix for one year :-(
I touch this bug every week.

Is it a QT problem. Should we report it there?

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362474

Christoph Feck  changed:

   What|Removed |Added

 CC||gree...@greenrd.org

--- Comment #8 from Christoph Feck  ---
*** Bug 373629 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=362474

peter_n...@web.de changed:

   What|Removed |Added

 CC||peter_n...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Lukas Polacek]

https://bugs.kde.org/show_bug.cgi?id=362474

Lukas Polacek  changed:

   What|Removed |Added

 CC||lu...@ksp.sk

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Simon via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #7 from Simon  ---
The issue was introduced when porting to QFileDialog:

https://github.com/KDE/gwenview/commit/6cd4688f7b17ede3e2c01e9b97207e0c1400325a

Re-using the pseudo URL "kfiledialog:///" apparently not
supported in QFileDialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Simon via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

Simon  changed:

   What|Removed |Added

 CC||simon.th...@gmx.de

--- Comment #6 from Simon  ---
If anyone cares, here is a workaround/hack that stores the path in a static
variable.
https://github.com/thielsn/gwenview/commit/2ae15844267de360c210ed15a41d7b315448b49b

For a real fix the path should probably be stored in QSettings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Yuriy via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

--- Comment #5 from Yuriy  ---
Same here 16.04.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Yuriy via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

Yuriy  changed:

   What|Removed |Added

 CC||yu...@my.kr.ua

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

jpelo...@yahoo.com changed:

   What|Removed |Added

 CC||jpelo...@yahoo.com

--- Comment #4 from jpelo...@yahoo.com ---
Same here.
Gwenview 15.12.3
KDE Frameworks 5.23.0
Qt 5.5.1
Kubuntu 16.04.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Daniel Rode via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

Daniel Rode  changed:

   What|Removed |Added

 CC||u...@trueuto.org

--- Comment #3 from Daniel Rode  ---
Same here
gwenview 4:15.08.3-1 (Debian)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[cippalippa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

cippalippa  changed:

   What|Removed |Added

 CC||cippali...@trashcanmail.com

--- Comment #2 from cippalippa  ---
Same here.
Ubuntu 16.04.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 362474] Copy To/Move To does not remember path any more

[Achim Bohnet via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362474

Achim Bohnet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||a...@mpe.mpg.de

--- Comment #1 from Achim Bohnet  ---
Same here.

-- 
You are receiving this mail because:
You are watching all bug changes.