https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #23 from Christoph Cullmann ---
> nvm, the commits went in after tars were created.
uf :=) sorry for the issue :/
I will first investigate the stuff here more before opening some request.
Somehow this now works for me even with my patch
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #22 from Christoph Feck ---
nvm, the commits went in after tars were created.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #21 from Christoph Feck ---
Just in case, I am also (still) monitoring all gwenview bug mails. Was the
cause for null pixmaps found? If not, I need to respin the 19.08.2 tarball.
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #20 from Christoph Cullmann ---
And I want to thank Tom for showing that my change was wrong!
Thanks for that!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #19 from Christoph Cullmann ---
I will re-investigate my issue + the "wrong" fix.
I will post a review request if I find again a workable solution.
Perhaps all is already fine after the memory corruption fix
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #18 from Nate Graham ---
I triage all new bugs filed anywhere, but hadn't gotten to today's crop of bugs
yet. :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
Nate Graham changed:
What|Removed |Added
CC||n...@kde.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #17 from Tom Moebert ---
Sry, I'm only occasionally coming here and currently don't really have time to
look at the bugs into detail.
I thought Nate receives and tracks all the gwenview bugs.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #16 from Christoph Cullmann ---
Btw., as you are interested here: Is there interest to get the gwenview bug
mails?
I think at the moment they just go to a black hole, or?
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #15 from Christoph Cullmann ---
Hmm, ok.
Thanks for the helpful debugging.
Then I got just lucky never to hit that case.
I need to retry this later at home.
I still not get why this commit shall fix then my issues at all, as if it
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #14 from Tom Moebert ---
Yes:
(gdb) print thumbnailPix.isNull()
$9 = true
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #13 from Christoph Cullmann ---
Hmm, is that a null-pixmap?
In any case, I am now confused why this did fix the rendering issues for me.
I need to try this with the correct monitor setup again.
Locally I can not get the bad rendering
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #12 from Tom Moebert ---
Thread 1 "gwenview" hit Breakpoint 1,
Gwenview::ThumbnailBarItemDelegate::sizeHint (this=0x9b3090, index=...)
at /home/tom/Programme/gwenview/lib/thumbnailview/thumbnailbarview.cpp:180
180 auto prf=
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #11 from Christoph Cullmann ---
Git commit 0bdba41e1dbc9ba48b52e43495091c43270d8be9 by Christoph Cullmann.
Committed on 09/10/2019 at 14:05.
Pushed by cullmann into branch 'master'.
Revert "fix fractional scaling"
This reverts commit
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #10 from Christoph Cullmann ---
Hmm, I am astonished.
Actually, QPixmap has a own overload "qreal devicePixelRatio"
(https://doc.qt.io/qt-5/qpixmap.html#devicePixelRatio) that overwrites the
wrong
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #9 from Christoph Cullmann ---
I see :/
The issue is: null pixmaps are broken with this, could that be?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #8 from Christoph Cullmann ---
Hmm, I tried to look how
auto prf= thumbnailPix.devicePixelRatioF();
auto pr = thumbnailPix.devicePixelRatio();
are computed internally for pixmaps.
For the that looks normally done via the ::metric
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #7 from Tom Moebert ---
For me crashes in
#4 0x77591475 in operator/ (s=..., c=0) at
/usr/include/qt5/QtCore/qsize.h:196
194 inline const QSize operator/(const QSize , qreal c)
195 {
196 Q_ASSERT(!qFuzzyIsNull(c));
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
Version Fixed In|19.08.3 |
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #6 from Christoph Cullmann ---
Git commit 2ff212adc2adfc0d50f88abdb7a312250780aa3d by Christoph Cullmann.
Committed on 09/10/2019 at 13:40.
Pushed by cullmann into branch 'Applications/19.08'.
Revert "fix fractional scaling"
This reverts
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #5 from Christoph Cullmann ---
I will revert the commit in stable just to be sure, if it is faulty, one has
more time in master to think about it.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #4 from Christoph Cullmann ---
I tried my patch with:
1) No scaling => works
2) Scaling 1.5 => works with, without unusable
3) Scaling 2.0 => works
If you can reproduce a crash, please show here, we can then revert the commit.
(especially
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
CC||tom.m...@googlemail.com
--
You are
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
Ever confirmed|0 |1
Resolution|FIXED
https://bugs.kde.org/show_bug.cgi?id=412738
--- Comment #3 from Christoph Cullmann ---
There seems to be issues with this:
https://github.com/KDE/gwenview/commit/769b6e17a0a1e46777ddc87ef1cc9ce3e8807a16#commitcomment-35426113
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
CC||cullm...@kde.org
Version Fixed In|
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
Latest Commit|https://commits.kde.org/gwe |https://commits.kde.org/gwe
https://bugs.kde.org/show_bug.cgi?id=412738
Christoph Cullmann changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
29 matches
Mail list logo
