[juk] [Bug 165899] juk take to much CPU / Power when IDLE

2021-03-24 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=165899

--- Comment #5 from Michael Pyne  ---
Git commit b64b37616f0490f60526defaf5335c4731dd41b4 by Michael Pyne.
Committed on 25/03/2021 at 01:29.
Pushed by mpyne into branch 'release/21.04'.

systemtray: Cleanups and modernization. Also a timer bugfix.

The bug: When using the track popup announcement, a timer kicks off to
tell the popup to fade out. A second timer is used to incrementally fade
the popup a bit every few milliseconds until the popup can finally be
hidden. However the first timer was never stopped, and would kick off
the fadeout sequence again, over and over, only hidden to view since the
popup is no longer visible.

This might be related to the old bug 165899 (which I tried to fix a
different way). I believe this happened in the Qt3/4 transition since
the code seems to assume the first timer was a "single shot" timer, but
it could have been wrong forever.

(cherry picked from commit 62561ad031a2c1c03f9abc266c621d83e48f6b8b)

M  +80   -84   systemtray.cpp
M  +12   -14   systemtray.h

https://invent.kde.org/multimedia/juk/commit/b64b37616f0490f60526defaf5335c4731dd41b4

-- 
You are receiving this mail because:
You are watching all bug changes.

[juk] [Bug 165899] juk take to much CPU / Power when IDLE

2021-03-21 Thread Michael Pyne
https://bugs.kde.org/show_bug.cgi?id=165899

--- Comment #4 from Michael Pyne  ---
Git commit 62561ad031a2c1c03f9abc266c621d83e48f6b8b by Michael Pyne.
Committed on 21/03/2021 at 18:19.
Pushed by mpyne into branch 'master'.

systemtray: Cleanups and modernization. Also a timer bugfix.

The bug: When using the track popup announcement, a timer kicks off to
tell the popup to fade out. A second timer is used to incrementally fade
the popup a bit every few milliseconds until the popup can finally be
hidden. However the first timer was never stopped, and would kick off
the fadeout sequence again, over and over, only hidden to view since the
popup is no longer visible.

This might be related to the old bug 165899 (which I tried to fix a
different way). I believe this happened in the Qt3/4 transition since
the code seems to assume the first timer was a "single shot" timer, but
it could have been wrong forever.

M  +80   -84   systemtray.cpp
M  +12   -14   systemtray.h

https://invent.kde.org/multimedia/juk/commit/62561ad031a2c1c03f9abc266c621d83e48f6b8b

-- 
You are receiving this mail because:
You are watching all bug changes.