[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=332358

Jonathan Marten  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-contacts/commit/4a0
   ||e5e5e4b3f96f9464fc133c85064
   ||db22b62d5e

--- Comment #34 from Jonathan Marten  ---
Git commit 4a0e5e5e4b3f96f9464fc133c85064db22b62d5e by Jonathan Marten, on
behalf of Max von Buelow.
Committed on 11/05/2022 at 17:53.
Pushed by marten into branch 'master'.

Store tags names rather than tag IDs in KContacts::Addressee.

Solves the issue that contact tags are represented as IDs in the vCard
CATEGORIES field, which leads to loss of tags when using address books across
multiple devices. This update uses tag names in favor of IDs and automatically
creates them when necessary.

"Old" tag IDs in the database are still interpreted for backward compatibility.

See https://invent.kde.org/pim/akonadi-contacts/-/merge_requests/17

Related PRs in other projects:
* https://invent.kde.org/pim/kaddressbook/-/merge_requests/17
* https://invent.kde.org/frameworks/kcontacts/-/merge_requests/33

M  +22   -2src/akonadi-contacts/plugins/categorieseditwidget.cpp
M  +4-0src/akonadi-contacts/plugins/categorieseditwidget.h

https://invent.kde.org/pim/akonadi-contacts/commit/4a0e5e5e4b3f96f9464fc133c85064db22b62d5e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=332358

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #33 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/pim/akonadi-contacts/-/merge_requests/17

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=332358

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Störm Poorun]

https://bugs.kde.org/show_bug.cgi?id=332358

Störm Poorun  changed:

   What|Removed |Added

 CC||s...@olan.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=332358

--- Comment #32 from Jonathan Marten  ---
@Rettich: It's unlikely that the patches will work wih the KF5-based kdepim -
there has been a lot of moving code around and rewriting.  They will need to be
ported; when I get the time and summon up enough courage to use the new kdepim,
then I'll look at the fix again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Rettich]

https://bugs.kde.org/show_bug.cgi?id=332358

--- Comment #31 from Rettich  ---
Btw: Does importing categories work as well with your patch? What about new
tags not yet defined in Akonadi/Baloo?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Rettich]

https://bugs.kde.org/show_bug.cgi?id=332358

Rettich  changed:

   What|Removed |Added

 CC||sebastian.rad...@gmx.de

--- Comment #30 from Rettich  ---
Hi,

is there any update on this? This seems to be still an issue for KF5.

The bad thing is, that Akonadi deletes categories from NextCloud/Owncloud when
the contact is locally modified. Thus, even if I manage categories only in
Owncloud (and devices that support them), modifying the contact from KDE means
I need to re-add categories in Owncloud.

@Jonathan: Will your patch also work with KF5?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Onno Molenkamp via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=332358

Onno Molenkamp  changed:

   What|Removed |Added

 CC||o...@flox.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Jonathan Marten via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=332358

--- Comment #28 from Jonathan Marten  ---
Created attachment 98807
  --> https://bugs.kde.org/attachment.cgi?id=98807=edit
Patch for kdepimlibs

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Jonathan Marten via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=332358

--- Comment #29 from Jonathan Marten  ---
Created attachment 98808
  --> https://bugs.kde.org/attachment.cgi?id=98808=edit
Patch for kdepim

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaddressbook] [Bug 332358] Regression: Baloo for tags messes up categories/groups when syncing with external collections (e.g. owncloud)

[Jonathan Marten via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=332358

--- Comment #26 from Jonathan Marten  ---
I've done some investigation with kdepim/kdepimlibs 4.14, although it appears
that the code is the same with the current KF5 version.

Currently there is no export or transfer of categories at all, at least with
all of those methods that use vCards.  There is this comment in
kdepimlibs./kabc/vcardtool.cpp:
// Laurent: 31 Jan 2015. Not necessary to export it. When Categories were
changed
as AkonadiTag
// nobody thought that it was break categorie support...
// => not necessary to export just tag...

-- 
You are receiving this mail because:
You are watching all bug changes.