[kaffeine] [Bug 376196] Some windows in kaffeine have "OK" and "Cancel" instead of just "Close".

2017-02-15 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=376196

Mauro Carvalho Chehab  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mauro Carvalho Chehab  ---
(In reply to Mauro Carvalho Chehab from comment #1)
> (In reply to yulinux from comment #0)

> The expected behavior is that, by clicking at  will discard the
> changes done at that specific window.
> 
> Perhaps on a few dialogs, the  is not doing the right thing. I'll
> double check.

Changed two dialogs to use  button instead of OK/Cancel:
   - Record Schedule dialog;
   - Program Guide dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 376196] Some windows in kaffeine have "OK" and "Cancel" instead of just "Close".

2017-02-15 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=376196

--- Comment #1 from Mauro Carvalho Chehab  ---
(In reply to yulinux from comment #0)
> Hello, 
> I think since kaffeine is adjusted to KF5 (so from kaffeine 2 on), there are
> some windows (e.g. the EPG window and the program schedule next to it) that
> show the possibilities to "Cancel" and "OK". But there is no difference
> between pressing "Cancel" and "OK", so if you e.g. plan a record and press
> afterwards cancel, the record is saved nonetheless. This is a bit confusing.
> I think in earlier versions those windows just had a "Close" button. Thanks.
> :)

On several such windows, clicking at the (X) button on the top of the windows
(on Kaffeine 1.x) used to cancel the dialog. On Kaffeine 2.x, it should be
doing the same with either (x) or  button.

The expected behavior is that, by clicking at  will discard the changes
done at that specific window.

Perhaps on a few dialogs, the  is not doing the right thing. I'll
double check.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 376196] Some windows in kaffeine have "OK" and "Cancel" instead of just "Close".

2017-02-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376196

Christoph Feck  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.