[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=353747

Christoph Feck  changed:

   What|Removed |Added

   Version Fixed In|5.47|5.48

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=353747

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.47
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kte
   ||xteditor/b099af9eb569f4c076
   ||5cc4bc1aa69adef8f97772
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Nate Graham  ---
Git commit b099af9eb569f4c0765cc4bc1aa69adef8f97772 by Nathaniel Graham.
Committed on 15/06/2018 at 23:16.
Pushed by ngraham into branch 'master'.

Make menu-bearing toolbar buttons show their menus with normal click rather
than click-and-hold

Summary:
Fixes Kate/KWrite's menu-bearing toolbar buttons so that they all show their
drop-down menus immediately when clicked, instead of requiring a click-and-hold
(which is the normal Qt behavior for toolbar buttons with menus).

Note: due to [[ https://bugs.kde.org/show_bug.cgi?id=344746 | a Breeze design
choice ]], this patch has the effect of removing the downward-pointing arrow
that lets you know that the toolbar button will open a menu. There's an open
patch that changes that, though: D13064
FIXED-IN: 5.47

Test Plan: Added {nav Schema}, {nav Mode}, {nav Intentation}, {nav Bookmarks},
{nav Highlighting} and {nav Scripts} buttons to Kate's toolbar and clicked
them. They all showed their drop-down menus immediately.

Reviewers: #ktexteditor, #kate, dhaumann, cullmann

Reviewed By: #ktexteditor, #kate, dhaumann

Subscribers: hpereiradacosta, kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D13026

M  +1-0src/mode/katemodemenu.h
M  +1-0src/schema/kateschema.h
M  +1-0src/script/katescriptaction.cpp
M  +1-0src/syntax/katehighlightmenu.h
M  +1-0src/utils/kateautoindent.cpp
M  +1-0src/utils/katebookmarks.cpp

https://commits.kde.org/ktexteditor/b099af9eb569f4c0765cc4bc1aa69adef8f97772

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=353747

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

--- Comment #5 from Nate Graham  ---
I've updated the patch to fix the other toolbar buttons that can show menus,
too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Dominik Haumann]

https://bugs.kde.org/show_bug.cgi?id=353747

--- Comment #4 from Dominik Haumann  ---
This ia also the same for other actions such as: Tools > Indentation, Mode,
Highlighting, Scripts.

There is currently a discussion about a patch to fix this here:
https://phabricator.kde.org/D13026

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=353747

--- Comment #3 from Nate Graham  ---
We should just need to set `[schemaMenu]->setDelayed(false);`

As soon as I can figure out where to do it, I'll submit a patch...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 353747] Schema button implements a pop-up menu, but menu only opens for click-and-hold

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=353747

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
Summary|Icon from toolbar opens |Schema button implements a
   |only when holding mouse |pop-up menu, but menu only
   |click for short period of   |opens for click-and-hold
   |time|

-- 
You are receiving this mail because:
You are watching all bug changes.