[kate] [Bug 374564] File search opens multiple sessions of the same file

[Kåre Särs]

https://bugs.kde.org/show_bug.cgi?id=374564

Kåre Särs  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kat |https://commits.kde.org/kat
   |e/4059d29f1d4499a0677062487 |e/ff1ab8bd0fd23f189960d4075
   |47ba6339ff5bdf0 |5354b674ed019ac

--- Comment #9 from Kåre Särs  ---
Git commit ff1ab8bd0fd23f189960d40755354b674ed019ac by Kåre Särs.
Committed on 25/01/2017 at 20:15.
Pushed by sars into branch 'Applications/16.12'.

Resolve symbolic links in findDocument() just as KTextEditor does.

Not resolving the links resulted in multiple instances of the same
file when opened multiple times.
REVIEW: 129792

M  +8-0kate/katedocmanager.cpp

https://commits.kde.org/kate/ff1ab8bd0fd23f189960d40755354b674ed019ac

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Kåre Särs]

https://bugs.kde.org/show_bug.cgi?id=374564

Kåre Särs  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kat
   ||e/4059d29f1d4499a0677062487
   ||47ba6339ff5bdf0

--- Comment #8 from Kåre Särs  ---
Git commit 4059d29f1d4499a067706248747ba6339ff5bdf0 by Kåre Särs.
Committed on 25/01/2017 at 20:11.
Pushed by sars into branch 'master'.

Resolve symbolic links in findDocument() just as KTextEditor does.

Not resolving the links resulted in multiple instances of the same
file when opened multiple times.
REVIEW: 129792

M  +8-0kate/katedocmanager.cpp

https://commits.kde.org/kate/4059d29f1d4499a067706248747ba6339ff5bdf0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Ferdinand Gruber]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #7 from Ferdinand Gruber  ---
Thank you for this information.

Ferdinand

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Kåre Särs]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #6 from Kåre Särs  ---
At the moment the only place this is fixed is on my computer.

When the patch is accepted, it goes to the public repo and then you have to
wait for your distro to package the new version or compile it your self.

For the distro it might take quite some time...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Ferdinand Gruber]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #5 from Ferdinand Gruber  ---
Thank you very much.

But please excuse my stupid questions: 
How can I get the changes to work an my system? Where can I get a new binary
file of kate?

Sorry, this is my first experience with such matters.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Kåre Särs]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #4 from Kåre Särs  ---
Hi,

I already have a review request (https://git.reviewboard.kde.org/r/129792/) to
fix it using alternative 1)

What I'm saying is that with alternative 1) you open foo.txt, but you get
baar.txt which is the target of the soft-link.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Ferdinand Gruber]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #3 from Ferdinand Gruber  ---
(In reply to Kåre Särs from comment #2)

> it is a bit strange to try to open foo.txt and get baar.txt ...

Sorry, I cannot quite understand this argument.

If a particular file is already opened, why it gets reopended after each click
on a line in the search result?
I cannot understand, why it is not possible to find out, whether a particular
file is already opened or not.

If it is already opened, there is no need to open it a second time ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Kåre Särs]

https://bugs.kde.org/show_bug.cgi?id=374564

Kåre Särs  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||kare.s...@iki.fi

--- Comment #2 from Kåre Särs  ---
Hi,

The problem here is that KTextEditor resolves symbolic links, while Kate's
document manages does not. There are two solutions:

1) We add sym-link resolving in Kate
2) We stop resolving sym-links in KTextEditor


Alternative 2 is a change in behavior and might not be the best option, but it
is a bit strange to try to open foo.txt and get baar.txt...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 374564] File search opens multiple sessions of the same file

[Ferdinand Gruber]

https://bugs.kde.org/show_bug.cgi?id=374564

--- Comment #1 from Ferdinand Gruber  ---
May be that I have not expressed clearly:
Each mouse click in the search result shown at the bottom of the editor window
opens a new tab of the same file, for example:
file.php, file.php(2), file.php(3), file.php(4) ... 
The files are numbered and they are identical.
If I change something in one of theese files I get trouble with saving the
changes because of the other opened instances. Very annoying!

-- 
You are receiving this mail because:
You are watching all bug changes.