[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-26 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=407910

Christoph Cullmann  changed:

   What|Removed |Added

   Version Fixed In||5.59.0
 CC||cullm...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-26 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=407910

Christoph Cullmann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kte
   ||xteditor/968af10fd4b64cccf6
   ||a858f105ac6cfad9fce78e
 Resolution|--- |FIXED

--- Comment #7 from Christoph Cullmann  ---
Git commit 968af10fd4b64cccf6a858f105ac6cfad9fce78e by Christoph Cullmann, on
behalf of Kishore Gopalakrishnan.
Committed on 26/05/2019 at 11:51.
Pushed by cullmann into branch 'master'.

Add action to reset font size

Summary: Add an action to reset the font size to the default and set the
default shortcut to Ctrl+0

Test Plan:
Zoom out the text. Press Ctrl+0 to go back to default zoom.
Do the same with the 'Reset font size' item in the 'View' menu.
Try to reassign the keyboard shortcut in the shortcuts manager and check that
it works.

Reviewers: #ktexteditor, cullmann

Reviewed By: #ktexteditor, cullmann

Subscribers: cullmann, kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D21412

M  +6-3src/data/katepart5ui.rc
M  +6-0src/render/katerenderer.cpp
M  +1-0src/render/katerenderer.h
M  +7-0src/view/kateview.cpp
M  +5-0src/view/kateviewinternal.cpp
M  +1-0src/view/kateviewinternal.h

https://commits.kde.org/ktexteditor/968af10fd4b64cccf6a858f105ac6cfad9fce78e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-26 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=407910

--- Comment #6 from Kishore Gopalakrishnan  ---
I've posted it here: https://phabricator.kde.org/D21412

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-25 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=407910

--- Comment #5 from Dominik Haumann  ---
You have to add an entry into the KTextEditor ui.rc file:
https://github.com/KDE/ktexteditor/blob/master/src/data/katepart5ui.rc

Note: you have to increase the version number from 82 to 83, otherwise it will
not update caches.

Could you post your patch on phabricator.jde.orf?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-25 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=407910

--- Comment #4 from Lothar  ---
> I still haven't figured out how to get it to show in the 'Edit' menu,

On top of these ui/xml is a version number you need to increase

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-25 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=407910

--- Comment #3 from Kishore Gopalakrishnan  ---
(In reply to Nate Graham from comment #1)
> Konsole now has this, added with
> https://cgit.kde.org/konsole.git/commit/
> ?id=f6e432ab0c04226bd772019911b97298070d1264
> 
> Maybe you could work on a patch, copying how it was done for Konsole?

I have a working patch now, in the sense that the action appears in the
shortcuts manager and if one manually assigns a shortcut to it, one can reset
the font sizes. However, I still haven't figured out how to get it to show in
the 'Edit' menu, or how to correctly assign a default shortcut for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-25 Thread Lothar
https://bugs.kde.org/show_bug.cgi?id=407910

Lothar  changed:

   What|Removed |Added

 CC||loh@googlemail.com

--- Comment #2 from Lothar  ---
There was in the past a nice feature where one wheel tick was ignored when the
font has the default size. But since some weeks is it gone. No idea why that
was "fixed".

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407910

--- Comment #1 from Nate Graham  ---
Konsole now has this, added with
https://cgit.kde.org/konsole.git/commit/?id=f6e432ab0c04226bd772019911b97298070d1264

Maybe you could work on a patch, copying how it was done for Konsole?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 407910] Add keyboard shortcut to change font back to default size

2019-05-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407910

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||n...@kde.org
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.