[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 Waqar Ahmed changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/util ||ities/kate/-/commit/eab99aa ||e7207e8d669d0ec367a34fddd21 ||1fcbbb Status|CONFIRMED |RESOLVED --- Comment #6 from Waqar Ahmed --- Git commit eab99aae7207e8d669d0ec367a34fddd211fcbbb by Waqar Ahmed. Committed on 18/03/2024 at 11:03. Pushed by cullmann into branch 'master'. diag: Fix filtering after removing previous items When this goes wrong we end up having an invalid idx in syncDiagnosticItems and crash (because there is no guard there atm) M +2-0apps/lib/diagnostics/diagnosticview.cpp https://invent.kde.org/utilities/kate/-/commit/eab99aae7207e8d669d0ec367a34fddd211fcbbb -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 Waqar Ahmed changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 Waqar Ahmed changed: What|Removed |Added CC||quinten@quinten.space --- Comment #5 from Waqar Ahmed --- *** Bug 483870 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 --- Comment #4 from Alex Lowe --- Created attachment 166828 --> https://bugs.kde.org/attachment.cgi?id=166828=edit Crash when using pyright 1.1.225 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 --- Comment #3 from Alex Lowe --- Thanks for responding Waqar! The pyright version you're using is quite old (2021 it seems): https://github.com/microsoft/pyright/releases/tag/1.1.193 I've tried with the oldest version I could get from pypi (1.1.225) and it still crashes for me. The crash is only reproducible when the Diagnostics tab is open, with LSP selected from the dropdown, and with Errors selected to the left of the filter box. It takes a few times messing with the annotations, but I can reliably reproduce it with all tried versions of pyright (1.1.225, 1.1.349, 1.1.352) by changing the return type of _extract_file to str, then to tuple[str, str], then back to str, then to tuple[str, str, str]. This occurs both in the current version in Kubuntu 24.04 (Version: 4:23.08.5-0ubuntu1) and in the version from snap (23.08.4 2023-12-10 (171)). I've attached another crash file using pyright 1.1.225. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 Waqar Ahmed changed: What|Removed |Added CC||waqar@gmail.com --- Comment #2 from Waqar Ahmed --- Hi, thanks for reporting the crash. I have tried to reproduce the crash using the following commit https://github.com/canonical/charmcraft/commit/6374ef9e1b6d6f88d7a048e63bb91b633b44c09b pyright version: pyright 1.1.193 Kate 23.08.4 I tried to change the method return type the same way you were doing i.e., remove `(` and started typing tuple but so far I haven't been able to reproduce the crash. I have also tried with kate master which is built with Qt6 and no crashes there as well. Are you using the same pyright version? Perhaps there is another case where it crashes? -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 481381] Crash when filtering certain information from pyright LSP
https://bugs.kde.org/show_bug.cgi?id=481381 --- Comment #1 from Alex Lowe --- Created attachment 165842 --> https://bugs.kde.org/attachment.cgi?id=165842=edit Crash dump from crash when changing output type in `charmcraft/store/registry.py` This crash dump is from a session where I was changing return type of `_extract_file` in charmcraft/store/registry.py. Pyright was reporting an invalid type form (Tuple expression not allowed in type annotation). I deleted the opening parenthesis of the tuple type and began typing "tuple". This crash is repeatable from this commit: https://github.com/canonical/charmcraft/commit/c5cae21182139db75ebd455b7398272994895c9e -- You are receiving this mail because: You are watching all bug changes.
