[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=357824

Christoph Feck  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||18.08.2
  Latest Commit||https://commits.kde.org/kca
   ||lc/f00e48b6a50fccba2e3a43d0
   ||6752e2043fd20633
 Status|REPORTED|RESOLVED

--- Comment #6 from Christoph Feck  ---
Git commit f00e48b6a50fccba2e3a43d06752e2043fd20633 by Christoph Feck, on
behalf of Arthur Pichlkostner.
Committed on 02/10/2018 at 22:08.
Pushed by cfeck into branch 'Applications/18.08'.

Allow shortcut keys for both decimal separators point and comma

Re-enable commented out code to handle both '.' and ',' shortcut keys
for the decimal separator. Also port it from KLocale to QLocale.
FIXED-IN: 18.08.2

Test Plan:

Running kcalc with both locale en_US.UTF-8 and de_DE.UTF-8.
In both cases the keys '.' and ',' work.

Reviewed By: cfeck

Differential Revision: https://phabricator.kde.org/D15680

M  +4-5kcalc.cpp

https://commits.kde.org/kcalc/f00e48b6a50fccba2e3a43d06752e2043fd20633

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[Torben Hansen]

https://bugs.kde.org/show_bug.cgi?id=357824

--- Comment #5 from Torben Hansen  ---
I have tested the patch against kcalc-16.08.2. Confirmed that it solve the
problem.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=357824

--- Comment #4 from martonmiklos  ---
Created attachment 106662
  --> https://bugs.kde.org/attachment.cgi?id=106662=edit
Proposed patch

Proposed patch. Feel free to review!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=357824

martonmiklos  changed:

   What|Removed |Added

 CC||martonmiklosq...@gmail.com

--- Comment #3 from martonmiklos  ---
Ok, here is what I see:
- I have set my layout to English UK, and run the kcalc with LANG=en_GB.UTF-8
environment
- I can reproduce it with the latest git master.
- In the keyPressEvent an event with the key is Qt::Key_Comma wit this setup

AFAIK noone would want to type in group separator (thousand separator) with the
keypad comma. 

If others can confirm it I can create a patch easily. 

There is already a workaround in the code for the following similar kind of
bug:
https://bugs.kde.org/show_bug.cgi?id=314586

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[Torben Hansen]

https://bugs.kde.org/show_bug.cgi?id=357824

--- Comment #2 from Torben Hansen  ---
This is still an issue with version 16.08.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 357824] Decimal point on numpad not working for en_GB and Danish keyboard layout

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=357824

Christoph Feck  changed:

   What|Removed |Added

 CC||sami.tikka...@haxaa.net

--- Comment #1 from Christoph Feck  ---
*** Bug 374929 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.